December 2018 - devel

[PATCH V3 1/1] csky: Add EM_CSKY for ldso
by guoren＠kernel.org 26 Dec '18

26 Dec '18

From: Guo Ren <ren_guo(a)c-sky.com> Support EM_CSKY 252 elf format. Changelog: Increase EM_NUM to 253 Signed-off-by: Guo Ren <ren_guo(a)c-sky.com> Signed-off-by: Mao Han <han_mao(a)c-sky.com> --- include/elf.h | 3 ++- ldso/ldso/csky/dl-sysdep.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/elf.h b/include/elf.h index a9957fc..9aae04c 100644 --- a/include/elf.h +++ b/include/elf.h @@ -271,9 +271,10 @@ typedef struct #define EM_AARCH64 183 /* ARM AARCH64 */ #define EM_MICROBLAZE 189 /* Xilinx Microblaze */ #define EM_ARCV2 195 /* ARCv2 Cores */ +#define EM_CSKY 252 /* C-SKY Cores */ /* NEXT FREE NUMBER: Increment this after adding your official arch number */ -#define EM_NUM 196 +#define EM_NUM 253 /* If it is necessary to assign new unofficial EM_* values, please pick large random numbers (0x8523, 0xa7f2, etc.) to minimize the chances of collision diff --git a/ldso/ldso/csky/dl-sysdep.h b/ldso/ldso/csky/dl-sysdep.h index 04aae68..2230450 100644 --- a/ldso/ldso/csky/dl-sysdep.h +++ b/ldso/ldso/csky/dl-sysdep.h @@ -18,7 +18,7 @@ do { \ /* Here we define the magic numbers that this dynamic loader should accept */ #define MAGIC1 EM_MCORE -#undef MAGIC2 +#define MAGIC2 EM_CSKY /* Used for error messages */ #define ELF_TARGET "csky" -- 2.7.4

1 0

[PATCH V2 1/1] csky: Add EM_CSKY for ldso
by guoren＠kernel.org 26 Dec '18

26 Dec '18

From: Guo Ren <ren_guo(a)c-sky.com> Support EM_CSKY 252 elf format. Changelog: Increase EM_NUM to 253 Signed-off-by: Guo Ren <ren_guo(a)c-sky.com> --- include/elf.h | 3 ++- ldso/ldso/csky/dl-sysdep.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/elf.h b/include/elf.h index a9957fc..9aae04c 100644 --- a/include/elf.h +++ b/include/elf.h @@ -271,9 +271,10 @@ typedef struct #define EM_AARCH64 183 /* ARM AARCH64 */ #define EM_MICROBLAZE 189 /* Xilinx Microblaze */ #define EM_ARCV2 195 /* ARCv2 Cores */ +#define EM_CSKY 252 /* C-SKY Cores */ /* NEXT FREE NUMBER: Increment this after adding your official arch number */ -#define EM_NUM 196 +#define EM_NUM 253 /* If it is necessary to assign new unofficial EM_* values, please pick large random numbers (0x8523, 0xa7f2, etc.) to minimize the chances of collision diff --git a/ldso/ldso/csky/dl-sysdep.h b/ldso/ldso/csky/dl-sysdep.h index 04aae68..2230450 100644 --- a/ldso/ldso/csky/dl-sysdep.h +++ b/ldso/ldso/csky/dl-sysdep.h @@ -18,7 +18,7 @@ do { \ /* Here we define the magic numbers that this dynamic loader should accept */ #define MAGIC1 EM_MCORE -#undef MAGIC2 +#define MAGIC2 EM_CSKY /* Used for error messages */ #define ELF_TARGET "csky" -- 2.7.4

1 0

[PATCH] csky: Add EM_CSKY for ldso
by guoren＠kernel.org 26 Dec '18

26 Dec '18

From: Guo Ren <ren_guo(a)c-sky.com> Support EM_CSKY 252 elf format. Signed-off-by: Guo Ren <ren_guo(a)c-sky.com> --- include/elf.h | 1 + ldso/ldso/csky/dl-sysdep.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/elf.h b/include/elf.h index a9957fc..3476453 100644 --- a/include/elf.h +++ b/include/elf.h @@ -271,6 +271,7 @@ typedef struct #define EM_AARCH64 183 /* ARM AARCH64 */ #define EM_MICROBLAZE 189 /* Xilinx Microblaze */ #define EM_ARCV2 195 /* ARCv2 Cores */ +#define EM_CSKY 252 /* C-SKY Cores */ /* NEXT FREE NUMBER: Increment this after adding your official arch number */ #define EM_NUM 196 diff --git a/ldso/ldso/csky/dl-sysdep.h b/ldso/ldso/csky/dl-sysdep.h index 04aae68..2230450 100644 --- a/ldso/ldso/csky/dl-sysdep.h +++ b/ldso/ldso/csky/dl-sysdep.h @@ -18,7 +18,7 @@ do { \ /* Here we define the magic numbers that this dynamic loader should accept */ #define MAGIC1 EM_MCORE -#undef MAGIC2 +#define MAGIC2 EM_CSKY /* Used for error messages */ #define ELF_TARGET "csky" -- 2.7.4

1 0

[PATCH] rt/tst-posix_spawn: fix random crash due to uninitialized var
by Vineet Gupta 21 Dec '18

21 Dec '18

Seen on ARC when it passed in 1 setup, but segv on other | Path: /sd/arc_initramfs_hs_1812-gnu-2018.09-BIG/uClibc-ng-testsuite-Os/rt/tst-posix_spawn | CPU: 1 PID: 3313 Comm: tst-posix_spawn Not tainted | 4.19.0-00003-ga4e0cf751ad3 #108 | | [ECR ]: 0x00050100 => Invalid Read @ 0x00000000 by insn @ 0x20060c84 | [EFA ]: 0x00000000 | [BLINK ]: 0x20060bf4 | [ERET ]: 0x20060c84 | @off 0x52c84 in [/lib/libuClibc-1.0.29.so] | VMA: 0x2000e000 to 0x20072000 Signed-off-by: Vineet Gupta <vgupta(a)synopsys.com> --- test/rt/tst-posix_spawn.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/rt/tst-posix_spawn.c b/test/rt/tst-posix_spawn.c index 28b6500c8e57..45cd325063f8 100644 --- a/test/rt/tst-posix_spawn.c +++ b/test/rt/tst-posix_spawn.c @@ -26,6 +26,7 @@ void run_cmd(char *cmd) posix_spawnattr_setflags(&attrs, POSIX_SPAWN_SETPGROUP | POSIX_SPAWN_SETSIGDEF); posix_spawnattr_setpgroup(&attrs, 0); posix_spawnattr_setsigdefault(&attrs, &defsignals); + posix_spawn_file_actions_init(&actions); printf("Run command: %s\n", cmd); status = posix_spawn(&pid, "/bin/sh", &actions, &attrs, argv, environ); -- 2.7.4

1 0

uclibc-ng-test and math complex functions
by Laurent Thévenoux 20 Dec '18

20 Dec '18

Hi, I'm trying to build uclibc-ng-test, but I can't link with complex trigo functions (such as cacos, casin, catan, etc.). They are required for the following test targets: test-double, test-double-finite, test-float, test-float-finite, test-idouble, and test-ifloat. They are declared in uclibc-ng/sysdeps/linux/common/bits/cmathcalls.h, but I can't find their definitions. Does uclibc-ng define them? Thanks, -- Laurent Thévenoux lthevenoux(a)kalray.eu Kalray S.A. 180 Avenue de l'Europe 38330 Montbonnot FRANCE

5 7

[PATCH] xtensa: add custom bits/poll.h
by Max Filippov 14 Dec '18

14 Dec '18

Definitions of POLLWRNORM, POLLWRBAND and POLLREMOVE in xtensa linux kernel are non-standard. Provide bits/poll.h with correct values for these constants. This fixes the following strace build errors: In file included from xlat/pollflags.h:4:0, from poll.c:34: ./static_assert.h:40:24: error: static assertion failed: "POLLWRBAND != 0x0100" # define static_assert _Static_assert ^ xlat/pollflags.h:75:1: note: in expansion of macro ‘static_assert’ static_assert((POLLWRBAND) == (0x0100), "POLLWRBAND != 0x0100"); ^~~~~~~~~~~~~ ./static_assert.h:40:24: error: static assertion failed: "POLLREMOVE != 0x0800" # define static_assert _Static_assert ^ xlat/pollflags.h:117:1: note: in expansion of macro ‘static_assert’ static_assert((POLLREMOVE) == (0x0800), "POLLREMOVE != 0x0800"); ^~~~~~~~~~~~~ Signed-off-by: Max Filippov <jcmvbkbc(a)gmail.com> --- libc/sysdeps/linux/xtensa/bits/poll.h | 49 +++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 libc/sysdeps/linux/xtensa/bits/poll.h diff --git a/libc/sysdeps/linux/xtensa/bits/poll.h b/libc/sysdeps/linux/xtensa/bits/poll.h new file mode 100644 index 000000000000..4588cc326006 --- /dev/null +++ b/libc/sysdeps/linux/xtensa/bits/poll.h @@ -0,0 +1,49 @@ +/* Copyright (C) 1997, 2001, 2006 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + <http://www.gnu.org/licenses/>. */ + +#ifndef _SYS_POLL_H +# error "Never use <bits/poll.h> directly; include <sys/poll.h> instead." +#endif + +/* Event types that can be polled for. These bits may be set in `events' + to indicate the interesting event types; they will appear in `revents' + to indicate the status of the file descriptor. */ +#define POLLIN 0x001 /* There is data to read. */ +#define POLLPRI 0x002 /* There is urgent data to read. */ +#define POLLOUT 0x004 /* Writing now will not block. */ + +#ifdef __USE_XOPEN +/* These values are defined in XPG4.2. */ +# define POLLRDNORM 0x040 /* Normal data may be read. */ +# define POLLRDBAND 0x080 /* Priority data may be read. */ +# define POLLWRNORM POLLOUT /* Writing now will not block. */ +# define POLLWRBAND 0x100 /* Priority data may be written. */ +#endif + +#ifdef __USE_GNU +/* These are extensions for Linux. */ +# define POLLMSG 0x400 +# define POLLREMOVE 0x800 +# define POLLRDHUP 0x2000 +#endif + +/* Event types always implicitly polled for. These bits need not be set in + `events', but they will appear in `revents' to indicate the status of + the file descriptor. */ +#define POLLERR 0x008 /* Error condition. */ +#define POLLHUP 0x010 /* Hung up. */ +#define POLLNVAL 0x020 /* Invalid polling request. */ -- 2.11.0

2 1

Re: [uclibc-ng-devel] use safe, even if possibly a few cycles slower, six-argument syscall implementation
by Ata, John (US) 06 Dec '18

06 Dec '18

On January 29,2017 a patch (9b457baf8d46329f7d7ee2aa084022bb0df88551<https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/commit/?id=9b457baf8d4632…>)by mirabilos m(a)mirbsd.org<mailto:m@mirbsd.org> was accepted in the repository. I have a few questions on this patch. 1) The patch created a new file syscall6.S in the i386 directory. It seems functionally equivalent to the syscall.S. Both process 6 arguments plus the NR. Both use the exact same registers. Only an alignment directive has been added and the order of loading the registers is reverse. It also appears that glib does not have a special syscall6.S. Why did we go this route special casing 6 argument syscalls only? 2) The LOADARGS_6, RESTOREARGS_6 and ASMFMT_6 defines are removed from <bits/syscall.h>. It is not clear why from the patch. 3) There seems to be a deficiency in the syscall setup that is not present in glibc making it impossible to get a backtrace from a syscall. For example, If one looks at uclibs-ng's sysdeps.h in i386, one can see cfi_adjust_cfa_offset/cfi_rel_offset usage in the _PUSH_ARGS_1 and _POP_ARGS_N macros allowing backtrace information to be present on the stack. However, syscall/syscall6.S as well as bits/syscalls.h do not allow for this. In addition, it appears that glibc does have this mechanism in its syscall.S. Thoughts anyone? Thanks, ---- John Ata, CISSP Senior Principal Software Engineer Electronics Systems STOP Operating System<http://www.baesystems.com/en-us/product/stop> Software Development T 703-563-8115 | F 703-668-4359 | john.ata(a)baesystems.com<mailto:john.ata@baesystems.com> http://www.baesystems.com/csp [cid:image001.png@01D138BC.8E54E330][cid:image003.png@01D138BC.8E54E330]<http://www.twitter.com/baesystemsinc>[cid:image004.png@01D138BC.8E54E330]<http://www.youtube.com/baesystemsinc>[cid:image006.png@01D138BC.8E54E330]<http://www.flickr.com/photos/baesystemsinc/>

1 0