- devel - example.com

[PATCH] avoid crashes in statical linked binaries when dlopen()
by tinyusbboard .matrixstorm 18 Oct '25

18 Oct '25

Even in current (1.0.55) releaes of uClibc-ng there will be 100% reproducible crashes of statically linked binaries (on all kind of platforms), when calling "dlopen(...)" with wrong or non-existing .so-files). #0 0x0000000000404b62 in _dl_load_shared_library () #1 0x0000000000404d49 in do_dlopen () #2 0x0000000000405286 in dlopen () This is caused by missing checks on "_dl_loaded_modules" in "ldso/ldso/dl-elf.c". When "_dl_loaded_modules" is NULL in static linked binaries, it becomes dereferenced and causes an segfault. This patch fixes the issue by adding an extra assignment-check for "_dl_loaded_modules". Signed-off-by: Stephan Baerwolf <stephan(a)matrixstorm.com> --- ldso/ldso/dl-elf.c | 44 ++++++++++++++++++++++++-------------------- 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/ldso/ldso/dl-elf.c b/ldso/ldso/dl-elf.c index 6656acb0f..dc2185d7d 100644 --- a/ldso/ldso/dl-elf.c +++ b/ldso/ldso/dl-elf.c @@ -276,12 +276,14 @@ struct elf_resolve *_dl_load_shared_library(unsigned int rflags, struct dyn_elf /* * Try the DT_RPATH of the executable itself. */ - pnt = (char *) _dl_loaded_modules->dynamic_info[DT_RPATH]; - if (pnt) { - pnt += (unsigned long) _dl_loaded_modules->dynamic_info[DT_STRTAB]; - _dl_if_debug_dprint("\tsearching exe's RPATH='%s'\n", pnt); - if ((tpnt1 = search_for_named_library(libname, rflags, pnt, rpnt, NULL)) != NULL) - return tpnt1; + if (_dl_loaded_modules) { + pnt = (char *) _dl_loaded_modules->dynamic_info[DT_RPATH]; + if (pnt) { + pnt += (unsigned long) _dl_loaded_modules->dynamic_info[DT_STRTAB]; + _dl_if_debug_dprint("\tsearching exe's RPATH='%s'\n", pnt); + if ((tpnt1 = search_for_named_library(libname, rflags, pnt, rpnt, NULL)) != NULL) + return tpnt1; + } } #endif #endif @@ -361,20 +363,22 @@ struct elf_resolve *_dl_load_shared_library(unsigned int rflags, struct dyn_elf * abusing this bug^Wrelaxed, user-friendly behaviour. */ - pnt = (char *) _dl_loaded_modules->dynamic_info[DT_RUNPATH]; - if (pnt) { - pnt += (unsigned long) _dl_loaded_modules->dynamic_info[DT_STRTAB]; - _dl_if_debug_dprint("\tsearching exe's RUNPATH='%s'\n", pnt); - if ((tpnt1 = search_for_named_library(libname, rflags, pnt, rpnt, NULL)) != NULL) - return tpnt1; - } - pnt = (char *) _dl_loaded_modules->dynamic_info[DT_RPATH]; - if (pnt) { - pnt += (unsigned long) _dl_loaded_modules->dynamic_info[DT_STRTAB]; - _dl_if_debug_dprint("\tsearching exe's RPATH='%s'\n", pnt); - if ((tpnt1 = search_for_named_library(libname, rflags, pnt, rpnt, NULL)) != NULL) - return tpnt1; - } + if (_dl_loaded_modules) { + pnt = (char *) _dl_loaded_modules->dynamic_info[DT_RUNPATH]; + if (pnt) { + pnt += (unsigned long) _dl_loaded_modules->dynamic_info[DT_STRTAB]; + _dl_if_debug_dprint("\tsearching exe's RUNPATH='%s'\n", pnt); + if ((tpnt1 = search_for_named_library(libname, rflags, pnt, rpnt, NULL)) != NULL) + return tpnt1; + } + pnt = (char *) _dl_loaded_modules->dynamic_info[DT_RPATH]; + if (pnt) { + pnt += (unsigned long) _dl_loaded_modules->dynamic_info[DT_STRTAB]; + _dl_if_debug_dprint("\tsearching exe's RPATH='%s'\n", pnt); + if ((tpnt1 = search_for_named_library(libname, rflags, pnt, rpnt, NULL)) != NULL) + return tpnt1; + } + } #endif -- 2.30.2

2 1

شهادة الأبوة في المغرب
by jib l3azz 02 Oct '25

02 Oct '25

شهادة الأبوة في المغرب

1 0

[PATCH] libc: kvx: add {get,set,swap,make}context functions
by Julian Vetter 21 Sep '25

21 Sep '25

Add the obsolescent SUSv3 family of user context manipulating functions for kvx. Signed-off-by: Julian Vetter <jvetter(a)kalrayinc.com> --- extra/Configs/Config.kvx | 1 + libc/sysdeps/linux/kvx/Makefile.arch | 2 + libc/sysdeps/linux/kvx/getcontext.S | 81 ++++++++++++++++++++ libc/sysdeps/linux/kvx/makecontext.c | 53 +++++++++++++ libc/sysdeps/linux/kvx/setcontext.S | 106 ++++++++++++++++++++++++++ libc/sysdeps/linux/kvx/swapcontext.S | 63 +++++++++++++++ libc/sysdeps/linux/kvx/sys/ucontext.h | 4 +- libc/sysdeps/linux/kvx/ucontext_i.sym | 28 +++++++ 8 files changed, 337 insertions(+), 1 deletion(-) create mode 100644 libc/sysdeps/linux/kvx/getcontext.S create mode 100644 libc/sysdeps/linux/kvx/makecontext.c create mode 100644 libc/sysdeps/linux/kvx/setcontext.S create mode 100644 libc/sysdeps/linux/kvx/swapcontext.S create mode 100644 libc/sysdeps/linux/kvx/ucontext_i.sym diff --git a/extra/Configs/Config.kvx b/extra/Configs/Config.kvx index 04df53c38..4d8152ab9 100644 --- a/extra/Configs/Config.kvx +++ b/extra/Configs/Config.kvx @@ -30,6 +30,7 @@ config FORCE_OPTIONS_FOR_ARCH default y select ARCH_LITTLE_ENDIAN select ARCH_HAS_MMU + select ARCH_HAS_UCONTEXT select UCLIBC_HAS_FPU select UCLIBC_HAS_FENV select UCLIBC_HAS_WCHAR diff --git a/libc/sysdeps/linux/kvx/Makefile.arch b/libc/sysdeps/linux/kvx/Makefile.arch index 3ad290915..18f2118f6 100644 --- a/libc/sysdeps/linux/kvx/Makefile.arch +++ b/libc/sysdeps/linux/kvx/Makefile.arch @@ -8,3 +8,5 @@ CSRC-y := __syscall_error.c CSRC-$(UCLIBC_LINUX_SPECIFIC) += cachectl.c SSRC-y := setjmp.S bsd-setjmp.S bsd-_setjmp.S __longjmp.S clone.S vfork.S +CSRC-$(UCLIBC_HAS_CONTEXT_FUNCS) += makecontext.c +SSRC-$(UCLIBC_HAS_CONTEXT_FUNCS) += getcontext.S setcontext.S swapcontext.S diff --git a/libc/sysdeps/linux/kvx/getcontext.S b/libc/sysdeps/linux/kvx/getcontext.S new file mode 100644 index 000000000..9440f67ce --- /dev/null +++ b/libc/sysdeps/linux/kvx/getcontext.S @@ -0,0 +1,81 @@ +/* + * This file is subject to the terms and conditions of the GNU General Public + * License. See the file "COPYING" in the main directory of this archive for + * more details. + * + * Copyright (C) 2025 Kalray Inc. + * Author(s): Julian Vetter <jvetter(a)kalrayinc.com> + */ + +#include <sysdep.h> + +#include "ucontext_i.h" + + .text + +/* + * int getcontext (ucontext_t *ucp) + */ +ENTRY(__getcontext) + /* Save callee saved registers ($r14, $r18 - $r31) + * and some special registers */ + + /* Save the entire occtuple, although we only need $sp and $r14 */ + so MCONTEXT_Q12[$r0] = $r12r13r14r15 + get $r4 = $lc + ;; + /* Don't need to save veneer registers $r16 and $r17 */ + sq (MCONTEXT_Q16 + 16)[$r0] = $r18r19 + get $r5 = $le + ;; + so MCONTEXT_Q20[$r0] = $r20r21r22r23 + get $r6 = $ls + ;; + so MCONTEXT_Q24[$r0] = $r24r25r26r27 + get $r7 = $ra + ;; + so MCONTEXT_Q28[$r0] = $r28r29r30r31 + get $r8 = $cs + ;; + so MCONTEXT_LC_LE_LS_RA[$r0] = $r4r5r6r7 + /* Save ucp and $ra in callee saved registers because below we need to + * do a call to sigprocmask and afterwards we need to restore $ra. */ + copyd $r20 = $r0 + copyd $r21 = $r7 + ;; + sd MCONTEXT_CS_SPC[$r0] = $r8 + + /* Prepare call to sigprocmask */ + make $r0 = SIG_BLOCK + make $r1 = 0 + ;; + /* $r20 points to the ucontext */ + addd $r2 = $r20, UCONTEXT_SIGMASK + /* Already set the return value for when this is called in the context + * of swapcontext. Because when this context returns it should look + * like as if swapcontext returned with 0. */ + sd MCONTEXT_Q0[$r20] = $r1 + ;; + /* sigprocmask(SIG_BLOCK, NULL, &(ucontext->uc_sigmask)) */ + call sigprocmask + ;; + /* Restore $ra to point to the caller of this function. So, + * __getcontext will return with -1 (set by __syscall_error) and an + * appropriate errno */ + set $ra = $r21 + ;; + /* Check return value of sigprocmask */ + cb.deqz $r0 ? 1f + ;; + goto __syscall_error + ;; +1: + /* Restore used callee saved registers */ + lq $r20r21 = MCONTEXT_Q20[$r20] + ;; + /* Set return value */ + make $r0 = 0 + ret + ;; +END(__getcontext) +weak_alias(__getcontext, getcontext) diff --git a/libc/sysdeps/linux/kvx/makecontext.c b/libc/sysdeps/linux/kvx/makecontext.c new file mode 100644 index 000000000..a52eded9f --- /dev/null +++ b/libc/sysdeps/linux/kvx/makecontext.c @@ -0,0 +1,53 @@ +/* + * This file is subject to the terms and conditions of the GNU General Public + * License. See the file "COPYING" in the main directory of this archive for + * more details. + * + * Copyright (C) 2025 Kalray Inc. + * Author(s): Julian Vetter <jvetter(a)kalrayinc.com> + */ + +#include <stdarg.h> +#include <ucontext.h> + + +/* Number of arguments that go in registers. */ +#define NREG_ARGS 12 + +/* Take a context previously prepared via getcontext() and set to + call func() with the given int only args. */ +void +__makecontext (ucontext_t *ucp, void (*func) (void), int argc, ...) +{ + extern void __startcontext (void); + unsigned long *funcstack; + va_list vl; + unsigned long *regptr; + unsigned int reg; + + /* Start at the top of stack. */ + funcstack = (unsigned long *) (ucp->uc_stack.ss_sp + ucp->uc_stack.ss_size); + funcstack -= argc < NREG_ARGS ? 0 : argc - NREG_ARGS; + funcstack = (unsigned long *) (((uintptr_t) funcstack & -32L)); + + ucp->uc_mcontext.sc_regs.r12 = (unsigned long) funcstack; + /* Use $r20 and $r21 to pass some infos to __startcontext */ + ucp->uc_mcontext.sc_regs.r20 = (unsigned long) ucp->uc_link; + ucp->uc_mcontext.sc_regs.r21 = (unsigned long) func; + ucp->uc_mcontext.sc_regs.ra = (unsigned long) __startcontext; + + va_start (vl, argc); + + /* The first twelve arguments go into registers. */ + regptr = &(ucp->uc_mcontext.sc_regs.r0); + + for (reg = 0; (reg < argc) && (reg < NREG_ARGS); reg++) + *regptr++ = va_arg (vl, unsigned long); + + /* And the remainder on the stack. */ + for (; reg < argc; reg++) + *funcstack++ = va_arg (vl, unsigned long); + + va_end (vl); +} +weak_alias (__makecontext, makecontext) diff --git a/libc/sysdeps/linux/kvx/setcontext.S b/libc/sysdeps/linux/kvx/setcontext.S new file mode 100644 index 000000000..7b91d21d9 --- /dev/null +++ b/libc/sysdeps/linux/kvx/setcontext.S @@ -0,0 +1,106 @@ +/* + * This file is subject to the terms and conditions of the GNU General Public + * License. See the file "COPYING" in the main directory of this archive for + * more details. + * + * Copyright (C) 2025 Kalray Inc. + * Author(s): Julian Vetter <jvetter(a)kalrayinc.com> + */ + +#include <sysdep.h> + +#include "ucontext_i.h" + + .text + +/* + * int setcontext (const ucontext_t *ucp) + */ +ENTRY(__setcontext) + get $r16 = $ra + addd $r12 = $r12, -32 + ;; + /* Save ucp pointer and $ra on the stack because we can't trash + * any callee saved registers in case __setcontext returns */ + sd 16[$r12] = $r16 + ;; + sd 24[$r12] = $r0 + ;; + /* Bring back the signal status. */ + make $r0 = SIG_SETMASK + addd $r1 = $r0, UCONTEXT_SIGMASK + make $r2 = 0 + ;; + /* sigprocmask(SIG_SETMASK, &(ucontext->uc_sigmask), NULL) */ + call sigprocmask + ;; + /* Check return value of sigprocmask */ + cb.deqz $r0 ? 1f + /* Normally __setcontext does not return. But in case of an error it + * returns with -1 and an appropriate errno */ + ld $r16 = 16[$r12] + ;; + set $ra = $r16 + addd $r12 = $r12, 32 + ;; + goto __syscall_error + ;; +1: + /* Get back the ucp pointer */ + ld $r16 = 24[$r12] + /* Reset the stack pointer (we can trash $ra here, because we will + * never return to after __setcontext from this point onwards) */ + addd $r12 = $r12, 32 + ;; + /* Restore callee saved registers */ + lq $r18r19 = (MCONTEXT_Q16 + 16)[$r16] + ;; + /* Setup $r20, $r21 for the __startcontext to work */ + lo $r20r21r22r23 = MCONTEXT_Q20[$r16] + ;; + lo $r24r25r26r27 = MCONTEXT_Q24[$r16] + ;; + lo $r28r29r30r31 = MCONTEXT_Q28[$r16] + ;; + /* Restore special registers */ + lo $r40r41r42r43 = MCONTEXT_LC_LE_LS_RA[$r16] + ;; + /* Now load argument registers */ + lo $r0r1r2r3 = MCONTEXT_Q0[$r16] + set $lc = $r40 + ;; + lo $r4r5r6r7 = MCONTEXT_Q4[$r16] + set $le = $r41 + ;; + lo $r8r9r10r11 = MCONTEXT_Q8[$r16] + set $ls = $r42 + ;; + /* Restore $sp */ + ld $r12 = MCONTEXT_Q12[$r16] + /* Restore $ra which points to the $ra set by __getcontext or + * to__startcontext if __makecontext was called in between */ + set $ra = $r43 + ;; + ld $r40 = MCONTEXT_CS_SPC[$r16] + ;; + ld $r14 = (MCONTEXT_Q12 + 16)[$r16] + set $cs = $r40 + ;; + ret + ;; +END(setcontext) +weak_alias(__setcontext, setcontext) + +ENTRY(__startcontext) + icall $r21 + ;; + copyd $r0 = $r20 + /* Check if the new context is 0 if so just call _exit */ + cb.deqz $r20 ? 1f + ;; + goto __setcontext + ;; + /* This should never be reached otherwise kill the thread */ +1: goto _exit + ;; +END(__startcontext) diff --git a/libc/sysdeps/linux/kvx/swapcontext.S b/libc/sysdeps/linux/kvx/swapcontext.S new file mode 100644 index 000000000..1abb6a8a8 --- /dev/null +++ b/libc/sysdeps/linux/kvx/swapcontext.S @@ -0,0 +1,63 @@ +/* + * This file is subject to the terms and conditions of the GNU General Public + * License. See the file "COPYING" in the main directory of this archive for + * more details. + * + * Copyright (C) 2025 Kalray Inc. + * Author(s): Julian Vetter <jvetter(a)kalrayinc.com> + */ + +#include <sysdep.h> + +#include "ucontext_i.h" + + .text + +/* int swapcontext (ucontext_t *oucp, const ucontext_t *ucp) */ + +ENTRY(swapcontext) + /* Make space on the stack to save all caller saved registers */ + get $r16 = $ra + addd $r12 = $r12, -32 + ;; + + /* Save $ra on the stack */ + sd (24)[$r12] = $r16 + ;; + /* Save the arguments of swapcontext on the stack */ + sq (8)[$r12] = $r0r1 + ;; + call __getcontext + ;; + + /* Save the return value of __getcontext in $r17 */ + copyd $r17 = $r0 + + /* Restore $ra */ + ld $r16 = (24)[$r12] + ;; + /* Restore arguments */ + lq $r0r1 = (8)[$r12] + /* Readjust the stack pointer */ + addd $r12 = $r12, 32 + /* Also restore $ra */ + set $ra = $r16 + ;; + + /* Exit if getcontext() failed */ + cb.deqz $r17 ? 1f + ;; + + /* Set the return value set by __syscall_error in __getcontext */ + copyd $r0 = $r17 + ret + ;; +1: + /* Store the $sp and $ra in the context to be saved */ + sd (MCONTEXT_Q12)[$r0] = $r12 + ;; + sd (MCONTEXT_LC_LE_LS_RA + 24)[$r0] = $r16 + copyd $r0 = $r1 + goto __setcontext + ;; +END(swapcontext) diff --git a/libc/sysdeps/linux/kvx/sys/ucontext.h b/libc/sysdeps/linux/kvx/sys/ucontext.h index a97b83cad..6a30a09e2 100644 --- a/libc/sysdeps/linux/kvx/sys/ucontext.h +++ b/libc/sysdeps/linux/kvx/sys/ucontext.h @@ -17,11 +17,13 @@ /* Type for general register. */ typedef unsigned long greg_t; +typedef struct sigcontext mcontext_t; + typedef struct ucontext { unsigned long uc_flags; struct ucontext *uc_link; stack_t uc_stack; - struct sigcontext uc_mcontext; + mcontext_t uc_mcontext; sigset_t uc_sigmask; /* mask last for extensibility */ } ucontext_t; diff --git a/libc/sysdeps/linux/kvx/ucontext_i.sym b/libc/sysdeps/linux/kvx/ucontext_i.sym new file mode 100644 index 000000000..d2b565332 --- /dev/null +++ b/libc/sysdeps/linux/kvx/ucontext_i.sym @@ -0,0 +1,28 @@ +#include <inttypes.h> +#include <signal.h> +#include <stddef.h> +#include <sys/ucontext.h> + +SIG_BLOCK +SIG_SETMASK + +-- Offsets of the fields in the ucontext_t structure. +#define ucontext(member) offsetof (ucontext_t, member) +#define mcontext(member) ucontext (uc_mcontext.member) + +UCONTEXT_FLAGS ucontext (uc_flags) +UCONTEXT_LINK ucontext (uc_link) +UCONTEXT_STACK ucontext (uc_stack) +UCONTEXT_MCONTEXT ucontext (uc_mcontext) +UCONTEXT_SIGMASK ucontext (uc_sigmask) + +MCONTEXT_Q0 mcontext (sc_regs.r0) +MCONTEXT_Q4 mcontext (sc_regs.r4) +MCONTEXT_Q8 mcontext (sc_regs.r8) +MCONTEXT_Q12 mcontext (sc_regs.r12) +MCONTEXT_Q16 mcontext (sc_regs.r16) +MCONTEXT_Q20 mcontext (sc_regs.r20) +MCONTEXT_Q24 mcontext (sc_regs.r24) +MCONTEXT_Q28 mcontext (sc_regs.r28) +MCONTEXT_LC_LE_LS_RA mcontext (sc_regs.lc) +MCONTEXT_CS_SPC mcontext (sc_regs.cs) -- 2.34.1

2 3

uClibc-ng 1.0.55 release
by Waldemar Brodkorb 20 Sep '25

20 Sep '25

Hi uClibc-ng hackers, a new release is out. Finally the aarch64 tls bug is fixed. Unfortunately it is not covered by any testcase of uClibc-ng-test. Here is the git shortlog for the release: Marius Melzer (1): malloc-standard: Fix truncation problem in malloc Waldemar Brodkorb (5): Fix Sysvipc for ARM, AARCH64, RISCV64, KVX and m68k remove uClibc specific gettext_printf aarch64: do not force tls-model in CPU_CFLAGS, this isn't required aarch64: respect r_addend for TLSDESC relocations bump version for 1.0.55 release yliu (5): mips32: Preventing FORCE_FRAME_POINTER from being optimized away mips32: Define __IPC_64 according to kernel version time64: fixed msgctl/semctl/shmctl result errors for for MIPS32/RISCV32 time64: fix *ctl functions in mips32eb/mips64 time64: fix *ctl functions in mips32eb Thanks yliu for the SysVIPC fixes! best regards Waldemar

2 2

[PATCH] malloc-standard: Fix truncation problem in malloc
by Marcus Haehnel 10 Aug '25

10 Aug '25

From: Marius Melzer <marius.melzer(a)kernkonzept.com> This fixes a bug that can lead to the calculation of a wrong bin `idx`, which in turn leads to a too small chunk of memory being chosen for the number of bytes (`nb`) to be allocated. This leads to a fault (or possibly to memory being written in the wrong location) when using the offset `nb` on top of the chunk for a write operation. malloc() takes the number of bytes to allocate as size_t, but the calculation of the global bin index idx is done via malloc_largebin_index() which takes as parameter and calculates internally with unsigned int. This leads, for large allocations, to a truncation of the value and consequently to the idx being wrongly calculated. idx is an index into the bins which are sorted in ascending order of size range of its including chunks (e.g. 8-16, 16-32, 32-64,...). The malloc() algorithm depends on the idx being calculated such that we begin searching only at a bin whose chunks are always large enough to include the memory size to be allocated (nb). If the idx is too small (as can happen due to the described integer overflow), this code will lead to a write to a wrong address (remainder->bk resp. remainder->fd) (lines from malloc.c): 1086 size = chunksize(victim); 1087 1088 /* We know the first chunk in this bin is big enough to use. */ 1089 assert((unsigned long)(size) >= (unsigned long)(nb)); 1108 remainder = chunk_at_offset(victim, nb); 1111 remainder->bk = remainder->fd = unsorted_chunks(av); The chunk victim should normally be from a bin of a range where each chunk is at least of the size nb. Since it's not, its size may be smaller than nb. With assertions enabled the assertion in 1089 would fail. Without assertions we add nb as an offset to the chunk but since the size of the chunk is a lot smaller than nb, this will point to an address somewhere else. Signed-off-by: Marcus Haehnel <marcus.haehnel(a)kernkonzept.com> --- libc/stdlib/malloc-standard/malloc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libc/stdlib/malloc-standard/malloc.c b/libc/stdlib/malloc-standard/malloc.c index cecea87ecf..e51bc6610c 100644 --- a/libc/stdlib/malloc-standard/malloc.c +++ b/libc/stdlib/malloc-standard/malloc.c @@ -29,7 +29,7 @@ __UCLIBC_MUTEX_INIT(__malloc_lock, PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP); struct malloc_state __malloc_state; /* never directly referenced */ /* forward declaration */ -static int __malloc_largebin_index(unsigned int sz); +static int __malloc_largebin_index(unsigned long sz); #ifdef __UCLIBC_MALLOC_DEBUGGING__ @@ -755,10 +755,10 @@ static void* __malloc_alloc(size_t nb, mstate av) Compute index for size. We expect this to be inlined when compiled with optimization, else not, which works out well. */ -static int __malloc_largebin_index(unsigned int sz) +static int __malloc_largebin_index(unsigned long sz) { - unsigned int x = sz >> SMALLBIN_WIDTH; - unsigned int m; /* bit position of highest set bit of m */ + unsigned long x = sz >> SMALLBIN_WIDTH; + unsigned long m; /* bit position of highest set bit of m */ if (x >= 0x10000) return NBINS-1; @@ -776,7 +776,7 @@ static int __malloc_largebin_index(unsigned int sz) S. Warren Jr's book "Hacker's Delight". */ - unsigned int n = ((x - 0x100) >> 16) & 8; + unsigned long n = ((x - 0x100) >> 16) & 8; x <<= n; m = ((x - 0x1000) >> 16) & 4; n += m; -- 2.47.1

2 1

[PATCH v1] utimes: force to use 64-bit implementation if available and requested (part II)
by Peter Seiderer 25 Jul '25

25 Jul '25

- fix dependency for libc_hidden_def(utimes) statement, fixes (on ARM-64bit): ./include/libc-symbols.h:431:32: error: '__EI_utimes' aliased to undefined symbol '__GI_utimes' 431 | extern __typeof (name) __EI_##name __attribute__((alias (__hidden_asmname1 (,#local)))) \ | ^~~~~ ./include/libc-symbols.h:435:41: note: in expansion of macro '__hidden_ver1' 435 | # define hidden_def(name) __hidden_ver1(__GI_##name, name, name); | ^~~~~~~~~~~~~ ./include/libc-symbols.h:503:32: note: in expansion of macro 'hidden_def' 503 | # define libc_hidden_def(name) hidden_def (name) | ^~~~~~~~~~ libc/sysdeps/linux/common/utimes.c:54:1: note: in expansion of macro 'libc_hidden_def' 54 | libc_hidden_def(utimes) | ^~~~~~~~~~~~~~~ - fix dependency for 64-bit implementation, fixes (on ARM-64bit): .../build/busybox-1.37.0/libbb/copy_file.c:433:(.text.copy_file+0x2b0): undefined reference to `utimes' Fixes: 48591e2a2 ("Provide fixups for riscv32.") Fixes: 5aee86ed3 ("utimes: force to use 64-bit implementation if available and requested") Signed-off-by: Peter Seiderer <ps.report(a)gmx.net> --- libc/sysdeps/linux/common/utimes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libc/sysdeps/linux/common/utimes.c b/libc/sysdeps/linux/common/utimes.c index eb128d352..c471a9b89 100644 --- a/libc/sysdeps/linux/common/utimes.c +++ b/libc/sysdeps/linux/common/utimes.c @@ -9,7 +9,7 @@ #include <sys/syscall.h> #include <sys/time.h> -#if (defined (__NR_utimensat) || defined(__NR_utimensat_time64)) && defined(__UCLIBC_USE_TIME64__) +#if (defined (__NR_utimensat) || defined(__NR_utimensat_time64)) && (!defined __NR_utimes || defined(__UCLIBC_USE_TIME64__)) # include <fcntl.h> # include <stddef.h> int utimes(const char *file, const struct timeval tvp[2]) @@ -50,6 +50,6 @@ int utimes(const char *file, const struct timeval tvp[2]) } #endif -#if defined __NR_utimensat || defined __NR_utimensat_time64 || defined __NR_utimes || defined __NR_utime +#if (((defined __NR_utimensat || defined __NR_utimensat_time64) && (!defined __NR_utimes || defined __UCLIBC_USE_TIME64__))) || defined __NR_utimes || defined __NR_utime libc_hidden_def(utimes) #endif -- 2.50.1

2 1

new release 1.0.54
by Waldemar Brodkorb 25 Jul '25

25 Jul '25

Hi embedded hackers, I made a new release shortly after 1.0.53. 1.0.54 is out now with fixes two regressions. Git shortlog: Marcus Haehnel (3): openpty/forkpty: use const for termios and winsize arguments openpty: Remove code that has been disabled for more than 20 years inet/netdb: fix getnameinfo signature Peter Seiderer (2): utimes: force to use 64-bit implementation if available and requested utimes: force to use 64-bit implementation if available and requested (part II) Thorsten Glaser (1): add getentropy(), fix return value of getrandom() Waldemar Brodkorb (15): getentropy: guard syscall to getrandom frv: fix compile issues mips/mips64: add fenv support from glibc riscv: add fenv support from glibc fix build for coldfire with FPU m68k: add fenv support from glibc or1k: add fenv support from glibc sparc: add fenv support from glibc arc: add support for fenv from glibc sh: add fenv support from glibc csky: add fenv support from glibc arc: add missing files for fenv support bump version for 1.0.53 release fix getentropy() bump version for 1.0.54 release Thanks for testing and using it. Sunshine Waldemar

1 0

About the support of msgctl for time64 in uclibc-ng
by 刘瑜 24 Jul '25

24 Jul '25

Hello, development team of uclibc-ng, We are a company from China called Ingenic, and we have recently observed that msgctl(), shmctl() and semctl() do not fully support time64 in the latest version of uclibc-ng. When time64 is enabled on mips, timestamps of semaphore obtained by msgclt, shmctl and semctl are incorrectly, and semctl will report segmentation fault if RMID operation is used. The timestamp of the semaphore on arm platform is also wrong. These errors seem to be caused by incomplete support for time64. Although struct semid_ds is modified for time64, the positions of its members are inconsistent with those of struct semid64_ds in the kernel, resulting in incorrect semaphore timestamps obtained by semctl. In addition, struct shmid_ds and struct msqid_ds do not seem to support time64. Besides, when semctl removes the semaphore using RMID, the union semun arg is NULL and does not point to the semaphore instance. Accessing members of struct semid_ds will result in a segmentation fault. The attachment is my modification for three functions and structs they required on the mips platform, which can be used as a reference. If you think these three functions do not need to be modified, hope you can write to tell me the reason. Looking forward to your reply ! Best regards, Liu Yu

2 1

[PATCH v1] utimes: force to use 64-bit implementation if available and requested
by Peter Seiderer 20 Jul '25

20 Jul '25

Fixes 64-/32-bit time_t regression on ARM32 (reported for buildroot, see [1] for details). [1] https://gitlab.com/buildroot.org/buildroot/-/issues/128 Fixes: 48591e2a2 ("Provide fixups for riscv32.") Signed-off-by: Peter Seiderer <ps.report(a)gmx.net> --- libc/sysdeps/linux/common/utimes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libc/sysdeps/linux/common/utimes.c b/libc/sysdeps/linux/common/utimes.c index a28594dfd..eb128d352 100644 --- a/libc/sysdeps/linux/common/utimes.c +++ b/libc/sysdeps/linux/common/utimes.c @@ -9,7 +9,7 @@ #include <sys/syscall.h> #include <sys/time.h> -#if (defined (__NR_utimensat) || defined(__NR_utimensat_time64)) && !defined __NR_utimes +#if (defined (__NR_utimensat) || defined(__NR_utimensat_time64)) && defined(__UCLIBC_USE_TIME64__) # include <fcntl.h> # include <stddef.h> int utimes(const char *file, const struct timeval tvp[2]) -- 2.50.1

2 5

utimes 64-/32-bit time_t regression (ARM-32bit)
by Peter Seiderer 19 Jul '25

19 Jul '25

Hello Dmitry, Waldemar, as reported for buildroot ([1]) there is a utimes 64-/32-bit time_t regression (?) for ARM-32bit maybe introduced by commit ([2], at least fixable by partly reverting): 48591e2a2 Provide fixups for riscv32. Regards, Peter [1] https://gitlab.com/buildroot.org/buildroot/-/issues/128 [2] https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/commit/?id=48591e2a259d84…

2 2