devel

devel@uclibc-ng.org

3 participants
1149 discussions

[PATCH] bugfix renameat2 wrong implement.

by Guo Ren

Signed-off-by: Guo Ren <ren_guo(a)c-sky.com> --- libc/sysdeps/linux/common/rename.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libc/sysdeps/linux/common/rename.c b/libc/sysdeps/linux/common/rename.c index 30a4ed7..613ae4e 100644 --- a/libc/sysdeps/linux/common/rename.c +++ b/libc/sysdeps/linux/common/rename.c @@ -20,7 +20,9 @@ int rename(const char *oldpath, const char *newpath) # include <fcntl.h> int rename(const char *oldpath, const char *newpath) {… [View More]

6 years, 6 months

[PATCH] wordexp: Fix the usage of the internal _itoa function

by Segev Finer

The original from glibc received the end of the buffer and worked backwards. Ours needs the beginning of the buffer. Signed-off-by: Segev Finer <segev208(a)gmail.com> --- libc/misc/wordexp/wordexp.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libc/misc/wordexp/wordexp.c b/libc/misc/wordexp/wordexp.c index fb635fe91..285e81e87 100644 --- a/libc/misc/wordexp/wordexp.c +++ b/libc/misc/wordexp/wordexp.c @@ -491,10 +491,10 @@ parse_squote(char **… [View More]word, size_t * word_length, size_t * max_length, #ifdef __WORDEXP_FULL static int eval_expr(char *expr, long int *result); -static char *_itoa(unsigned long long int value, char *buflim) +static char *_itoa(unsigned long long int value, char *buf) { - sprintf(buflim, "%llu", value); - return buflim; + sprintf(buf, "%llu", value); + return buf; } /* Functions to evaluate an arithmetic expression */ @@ -692,7 +692,7 @@ parse_arith(char **word, size_t * word_length, size_t * max_length, result[20] = '\0'; *word = w_addstr(*word, word_length, max_length, - _itoa(convertme, &result[20])); + _itoa(convertme, result)); free(expr); return *word ? 0 : WRDE_NOSPACE; } @@ -717,7 +717,7 @@ parse_arith(char **word, size_t * word_length, size_t * max_length, result[20] = '\0'; *word = w_addstr(*word, word_length, max_length, - _itoa(numresult, &result[20])); + _itoa(numresult, result)); free(expr); return *word ? 0 : WRDE_NOSPACE; } @@ -1313,7 +1313,7 @@ parse_param(char **word, size_t * word_length, size_t * max_length, if (seen_hash) { /* $# expands to the number of positional parameters */ buffer[20] = '\0'; - value = _itoa(__libc_argc - 1, &buffer[20]); + value = _itoa(__libc_argc - 1, buffer); seen_hash = 0; } else { /* Just $ on its own */ @@ -1338,13 +1338,13 @@ parse_param(char **word, size_t * word_length, size_t * max_length, /* Is it `$$'? */ if (*env == '$') { buffer[20] = '\0'; - value = _itoa(getpid(), &buffer[20]); + value = _itoa(getpid(), buffer); } /* Is it `${#*}' or `${#@}'? */ else if ((*env == '*' || *env == '@') && seen_hash) { buffer[20] = '\0'; value = _itoa(__libc_argc > 0 ? __libc_argc - 1 : 0, - &buffer[20]); + buffer); *word = w_addstr(*word, word_length, max_length, value); free(env); free(pattern); @@ -1770,7 +1770,7 @@ parse_param(char **word, size_t * word_length, size_t * max_length, param_length[20] = '\0'; *word = w_addstr(*word, word_length, max_length, _itoa(value ? strlen(value) : 0, - &param_length[20])); + param_length)); if (free_value) { assert(value != NULL); free(value); -- 2.18.0 [View Less]

6 years, 6 months

[PATCH] Fix path to file libtest31.so

by Nikita Sobolev

From: Nikita Sobolev <sobolev(a)synopsys.com> Test failed with error 'Could not open libtest31.so: File not found'. dlopen function is trying to find libtest31.so in the same directory where the test is run. But libtest31.so is lockated in testlib directory. So fix changes the path to library. Signed-off-by: Nikita Sobolev <Nikita.Sobolev(a)synopsys.com> --- test/dlopen/tst-origin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/dlopen/tst-origin.c b/… [View More]

6 years, 7 months

[PATCH] sched_setaffinity: use the same style with glibc's

by Guo Ren

Call getpid() in INTERNAL_SYSCALL will break the argument regs, because gcc couldn't save destoryed regs for system call asm. Ref to glibc, we could just remove all the check code. Signed-off-by: Guo Ren <ren_guo(a)c-sky.com> --- libc/sysdeps/linux/common/sched_setaffinity.c | 34 --------------------------- 1 file changed, 34 deletions(-) diff --git a/libc/sysdeps/linux/common/sched_setaffinity.c b/libc/sysdeps/linux/common/sched_setaffinity.c index 3d513ef..39f6ec8 100644 --- a/libc/… [View More]

6 years, 7 months

[PATCH 00/32] FDPIC ABI for ARM

by Christophe Lyon

Hello, This patch series implements the uClibc-ng contribution of the FDPIC ABI for ARM targets. This ABI enables to run Linux on ARM MMU-less cores and supports shared libraries to reduce the memory footprint. Without MMU, text and data segments relative distances are different from one process to another, hence the need for a dedicated FDPIC register holding the start address of the data segment. One of the side effects is that function pointers require two words to be represented: the … [View More]address of the code, and the data segment start address. These two words are designated as "Function Descriptor", hence the "FD PIC" name. On ARM, the FDPIC register is r9 [1], and the target name is arm-uclinuxfdpiceabi. Note that arm-uclinux exists, but uses another ABI and the BFLAT file format; it does not support code sharing. This work was developed some time ago by STMicroelectronics, and was presented during Linaro Connect SFO15 (September 2015). You can watch the discussion and read the slides [2]. This presentation was related to the toolchain published on github [3], which is based on binutils-2.22, gcc-4.7, uclibc-0.9.33.2, gdb-7.5.1 and qemu-2.3.0, and for which pre-built binaries are available [3]. The ABI itself is described in details in [1]. Our Linux kernel patches have been updated and committed by Nicolas Pitre (Linaro) in July 2017. They are required so that the loader is able to handle this new file type. Indeed, the ELF files are tagged with ELFOSABI_ARM_FDPIC. This new tag has been allocated by ARM, as well as the new relocations involved. The binutils and QEMU patch series have been merged recently. [4][5] The GCC patch series has been submitted and is under discussion. [6] This patch series consists in the original uClibc-based patches, which I have rebased and updated for uClibc-ng. Most of them are strictly related to FDPIC on ARM, while a few others address generic issues. Are the uClibc-ng patches OK for inclusion in master? Thanks, Christophe. [1] https://github.com/mickael-guene/fdpic_doc/blob/master/abi.txt [2] http://connect.linaro.org/resource/sfo15/sfo15-406-arm-fdpic-toolset-kernel… [3] https://github.com/mickael-guene/fdpic_manifest [4] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=f1ac0af… [5] https://git.qemu.org/?p=qemu.git;a=commit;h=e8fa72957419c11984608062c7dcb20… [6] https://gcc.gnu.org/ml/gcc-patches/2018-05/msg01439.html Christophe Lyon (32): [ARM][FDPIC] Allow to select FDPIC ELF for arm architecture [FDPIC] rtld: Do not protect RELRO segments when we don't use an MMU. [ARM][FDPIC] rtld: Add #if defined (__FDPIC__) [ARM][FDPIC] rtld: Add FDPIC code for arm [ARM][FDPIC] rtld: Avoid FUNCDESC relocation on _start [ARM][FDPIC] rtld: Add startup code [ARM] Fix bug in _dl_pread when using pread64 syscall [ARM][FDPIC] Add application startup code for FDPIC [ARM][FDPIC] Add runtime support needed for C++ exceptions [ARM][FDPIC] Allow to generate PIE 'static' binary [ARM][FDPIC] rtld: Add lazy binding support [ARM][FDPIC] TLS: fix relocation computation [ARM][FDPIC] rtld: Compile with -fno-unwind-tables -fno-asynchronous-unwind-tables [ARM][FDPIC] arm/clone.S: Fix threading support [ARM][FDPIC] enable NPTL on TARGET_arm [ARM][FDPIC] rtld: Use ELF_RTYPE_CLASS_DLSYM [FDPIC] rtld: Initialize _dl_error_catch_tsd without FUNCDESC relocation [FDPIC] nptl: disable mprotect usage in stack protection [FDPIC] nptl: Disable fork and atfork on MMU-less systems. [FDPIC] nptl: Do not use madvise [ARM][FDPIC] nptl: Use linker-defined symbol to find start of .tdata section. [FDPIC] nptl: Allow sem_open to work on MMU-less systems [FDPIC] nptl: Add pthread_mutex_getprioceiling and pthread_mutex_setprioceiling support [FDPIC] nptl: Use vfork on MMU-less for system() nptl: Clear TLS area for static binaries. [FDPIC] nptl: Replace sbrk with mmap nptl threads: Fix bug in using a weak variable. Fix htab_delete loop counter isnan: Add isnan weak alias to __isnan mbtowc: Fix non compliant behavior for end of string Fix shm_open posix compliance error code [ARM] rtld: Avoid crash on R_ARM_NONE relocation extra/Configs/Config.in | 2 +- extra/Configs/Config.in.arch | 2 +- include/elf.h | 2 + include/link.h | 6 +- ldso/include/dl-elf.h | 2 +- ldso/include/dl-hash.h | 2 +- ldso/include/dl-string.h | 3 +- ldso/include/dl-syscall.h | 13 +- ldso/include/inline-hashtab.h | 2 +- ldso/ldso/Makefile.in | 2 - ldso/ldso/arm/dl-inlines.h | 1 + ldso/ldso/arm/dl-startup.h | 112 +++++++++++++- ldso/ldso/arm/dl-sysdep.h | 63 ++++++-- ldso/ldso/arm/elfinterp.c | 166 +++++++++++++++++---- ldso/ldso/arm/resolve.S | 23 +++ ldso/ldso/dl-elf.c | 6 +- ldso/ldso/dl-hash.c | 4 +- ldso/ldso/dl-tls.c | 1 + ldso/ldso/fdpic/dl-inlines.h | 2 + ldso/ldso/fdpic/dl-sysdep.h | 2 +- ldso/ldso/ldso.c | 23 ++- libc/misc/elf/dl-iterate-phdr.c | 2 +- libc/misc/internals/__uClibc_main.c | 47 +++++- libc/stdlib/stdlib.c | 6 +- libc/stdlib/system.c | 5 + libc/sysdeps/linux/arm/Makefile.arch | 2 +- libc/sysdeps/linux/arm/bits/elf-fdpic.h | 114 ++++++++++++++ libc/sysdeps/linux/arm/clone.S | 12 ++ libc/sysdeps/linux/arm/crt1.S | 66 ++++++++ libc/sysdeps/linux/arm/crtreloc.c | 144 ++++++++++++++++++ libc/sysdeps/linux/arm/find_exidx.c | 38 +++++ libc/sysdeps/linux/arm/find_got.c | 72 +++++++++ libm/s_isnan.c | 1 + libpthread/nptl/Makefile.in | 1 - libpthread/nptl/allocatestack.c | 6 + libpthread/nptl/linux_fsinfo.h | 5 +- libpthread/nptl/pthread_create.c | 4 + libpthread/nptl/sem_open.c | 8 +- libpthread/nptl/sysdeps/generic/libc-tls.c | 27 +++- libpthread/nptl/sysdeps/unix/sysv/linux/fork.c | 3 + .../sysdeps/unix/sysv/linux/libc_pthread_init.c | 4 + .../nptl/sysdeps/unix/sysv/linux/register-atfork.c | 14 +- .../sysdeps/unix/sysv/linux/unregister-atfork.c | 10 +- librt/shm.c | 3 + 44 files changed, 958 insertions(+), 75 deletions(-) create mode 100644 ldso/ldso/arm/dl-inlines.h create mode 100644 libc/sysdeps/linux/arm/bits/elf-fdpic.h create mode 100644 libc/sysdeps/linux/arm/crtreloc.c create mode 100644 libc/sysdeps/linux/arm/find_got.c -- 2.6.3 [View Less]

6 years, 7 months

[PATCH] uclibcng-testrunner.sh: create /etc/ethers

by Nikita Sobolev

/etc/ethers file is required for running tst-ethers and tst-ethers-line tests. If it does not exist, tests fail. Signed-off-by: Nikita Sobolev <Nikita.Sobolev(a)synopsys.com> --- test/uclibcng-testrunner.sh | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/test/uclibcng-testrunner.sh b/test/uclibcng-testrunner.sh index 4fd1661..4a02458 100644 --- a/test/uclibcng-testrunner.sh +++ b/test/uclibcng-testrunner.sh @@ -17,6 +17,9 @@ # of dealing in the work, even if advised … [View More]

6 years, 7 months

[uclibc-ng-test] Revert "arc: disable deadlocking test"

by Vineet Gupta

This seems to work fine on ARC ! This reverts commit f0567d67075ff7a27ada8ab5bce750fe8a739763. Signed-off-by: Vineet Gupta <vgupta(a)synopsys.com> --- test/nptl/Makefile.in | 5 ----- 1 file changed, 5 deletions(-) diff --git a/test/nptl/Makefile.in b/test/nptl/Makefile.in index 761f52db8366..35859f944911 100644 --- a/test/nptl/Makefile.in +++ b/test/nptl/Makefile.in @@ -1,11 +1,6 @@ # uClibc-ng NPTL tests # Licensed under the LGPL v2.1, see the file COPYING.LIB in this tarball. -#… [View More]

6 years, 7 months

[PATCH 30/32] mbtowc: Fix non compliant behavior for end of string

by Christophe Lyon

Match glibc behavior. * libc/stdlib/stdlib.c (mbtowc): Fix end of string behavior. Signed-off-by: Mickaël Guêné <mickael.guene(a)st.com> Signed-off-by: Christophe Lyon <christophe.lyon(a)st.com> diff --git a/libc/stdlib/stdlib.c b/libc/stdlib/stdlib.c index 075e6e5..f593663 100644 --- a/libc/stdlib/stdlib.c +++ b/libc/stdlib/stdlib.c @@ -895,9 +895,13 @@ int mbtowc(wchar_t *__restrict pwc, register const char *__restrict s, size_t n) return is_stateful(ENCODING); } - if (*… [View More]

6 years, 8 months

statfs call corrupts memory struct statfs too small

by Geoff Levand

Hi, I experienced seg faults due to stack corruption when calling statfs() with an automatic struct statfs variable. It seems there is a mismatch between the struct statfs used by libc and that used by the arm64 kernel. The call to statfs() writes 120 bytes, but struct statfs is only 88 bytes. The attached test program shows this. Building for arm64. libuClibc-1.0.30 kernel: Linux-4.17.3 Comparing these files: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tre…… [View More]

6 years, 8 months

[PATCH v2] ldso/arc: fix LD_DEBUG segv when printing R_ARC_NONE

by Vineet Gupta

Signed-off-by: Vineet Gupta <vgupta(a)synopsys.com> --- v2: Also remove a bogus trailing l in prints --- ldso/ldso/arc/elfinterp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ldso/ldso/arc/elfinterp.c b/ldso/ldso/arc/elfinterp.c index 5a02bc2348da..a30c19bcb832 100644 --- a/ldso/ldso/arc/elfinterp.c +++ b/ldso/ldso/arc/elfinterp.c @@ -64,7 +64,7 @@ _dl_linux_resolver(struct elf_resolve *tpnt, unsigned int plt_pc) if (_dl_debug_bindings) { _dl_dprintf(… [View More]

6 years, 8 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

devel