- devel - example.com

Re: [uclibc-ng-devel] Undefined reference to name_to_handle_at while building eudev
by Waldemar Brodkorb 28 Feb '18

28 Feb '18

Hi, this time it is only relevant to aarch64, as I imported it from glibc without recognizing that I should have removed it. best regards Waldemar > On 28. Feb 2018, at 11:34, Thomas Petazzoni <thomas.petazzoni(a)bootlin.com> wrote: > > Hello, > >> On Sun, 11 Feb 2018 12:07:33 -0800, Alexey Neyman wrote: >> >> I noticed a failure while compiling eudev against uClibc-ng 1.0.28 on >> aarch64: it detected name_to_handle_at being declared in the header but >> then failed to link because it is not implemented in uClibc-ng. >> >> Patch attached. > > A quick heads up on this: it is by far not the first time that I see > uClibc headers having the prototype for a given function, and not the > actual implementation of this function. > > It is confusing, and sometimes causes problems when just an autoconf > compile test is done, and not an autoconf link test. > > Shouldn't this be fixed globally ? > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > http://bootlin.com >

1 0

Undefined reference to name_to_handle_at while building eudev
by Alexey Neyman 14 Feb '18

14 Feb '18

Hi, I noticed a failure while compiling eudev against uClibc-ng 1.0.28 on aarch64: it detected name_to_handle_at being declared in the header but then failed to link because it is not implemented in uClibc-ng. Patch attached. Regards, Alexey.

2 1

[PATCH] csky: bugfix ltp open12 failed.
by Guo Ren 04 Feb '18

04 Feb '18

Signed-off-by: Guo Ren <ren_guo(a)c-sky.com> --- libc/sysdeps/linux/csky/bits/fcntl.h | 55 ++++++++++++++++++++++++++++-------- 1 file changed, 43 insertions(+), 12 deletions(-) diff --git a/libc/sysdeps/linux/csky/bits/fcntl.h b/libc/sysdeps/linux/csky/bits/fcntl.h index feacdad..15c1f52 100644 --- a/libc/sysdeps/linux/csky/bits/fcntl.h +++ b/libc/sysdeps/linux/csky/bits/fcntl.h @@ -2,11 +2,12 @@ # error "Never use <bits/fcntl.h> directly; include <fcntl.h> instead." #endif - #include <sys/types.h> #ifdef __USE_GNU # include <bits/uio.h> #endif + + /* open/fcntl - O_SYNC is only implemented on blocks devices and on files located on an ext2 file system */ #define O_ACCMODE 0003 @@ -24,12 +25,16 @@ #define O_FSYNC O_SYNC #define O_ASYNC 020000 -#ifdef __USE_GNU +#ifdef __USE_XOPEN2K8 # define O_DIRECTORY 040000 /* Must be a directory. */ # define O_NOFOLLOW 0100000 /* Do not follow links. */ +# define O_CLOEXEC 02000000 /* Set close_on_exec. */ +#endif + +#ifdef __USE_GNU # define O_DIRECT 0200000 /* Direct disk access. */ -# define O_STREAMING 04000000/* streaming access */ -# define O_CLOEXEC 02000000 /* set close_on_exec */ +# define O_NOATIME 01000000 /* Do not set atime. */ +# define O_PATH 010000000 /* Resolve pathname but do not open file. */ #endif /* For now Linux has synchronisity options for data and read operations. @@ -63,7 +68,7 @@ #define F_SETLK64 13 /* Set record locking info (non-blocking). */ #define F_SETLKW64 14 /* Set record locking info (blocking). */ -#if defined __USE_BSD || defined __USE_XOPEN2K +#if defined __USE_BSD || defined __USE_UNIX98 # define F_SETOWN 8 /* Get owner of socket (receiver of SIGIO). */ # define F_GETOWN 9 /* Set owner of socket (receiver of SIGIO). */ #endif @@ -77,9 +82,13 @@ # define F_SETLEASE 1024 /* Set a lease. */ # define F_GETLEASE 1025 /* Enquire what lease is active. */ # define F_NOTIFY 1026 /* Request notfications on a directory. */ +# define F_DUPFD_CLOEXEC 1030 /* Duplicate file descriptor with + close-on-exit set on new fd. */ +# define F_SETPIPE_SZ 1031 /* Set pipe page size array. */ +# define F_GETPIPE_SZ 1032 /* Get pipe page size array. */ #endif -/* For F_[GET|SET]FL. */ +/* For F_[GET|SET]FD. */ #define FD_CLOEXEC 1 /* actually anything with low bit set goes */ /* For posix fcntl() and `l_type' field of a `struct flock' for lockf(). */ @@ -163,6 +172,28 @@ struct flock64 # define POSIX_FADV_NOREUSE 5 /* Data will be accessed once. */ #endif + +#if defined __USE_GNU && defined __UCLIBC_LINUX_SPECIFIC__ +/* Flags for SYNC_FILE_RANGE. */ +# define SYNC_FILE_RANGE_WAIT_BEFORE 1 /* Wait upon writeout of all pages + in the range before performing the + write. */ +# define SYNC_FILE_RANGE_WRITE 2 /* Initiate writeout of all those + dirty pages in the range which are + not presently under writeback. */ +# define SYNC_FILE_RANGE_WAIT_AFTER 4 /* Wait upon writeout of all pages in + the range after performing the + write. */ + +/* Flags for SPLICE and VMSPLICE. */ +# define SPLICE_F_MOVE 1 /* Move pages instead of copying. */ +# define SPLICE_F_NONBLOCK 2 /* Don't block on the pipe splicing + (but we may still block on the fd + we splice from/to). */ +# define SPLICE_F_MORE 4 /* Expect more data. */ +# define SPLICE_F_GIFT 8 /* Pages passed in are a gift. */ +#endif + __BEGIN_DECLS #if defined __USE_GNU && defined __UCLIBC_LINUX_SPECIFIC__ @@ -171,23 +202,23 @@ __BEGIN_DECLS extern ssize_t readahead (int __fd, __off64_t __offset, size_t __count) __THROW; - /* Selective file content synch'ing. */ extern int sync_file_range (int __fd, __off64_t __from, __off64_t __to, - unsigned int __flags); + unsigned int __flags); /* Splice address range into a pipe. */ extern ssize_t vmsplice (int __fdout, const struct iovec *__iov, - size_t __count, unsigned int __flags); + size_t __count, unsigned int __flags); /* Splice two files together. */ extern ssize_t splice (int __fdin, __off64_t *__offin, int __fdout, - __off64_t *__offout, size_t __len, - unsigned int __flags); + __off64_t *__offout, size_t __len, + unsigned int __flags); /* In-kernel implementation of tee for pipe buffers. */ extern ssize_t tee (int __fdin, int __fdout, size_t __len, - unsigned int __flags); + unsigned int __flags); #endif __END_DECLS + -- 2.7.4

2 1

[PATCH 1/1] aarch64/sys/ucontext.h: include bits/sigcontext.h
by Bernd Kuhls 04 Feb '18

04 Feb '18

Fixes a buildroot build error with ffmpeg In file included from /home/bernd/buildroot/output/host/aarch64-buildroot-linux-uclibc/sysroot/usr/include/signal.h:329:0, from fftools/ffmpeg.h:26, from fftools/ffmpeg_opt.c:23: /home/bernd/buildroot/output/host/aarch64-buildroot-linux-uclibc/sysroot/usr/include/sys/ucontext.h:52:16: error: field 'uc_mcontext' has incomplete type mcontext_t uc_mcontext; ^~~~~~~~~~~ using this defconfig: BR2_aarch64=y BR2_PACKAGE_FFMPEG=y sys/ucontext.h for other archs already include bits/sigcontext.h, on aarch64 this is needed as well. Signed-off-by: Bernd Kuhls <bernd.kuhls(a)t-online.de> --- libc/sysdeps/linux/aarch64/sys/ucontext.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libc/sysdeps/linux/aarch64/sys/ucontext.h b/libc/sysdeps/linux/aarch64/sys/ucontext.h index d17458896..dc7303b54 100644 --- a/libc/sysdeps/linux/aarch64/sys/ucontext.h +++ b/libc/sysdeps/linux/aarch64/sys/ucontext.h @@ -26,6 +26,10 @@ #include <sys/procfs.h> +/* We need the signal context definitions even if they are not used + included in <signal.h>. */ +#include <bits/sigcontext.h> + typedef elf_greg_t greg_t; /* Container for all general registers. */ -- 2.11.0

3 3

mman.h patch
by Waldemar Brodkorb 02 Feb '18

02 Feb '18

Hi, I would like to push attached patch next week. Any veto? best regards Waldemar

2 2

[PATCH] xtensa: fix R_XTENSA_TLSDESC_ARG handling in _dl_do_reloc
by Max Filippov 21 Jan '18

21 Jan '18

R_XTENSA_TLSDESC_ARG is a true RELA relocation, the addend is in the relocation record itself, not in place. Signed-off-by: Max Filippov <jcmvbkbc(a)gmail.com> --- ldso/ldso/xtensa/elfinterp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ldso/ldso/xtensa/elfinterp.c b/ldso/ldso/xtensa/elfinterp.c index 4c83ab65e668..e38a02666477 100644 --- a/ldso/ldso/xtensa/elfinterp.c +++ b/ldso/ldso/xtensa/elfinterp.c @@ -244,10 +244,11 @@ _dl_do_reloc (struct elf_resolve *tpnt, struct r_scope_elem *scope, if (!TRY_STATIC_TLS ((struct link_map *) tls_tpnt)) *reloc_addr = (ElfW(Addr)) _dl_make_tlsdesc_dynamic((struct link_map *) tls_tpnt, - symbol_addr + *reloc_addr); + symbol_addr + rpnt->r_addend); else #endif - *reloc_addr += symbol_addr + tls_tpnt->l_tls_offset; + *reloc_addr = symbol_addr + rpnt->r_addend + + tls_tpnt->l_tls_offset; break; #endif -- 2.1.4

2 3

[PATCH] xtensa: fix _dl_tlsdesc_dynamic
by Max Filippov 21 Jan '18

21 Jan '18

There are multiple errors in _dl_tlsdesc_dynamic: - the reference C implementation should return pointer to the thread-local variable, not offset from the thread pointer, because the xtensa ABI expects TLSDESC_FN to return pointer to the TLS variable; - addx8 used for indexing into dtv has its second and third registers in wrong order, the index must be multiplied by 8, not the base; - the same addx8 uses wrong base: instead of dtv it adds the offset to the threadptr; - the return value in the fast path is calculated as td->tlsinfo.ti_offset - __builtin_thread_pointer, not what was intended; - both fast and slow paths should not subtract __builtin_thread_pointer from the result. Signed-off-by: Max Filippov <jcmvbkbc(a)gmail.com> --- ldso/ldso/xtensa/dl-tlsdesc.S | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/ldso/ldso/xtensa/dl-tlsdesc.S b/ldso/ldso/xtensa/dl-tlsdesc.S index 6f417f61a98b..426f2180b3c0 100644 --- a/ldso/ldso/xtensa/dl-tlsdesc.S +++ b/ldso/ldso/xtensa/dl-tlsdesc.S @@ -39,7 +39,7 @@ END (_dl_tlsdesc_return) The assembly code that follows is a rendition of the following C code, hand-optimized a little bit. - ptrdiff_t + void * _dl_tlsdesc_dynamic(struct tlsdesc_dynamic_arg *td) { dtv_t *dtv = (dtv_t *)THREAD_DTV(); @@ -47,8 +47,8 @@ END (_dl_tlsdesc_return) && dtv[td->tlsinfo.ti_module].pointer.val != TLS_DTV_UNALLOCATED) return dtv[td->tlsinfo.ti_module].pointer.val - + td->tlsinfo.ti_offset - __builtin_thread_pointer(); - return __tls_get_addr (&td->tlsinfo) - __builtin_thread_pointer(); + + td->tlsinfo.ti_offset; + return __tls_get_addr (&td->tlsinfo); } */ @@ -65,33 +65,30 @@ HIDDEN_ENTRY (_dl_tlsdesc_dynamic) /* && dtv[td->tlsinfo.ti_module].pointer.val != TLS_DTV_UNALLOCATED) */ l32i a6, a2, TLSDESC_MODID - addx8 a6, a3, a6 + addx8 a6, a6, a4 l32i a6, a6, 0 beqi a6, -1, .Lslow /* return dtv[td->tlsinfo.ti_module].pointer.val - + td->tlsinfo.ti_offset - __builtin_thread_pointer(); */ - l32i a6, a2, TLSDESC_MODOFF - sub a2, a6, a3 + + td->tlsinfo.ti_offset; */ + l32i a5, a2, TLSDESC_MODOFF + add a2, a6, a5 abi_ret - /* return __tls_get_addr (&td->tlsinfo) - __builtin_thread_pointer(); */ + /* return __tls_get_addr (&td->tlsinfo); */ .Lslow: #if defined(__XTENSA_WINDOWED_ABI__) mov a6, a2 movi a4, __tls_get_addr callx4 a4 - sub a2, a6, a3 + mov a2, a6 retw #elif defined(__XTENSA_CALL0_ABI__) addi a1, a1, -16 s32i a0, a1, 0 - s32i a3, a1, 4 movi a0, __tls_get_addr callx0 a0 - l32i a3, a1, 4 l32i a0, a1, 0 - sub a2, a2, a3 addi a1, a1, 16 ret #else -- 2.1.4

2 1

[PATCH 0/4] Use varargs for common syscall() implementation
by Stafford Horne 15 Jan '18

15 Jan '18

Hello, This is a followup to the ("f764bcffe" or1k: syscall: Pass arguments on the stack) patch which fixes the issue where the definition of syscall() in unistd.h and the common implementation in uclibc-ng don't match. This series allows the implementation to match the definition and then goes on to remove generic implementations used by or1k, nds32 and arc. -Stafford Stafford Horne (4): syscall: Make common implementation match unistd.h or1k: Use new common syscall() implementation nds32: Use new common syscall() implementation arc: Use new common syscall() implementation libc/sysdeps/linux/arc/Makefile.arch | 2 +- libc/sysdeps/linux/arc/syscall.c | 17 ----------------- libc/sysdeps/linux/common/syscall.c | 18 +++++++++++++++++- libc/sysdeps/linux/nds32/Makefile.arch | 4 ++-- libc/sysdeps/linux/nds32/syscall.c | 28 ---------------------------- libc/sysdeps/linux/or1k/Makefile.arch | 2 +- libc/sysdeps/linux/or1k/syscall.c | 32 -------------------------------- 7 files changed, 21 insertions(+), 82 deletions(-) delete mode 100644 libc/sysdeps/linux/arc/syscall.c delete mode 100644 libc/sysdeps/linux/nds32/syscall.c delete mode 100644 libc/sysdeps/linux/or1k/syscall.c -- 2.13.6

3 9

[PATCH v2] xtensa: fix strcmp
by Max Filippov 15 Jan '18

15 Jan '18

Loops with 'loop forever' annotation inside strcmp are actually meant to loop forever. Falling through the end of the first loop may result in equal strings being compared unequal, e.g.: #include <string.h> int main(void) { char a[4096] __attribute__((aligned(4))); char b[4096] __attribute__((aligned(4))); memset(a, ' ', 258 * 8); memset(b, ' ', 258 * 8); a[255 * 8] = 0; a[256 * 8] = 'a'; b[255 * 8] = 0; b[256 * 8] = 'b'; return !(strcmp(a, b) == 0); } Falling through the end of the second loop may result in unequal strings being compared as equal, e.g.: #include <string.h> int main(void) { char a[4096] __attribute__((aligned(4))); char b[4096] __attribute__((aligned(4))); memset(a, ' ', 514 * 6); memset(b, ' ', 514 * 6); a[514 * 6 + 0] = 'a'; a[514 * 6 + 1] = 0; b[514 * 6 + 0] = 'b'; b[514 * 6 + 1] = 0; return !(strcmp(a, b) != 0); } Use 0 as a loop counter to make 2^32 - 1 iterations which is enough to cover all addressable memory. While at it drop useless nop at the end of the first loop and use a11 for all loop counters. Signed-off-by: Max Filippov <jcmvbkbc(a)gmail.com> --- Changes v1->v2: - wrong test case for the second loop, fixed. libc/string/xtensa/strcmp.S | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/libc/string/xtensa/strcmp.S b/libc/string/xtensa/strcmp.S index 2dce590dbd42..a16da5da2e92 100644 --- a/libc/string/xtensa/strcmp.S +++ b/libc/string/xtensa/strcmp.S @@ -92,8 +92,8 @@ ENTRY (strcmp) /* (2 mod 4) alignment for loop instruction */ .Lunaligned: #if XCHAL_HAVE_LOOPS - _movi.n a8, 0 /* set up for the maximum loop count */ - loop a8, .Lretdiff /* loop forever (almost anyway) */ + movi a11, 0 /* set up for the maximum loop count */ + loop a11, .Lretdiff /* loop forever (almost anyway) */ #endif .Lnextbyte: l8ui a8, a2, 0 @@ -131,11 +131,10 @@ ENTRY (strcmp) #if XCHAL_HAVE_LOOPS .Laligned: .begin no-transform + movi a11, 0 l32r a4, .Lmask0 /* mask for byte 0 */ l32r a7, .Lmask4 - /* Loop forever. (a4 is more than than the maximum number - of iterations) */ - loop a4, .Laligned_done + loop a11, .Laligned_done /* Loop forever. */ /* First unrolled loop body. */ l32i a8, a2, 0 /* get word from s1 */ @@ -156,8 +155,6 @@ ENTRY (strcmp) addi a2, a2, 8 /* advance s1 pointer */ addi a3, a3, 8 /* advance s2 pointer */ .Laligned_done: - or a1, a1, a1 /* nop */ - .Lprobeq2: /* Adjust pointers to account for the loop unrolling. */ addi a2, a2, 4 @@ -198,7 +195,7 @@ ENTRY (strcmp) #if XCHAL_HAVE_LOOPS /* align (1 mod 4) */ - loop a4, .Leq /* loop forever (a4 is bigger than max iters) */ + loop a11, .Leq /* loop forever */ .end no-transform l32i a8, a2, 0 /* get word from s1 */ -- 2.1.4

2 1

[PATCH] libpthread/nptl: bugfix malloc segfault in race conditions.
by Guo Ren 15 Jan '18

15 Jan '18

In libc/sysdeps/linux/common/bits/uClibc_pthread.h: extern void weak_function _pthread_cleanup_push_defer(...) This *weak_function* declaration will cause nptl/cleanup_defer_compat.c: strong_alias (...) !!!FAIL!!!, because it include pthreadP.h->pthread.h ->uClibc_pthread.h That means: Readelf -s libpthread/nptl/cleanup_defer_compat.o you will get: 18: 00000000 198 FUNC WEAK DEFAULT 1 _pthread_cleanup_push_def Readelf -s libc/misc/internals/__uClibc_main.o you will also get: 32: 00000038 58 FUNC WEAK DEFAULT 1 _pthread_cleanup_push_def Final: gcc malloc_pthread_test.c -lpthread The libc/stdlib/malloc-standard/malloc.c:839 (__MALLOC_LOCK-> _pthread_cleanup_push_def) will use the one in __uClibc_main.o !!!not in cleanup_defer_compat.o!!!, becasue two cleanup_defer_compat in libc.a with the same weak declarations and the __uClibc_main.o is close to front. ==== All of malloc/free will failed in muti-threads' race conditions probabilistic. As it happens, uClibc-0.9.33.2 is OK, Becasue: It's seperated in libpthread.a and libc.a, and the libc.a is the last lib for ld internal-cmd, and malloc will get right cleanup_defer_compat from libpthread.a. This BUG is from 2016-09-24 to now: >>> commit 29ff9055c80efe77a7130767a9fcb3ab8c67e8ce Author: Waldemar Brodkorb <wbx(a)uclibc-ng.org> Date: Sat Sep 24 02:55:31 2016 +0200 use a single libc and deduplicate threading code Similar to musl libc a single libc has many benefits and solves some open issues with uClibc-ng. - no pthread_mutex_* weak symbols exported anymore - applications no longer failing to link when either -lrt or -lpthread are missing for dynamic and static linking mode - smaller C library - slightly better runtime performance <<< Perharps we need carefully check all of the impact about that commit. Signed-off-by: Guo Ren <ren_guo(a)c-sky.com> --- libpthread/nptl/sysdeps/pthread/pthread.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libpthread/nptl/sysdeps/pthread/pthread.h b/libpthread/nptl/sysdeps/pthread/pthread.h index b2897b3..1fba7fc 100644 --- a/libpthread/nptl/sysdeps/pthread/pthread.h +++ b/libpthread/nptl/sysdeps/pthread/pthread.h @@ -29,7 +29,7 @@ #include <bits/pthreadtypes.h> #include <bits/setjmp.h> #include <bits/wordsize.h> -#if defined _LIBC && ( defined IS_IN_libc || defined NOT_IN_libc ) +#if defined _LIBC && ( defined IS_IN_libc || !defined NOT_IN_libc ) #include <bits/uClibc_pthread.h> #endif -- 2.7.4

2 1