devel

devel@uclibc-ng.org

1164 discussions

[PATCH 0/2] [v3] ldso: fix dlsym hang when reloading DSOs
by Leonid Lisovskiy 27 Jun '16

27 Jun '16

Hi, Third version of fix for dlsym hang when reloading DSOs. Thx, -Leonid Leonid Lisovskiy (2): ldso: Consistently set & use DL_OPENED flag in both ld.so and libdl [v3] ldso: fix dlsym hang when reloading DSOs ldso/include/dl-hash.h | 2 +- ldso/ldso/dl-elf.c | 3 +++ ldso/ldso/ldso.c | 8 ++++--- ldso/libdl/libdl.c | 8 +++---- test/dlopen/Makefile.in | 4 +++- test/dlopen/nodelete1.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 74 insertions(+), 10 deletions(-) create mode 100644 test/dlopen/nodelete1.c -- 1.8.5.6

3 10

uClibc-ng and uClibc memset bug, ARM
by Lucian Cojocar 26 Jun '16

26 Jun '16

Hi all, in libc/string/arm/memset.S[0]. If the code is compiled with #undef __thumb2__ and with #undef THUMB1_ONLY (this seems to be case for Tomato[1] at least and for buildroot) then the code looks like this[2]: """ memset: mov a4, a1 cmp a3, $8 @ at least 8 bytes to do? blt 2f orr a2, a2, a2, lsl $8 orr a2, a2, a2, lsl $16 ... 2: movs a3, a3 @ anything left? IT(t, eq) BXC(eq, lr) @ nope rsb a3, a3, $7 add pc, pc, a3, lsl $2 <--- a3 can be larger than $7 here mov r0, r0 strb a2, [a4], $1 strb a2, [a4], $1 ... """" The problem is that the 'BLT' instruction checks for *signed* values. So if a3, length parameter of memset, is negative, then value added to the PC will be large. In short, an attacker gains control of PC through the len parameter of memset. The attack is a bit unrealistic, as it requires that the application that uses uClibc allows a user to control a memory chunk larger than 2GB. I only tested this on qemu-system-arm[3]. The code was just calling memset(buf, 0xaa, 0xffff0000), memset, in this example[3] is @0x1003c. This bug is similar to CVE-2011-2702[4, 5]. Probably we should notify oss-security and get a CVE for this as the impact is unknown. Thanks, Lucian [0]https://github.com/wbx-github/uclibc-ng/blob/master/libc/string/arm/memse… [1]http://tomato.groov.pl/download/K26ARM/132/tomato-R7000-ARM--132-AIO-64K.zip [2]disas.S (attached) [3]qemu.log (attached) [4]http://www.cvedetails.com/cve/CVE-2011-2702/ [5]http://old.sebug.net/paper/Exploits-Archives/2012-exploits/1208-exploits/…

4 10

static linking ppc
by Waldemar Brodkorb 26 Jun '16

26 Jun '16

Hi Leonid, you recently fixed a bug somehow related to static linking stuff. Do you have an idea why compiling for PowerPC fails like this when using static linking: /home/wbx/ppc-static/toolchain_qemu-ppc-macppc_uclibc-ng_hard/usr/bin/ppc-openadk-linux-uclibc-gcc -Wl,-EB -Wl,-z,now -Wl,-static -static-libgcc -Wl,-rpath,/home/wbx/ppc-static/toolchain_build_qemu-ppc-macppc_uclibc-ng_hard/w-uClibc-ng-1.0.15-1/uClibc-ng-1.0.15/test/argp -L/home/wbx/ppc-static/target_qemu-ppc-macppc_uclibc-ng_hard/lib -L/home/wbx/ppc-static/target_qemu-ppc-macppc_uclibc-ng_hard/usr/lib -Wl,-O1 -Wl,-rpath -Wl,/usr/lib -Wl,-rpath-link -Wl,/home/wbx/ppc-static/target_qemu-ppc-macppc_uclibc-ng_hard/usr/lib -static bug-argp1.o -o bug-argp1 -luargp /home/wbx/ppc-static/target_qemu-ppc-macppc_uclibc-ng_hard/usr/lib/libc.a(sigsetops.os): In function `__GI___sigismember': sigsetops.c:(.text+0x0): multiple definition of `__sigismember' /home/wbx/ppc-static/target_qemu-ppc-macppc_uclibc-ng_hard/usr/lib/libuargp.a(argp-xinl.os):argp-xinl.c:(.text+0x0): first defined here /home/wbx/ppc-static/target_qemu-ppc-macppc_uclibc-ng_hard/usr/lib/libc.a(sigsetops.os): In function `__GI___sigaddset': sigsetops.c:(.text+0x28): multiple definition of `__sigaddset' /home/wbx/ppc-static/target_qemu-ppc-macppc_uclibc-ng_hard/usr/lib/libuargp.a(argp-xinl.os):argp-xinl.c:(.text+0x28): first defined here /home/wbx/ppc-static/target_qemu-ppc-macppc_uclibc-ng_hard/usr/lib/libc.a(sigsetops.os): In function `__GI___sigdelset': sigsetops.c:(.text+0x4c): multiple definition of `__sigdelset' /home/wbx/ppc-static/target_qemu-ppc-macppc_uclibc-ng_hard/usr/lib/libuargp.a(argp-xinl.os):argp-xinl.c:(.text+0x4c): first defined here collect2: error: ld returned 1 exit status make[8]: *** [bug-argp1] Error 1 make[7]: *** [_dircompile_argp] Error 2 make[6]: *** [test_compile] Error 2 make[5]: *** [/home/wbx/ppc-static/toolchain_build_qemu-ppc-macppc_uclibc-ng_hard/w-uClibc-ng-1.0.15-1/uClibc-ng-1.0.15/.installed] Error 2 make[4]: *** [uclibc-ng-install] Error 2 make[3]: *** [toolchain/final] Error 2 make[2]: *** [world] Error 2 ARM and MIPS works fine. best regards Waldemar

3 10

[PATCH] ARC: support shared crt1
by Vineet Gupta 26 Jun '16

26 Jun '16

Signed-off-by: Vineet Gupta <vgupta(a)synopsys.com> --- libc/sysdeps/linux/arc/crt1.S | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libc/sysdeps/linux/arc/crt1.S b/libc/sysdeps/linux/arc/crt1.S index 95c41f888850..e38c8e81b2c0 100644 --- a/libc/sysdeps/linux/arc/crt1.S +++ b/libc/sysdeps/linux/arc/crt1.S @@ -41,11 +41,15 @@ __start: mov_s r5, r0 ; rltd_fini add_s r2, sp, 4 ; argv - +#ifdef L_Scrt1 + add r0, pcl, @main@pcl + add r3, pcl, @_init@pcl + add r4, pcl, @_fini@pcl +#else mov_s r0, main mov_s r3, _init mov r4, _fini - +#endif and sp, sp, -8 mov r6, sp -- 2.5.0

3 7

[PATCH] test: inet: Fix warning messages
by Eugeniy Paltsev 26 Jun '16

26 Jun '16

This patch is to address a proposal by Waldemar in this thread: http://mailman.uclibc-ng.org/pipermail/devel/2016-June/001006.html tst-ethers-line and tst-ethers require /etc/ethers to exist, otherwise user should create it manually. Add this info to warning message. Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev(a)synopsys.com> --- test/inet/tst-ethers-line.c | 5 +++-- test/inet/tst-ethers.c | 6 +++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/test/inet/tst-ethers-line.c b/test/inet/tst-ethers-line.c index 19cf2fb..182faf0 100644 --- a/test/inet/tst-ethers-line.c +++ b/test/inet/tst-ethers-line.c @@ -14,7 +14,8 @@ #define ETHER_LINE_LEN 256 /* This test requires /etc/ethers to exist - * and to have nonzero length + * and to have nonzero length. You should create it manually, + * if it doesn't exist. */ int main(void) @@ -26,7 +27,7 @@ int main(void) struct stat statb; if ((fd = open(ETHER_FILE_NAME, O_RDONLY)) == -1) { - perror ("Cannot open file"); + perror ("Cannot open file /etc/ethers"); exit(1); } diff --git a/test/inet/tst-ethers.c b/test/inet/tst-ethers.c index 6b6e10c..f12813a 100644 --- a/test/inet/tst-ethers.c +++ b/test/inet/tst-ethers.c @@ -6,6 +6,8 @@ /* This test requires /etc/ethers to exist * and to have host "teeth". For example: * 00:11:22:33:44:55 teeth + * You should create /etc/ethers file with + * host "teeth" manually, if it doesn't exist. */ int main(void) @@ -15,8 +17,10 @@ int main(void) int i; int res = ether_hostton("teeth", &addr); - if (res) + if (res) { + printf("Either /etc/ethers is missing or it has incorrect contents\n"); return 1; + } for (i = 0; i < 6; i++) { printf("%02x", addr.ether_addr_octet[i]); -- 2.5.5

2 1

[PATCH] inet/getaddrinfo: fix AF_V4MAPPED behavior for non IPv6 host resolution
by Wenzel, Alexander 26 Jun '16

26 Jun '16

When trying to resolve a hostname by getaddrinfo() using some specific settings, it will always return -EAI_NONAME (Name or service not known). To reproduce this behavior, you need to request an IPv6 address with the additional AF_V4MAPPED flag set from an non IPv6 capable hostname. If you choose a IPv4/IPv6 capable hostname like google.com, everything works fine. This patch is more or less a port [1][2] from the glibc and their behavior for the AF_V4MAPPED flag. To test the bug you can use the following snippet. ---- 8< ---- int ret; struct addrinfo* result; struct addrinfo hints; memset(&hints, 0, sizeof(struct addrinfo)); hints.ai_family = AF_INET6; hints.ai_flags = AI_V4MAPPED; ret = getaddrinfo("test.com", NULL, &hints, &result); printf("getaddrinfo(): %i", ret); ---- 8< ---- [1] https://sourceware.org/git/?p=glibc.git;a=commit;f=sysdeps/posix/getaddrinf… [2] https://sourceware.org/git/?p=glibc.git;a=commit;f=sysdeps/posix/getaddrinf… Signed-off-by: Alexander Wenzel <alexander.wenzel(a)qsc.de> --- libc/inet/getaddrinfo.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/libc/inet/getaddrinfo.c b/libc/inet/getaddrinfo.c index 7ae32be..a9000ae 100644 --- a/libc/inet/getaddrinfo.c +++ b/libc/inet/getaddrinfo.c @@ -391,6 +391,9 @@ static uint8_t __gai_precedence = 0; /* =1 - IPv6, IPv4 memcpy((*pat)->addr, h->h_addr_list[i], sizeof(_type)); \ pat = &((*pat)->next); \ } \ + if (_family == AF_INET6 && i > 0) { \ + got_ipv6 = true; \ + } \ } \ } @@ -404,6 +407,7 @@ gaih_inet(const char *name, const struct gaih_service *service, struct gaih_servtuple *st; struct gaih_addrtuple *at; int rc; + bool got_ipv6 = false; int v4mapped = req->ai_family == PF_INET6 && (req->ai_flags & AI_V4MAPPED); unsigned seen = 0; if (req->ai_flags & AI_ADDRCONFIG) { @@ -586,7 +590,7 @@ gaih_inet(const char *name, const struct gaih_service *service, #endif if (req->ai_family == AF_INET || (!v4mapped && req->ai_family == AF_UNSPEC) - || (v4mapped && (no_inet6_data != 0 || (req->ai_flags & AI_ALL))) + || (v4mapped && (!got_ipv6 || (req->ai_flags & AI_ALL))) ) { if (!(req->ai_flags & AI_ADDRCONFIG) || (seen & SEEN_IPV4)) gethosts(AF_INET, struct in_addr); @@ -705,6 +709,14 @@ gaih_inet(const char *name, const struct gaih_service *service, if (at2->family == AF_INET6 || v4mapped) { family = AF_INET6; socklen = sizeof(struct sockaddr_in6); + + /* If we looked up IPv4 mapped address discard them here if + the caller isn't interested in all address and we have + found at least one IPv6 address. */ + if (got_ipv6 + && (req->ai_flags & (AI_V4MAPPED|AI_ALL)) == AI_V4MAPPED + && IN6_IS_ADDR_V4MAPPED (at2->addr)) + goto ignore; } #endif #if defined __UCLIBC_HAS_IPV4__ && defined __UCLIBC_HAS_IPV6__ @@ -781,7 +793,7 @@ gaih_inet(const char *name, const struct gaih_service *service, (*pai)->ai_next = NULL; pai = &((*pai)->ai_next); } - +ignore: at2 = at2->next; } } -- 2.1.4

2 1

[PATCH v2] libs: install backward compatibility symlinks
by Alexey Brodkin 26 Jun '16

26 Jun '16

Simplify the switch from uClibc to uClibc-ng. Apps already built against uClibc-0.9.x.y require .so.0 libs to present on target which in case of current uClibc-ng is not the case and those apps could not be run. This change creates symlinks from .so.1 to .so.0 for most of other libs in the same way as it was done by 23e96d89b6ab "ldso: install backward compatibility symlink by default" Signed-off-by: Alexey Brodkin <abrodkin(a)synopsys.com> Cc: Waldemar Brodkorb <wbx(a)uclibc-ng.org> Cc: Vineet Gupta <vgupta(a)synopsys.com> Cc: Anton Kolesov <akolesov(a)synopsys.com> --- Changes v1 -> v2: * Fixed title from "libc" to generic "libs" * Added missing comment about compatibility in libcrypt ldso/libdl/Makefile.in | 2 ++ libc/Makefile.in | 4 ++++ libcrypt/Makefile.in | 4 ++++ libintl/Makefile.in | 4 ++++ libm/Makefile.in | 4 ++++ libnsl/Makefile.in | 2 ++ libpthread/linuxthreads/Makefile.in | 2 ++ libpthread/nptl/Makefile.in | 2 ++ libresolv/Makefile.in | 2 ++ librt/Makefile.in | 2 ++ libubacktrace/Makefile.in | 4 ++++ libutil/Makefile.in | 4 ++++ 12 files changed, 36 insertions(+) diff --git a/ldso/libdl/Makefile.in b/ldso/libdl/Makefile.in index fe1eb9d..1ba8770 100644 --- a/ldso/libdl/Makefile.in +++ b/ldso/libdl/Makefile.in @@ -48,6 +48,8 @@ objclean-y += CLEAN_ldso/libdl $(top_builddir)lib/libdl.so: $(libdl_OUT)/libdl_so.a $(libc.depend) $(call link.so,$(libdl_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call link.so,$(libdl_FULL_NAME),0) $(libdl_OUT)/libdl_so.a: $(libdl-so-y) $(Q)$(RM) $@ diff --git a/libc/Makefile.in b/libc/Makefile.in index 2abc77d..8ed8a75 100644 --- a/libc/Makefile.in +++ b/libc/Makefile.in @@ -60,9 +60,13 @@ OUTPUT_FORMAT = $(CC) $(CFLAGS) -Wl,--verbose 2>&1 | $(SED) -n '/OUTPUT_FORMAT/, ifeq ($(DOMULTI),n) $(libc.depend): $(libc_OUT)/libc_so.a $(LIBS-libc.so) $(call link.so,$(libc_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call link.so,$(libc_FULL_NAME),0) else $(libc.depend): $(libc_OUT)/libc.oS $(libc-nomulti-y:.o=.oS) | $(LIBS-libc.so) $(call linkm.so,$(libc_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call linkm.so,$(libc_FULL_NAME),0) endif $(Q)$(RM) $@ $(Q)cat $(top_srcdir)extra/scripts/format.lds > $@.tmp diff --git a/libcrypt/Makefile.in b/libcrypt/Makefile.in index 94753f4..94feacb 100644 --- a/libcrypt/Makefile.in +++ b/libcrypt/Makefile.in @@ -46,9 +46,13 @@ else $(top_builddir)lib/libcrypt.so: $(libcrypt_OUT)/libcrypt_so.a $(libc.depend) endif $(call link.so,$(libcrypt_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call link.so,$(libcrypt_FULL_NAME),0) else $(top_builddir)lib/libcrypt.so: $(libcrypt_OUT)/libcrypt.oS | $(libc.depend) $(call linkm.so,$(libcrypt_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call linkm.so,$(libcrypt_FULL_NAME),0) endif $(libcrypt_OUT)/libcrypt_so.a: $(libcrypt-so-y) diff --git a/libintl/Makefile.in b/libintl/Makefile.in index 22ae70c..39b39a5 100644 --- a/libintl/Makefile.in +++ b/libintl/Makefile.in @@ -48,9 +48,13 @@ else $(top_builddir)lib/libintl.so: $(libintl_OUT)/libintl_so.a $(libc.depend) endif $(call link.so,$(libintl_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call link.so,$(libintl_FULL_NAME),0) else $(top_builddir)lib/libintl.so: $(libintl_OUT)/libintl.oS | $(libc.depend) $(call linkm.so,$(libintl_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call linkm.so,$(libintl_FULL_NAME),0) endif $(libintl_OUT)/libintl_so.a: $(libintl-so-y) diff --git a/libm/Makefile.in b/libm/Makefile.in index 835e7bf..2880512 100644 --- a/libm/Makefile.in +++ b/libm/Makefile.in @@ -305,9 +305,13 @@ else $(top_builddir)lib/libm.so: $(libm_OUT)/libm_so.a $(libc.depend) endif $(call link.so,$(libm_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call link.so,$(libm_FULL_NAME),0) else $(top_builddir)lib/libm.so: $(libm_OUT)/libm.oS | $(libc.depend) $(call linkm.so,$(libm_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call linkm.so,$(libm_FULL_NAME),0) endif $(libm_OUT)/libm_so.a: $(libm-so-y) diff --git a/libnsl/Makefile.in b/libnsl/Makefile.in index 333c490..e79268c 100644 --- a/libnsl/Makefile.in +++ b/libnsl/Makefile.in @@ -39,6 +39,8 @@ else $(top_builddir)lib/libnsl.so: $(libnsl_OUT)/libnsl_so.a $(libc.depend) endif $(call link.so,$(libnsl_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call link.so,$(libnsl_FULL_NAME),0) $(libnsl_OUT)/libnsl_so.a: $(libnsl-so-y) $(Q)$(RM) $@ diff --git a/libpthread/linuxthreads/Makefile.in b/libpthread/linuxthreads/Makefile.in index ffa60c7..5b7d559 100644 --- a/libpthread/linuxthreads/Makefile.in +++ b/libpthread/linuxthreads/Makefile.in @@ -69,6 +69,8 @@ lib-so-$(UCLIBC_HAS_THREADS) += $(top_builddir)lib/libpthread.so $(top_builddir)lib/libpthread.so: $(libpthread_OUT)/libpthread_so.a $(libc.depend) $(call link.so,$(libpthread_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call link.so,$(libpthread_FULL_NAME),0) ifeq ($(PTHREADS_DEBUG_SUPPORT),y) $(libpthread_OUT)/libpthread_so.a: STRIP_FLAGS:=$(STRIP_FLAGS:-x=-X --strip-debug) diff --git a/libpthread/nptl/Makefile.in b/libpthread/nptl/Makefile.in index 8261fce..f0d5ad6 100644 --- a/libpthread/nptl/Makefile.in +++ b/libpthread/nptl/Makefile.in @@ -76,6 +76,8 @@ lib-so-$(UCLIBC_HAS_THREADS) += $(top_builddir)lib/libpthread.so $(top_builddir)lib/libpthread.so: $(libpthread_OUT)/libpthread_so.a $(libc.depend) $(libdl.depend) $(top_builddir)lib/libpthread_nonshared.a $(call link.so,$(libpthread_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call link.so,$(libpthread_FULL_NAME),0) $(Q)cat $(top_srcdir)extra/scripts/format.lds > $@.tmp $(Q)echo "GROUP ( $(notdir $(a)).$(ABI_VERSION) libpthread_nonshared.a )" >> $@.tmp $(Q)mv $@.tmp $@ diff --git a/libresolv/Makefile.in b/libresolv/Makefile.in index fa3c341..89ef4f7 100644 --- a/libresolv/Makefile.in +++ b/libresolv/Makefile.in @@ -39,6 +39,8 @@ else $(top_builddir)lib/libresolv.so: $(libresolv_OUT)/libresolv_so.a $(libc.depend) endif $(call link.so,$(libresolv_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call link.so,$(libresolv_FULL_NAME),0) $(libresolv_OUT)/libresolv_so.a: $(libresolv-so-y) $(Q)$(RM) $@ diff --git a/librt/Makefile.in b/librt/Makefile.in index 1536a5c..88f15f9 100644 --- a/librt/Makefile.in +++ b/librt/Makefile.in @@ -73,6 +73,8 @@ else $(top_builddir)lib/librt.so: $(librt_OUT)/librt_so.a $(librt-dep-y) endif $(call link.so,$(librt_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call link.so,$(librt_FULL_NAME),0) $(librt_OUT)/librt_so.a: $(librt-so-y) $(Q)$(RM) $@ diff --git a/libubacktrace/Makefile.in b/libubacktrace/Makefile.in index 311f1e3..587eaf6 100644 --- a/libubacktrace/Makefile.in +++ b/libubacktrace/Makefile.in @@ -62,9 +62,13 @@ objclean-y += CLEAN_libubacktrace ifeq ($(DOMULTI),n) $(top_builddir)lib/libubacktrace.so: $(libubacktrace_OUT)/libubacktrace_so.a $(libdl.depend) $(call link.so,$(libubacktrace_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call link.so,$(libubacktrace_FULL_NAME),0) else $(top_builddir)lib/libubacktrace.so: $(libubacktrace_OUT)/libubacktrace.oS | $(libdl.depend) $(call linkm.so,$(libubacktrace_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call linkm.so,$(libubacktrace_FULL_NAME),0) endif $(libubacktrace_OUT)/libubacktrace_so.a: $(libubacktrace-so-y) diff --git a/libutil/Makefile.in b/libutil/Makefile.in index 98b178e..7759482 100644 --- a/libutil/Makefile.in +++ b/libutil/Makefile.in @@ -55,9 +55,13 @@ else $(top_builddir)lib/libutil.so: $(libutil_OUT)/libutil_so.a $(libc.depend) endif $(call link.so,$(libutil_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call link.so,$(libutil_FULL_NAME),0) else $(top_builddir)lib/libutil.so: $(libutil_OUT)/libutil.oS | $(libc.depend) $(call linkm.so,$(libutil_FULL_NAME),$(ABI_VERSION)) + # link for backward compatibility + $(call linkm.so,$(libutil_FULL_NAME),0) endif $(libutil_OUT)/libutil_so.a: $(libutil-so-y) -- 2.5.5

2 1

[PATCH v2] ARC: remove deprecated -msoft-float from CFLAGS
by Alexey Brodkin 26 Jun '16

26 Jun '16

"-msoft-float" makes no sense for ARC because there's no such thing as "-mhard-float" on ARC. Instead we use our own "-mfpu=XXX" option when a particular floating-point related HW feature is enabled in the ARC core. We used to live with that phony option for quite some time but with migration to newer GCC following warning now appears: -------------------->8----------------- arc-linux-gcc: warning: ‘-msoft-float’ is deprecated cc1: warning: ‘-msoft-float’ is deprecated [enabled by default] -------------------->8----------------- And that warning gets printed for each invocation of gcc with the option in question, which makes compilation output barely readable. So we disable that phony option for ARC now. Signed-off-by: Alexey Brodkin <abrodkin(a)synopsys.com> Cc: Waldemar Brodkorb <wbx(a)uclibc-ng.org> Cc: Vineet Gupta <vgupta(a)synopsys.com> Cc: Anton Kolesov <akolesov(a)synopsys.com> --- Changes v1 -> v2 * Fix stupid spello in architecture name "aarch" -> "arc" Rules.mak | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Rules.mak b/Rules.mak index 207c4ec..3e4e6c0 100644 --- a/Rules.mak +++ b/Rules.mak @@ -303,6 +303,7 @@ ifneq ($(TARGET_ARCH),nios2) ifneq ($(TARGET_ARCH),sh) ifneq ($(TARGET_ARCH),c6x) ifneq ($(TARGET_ARCH),h8300) +ifneq ($(TARGET_ARCH),arc) CPU_CFLAGS-y += -msoft-float endif endif @@ -311,6 +312,7 @@ endif endif endif endif +endif $(eval $(call check-gcc-var,-std=gnu99)) CPU_CFLAGS-y += $(CFLAG_-std=gnu99) -- 2.5.5

2 1

[PATCH] ARC: Implement .note.ABI-tag section in crt1.S
by Anton Kolesov 26 Jun '16

26 Jun '16

Linux Standard Base specifies section .note.ABI-tag that can be considered as a marker for ELF files targeted to Linux systems. See https://refspecs.linuxfoundation.org/LSB_1.2.0/gLSB/noteabitag.html This section, for example, is used by the GDB to identify Linux ELFs as compared to baremetal ELFs that do not have this section. Signed-off-by: Anton Kolesov <Anton.Kolesov(a)synopsys.com> Cc: Vineet Gupta <Vineet.Gupta1(a)synopsys.com> --- libc/sysdeps/linux/arc/crt1.S | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/libc/sysdeps/linux/arc/crt1.S b/libc/sysdeps/linux/arc/crt1.S index 95c41f8..0fe3cf9 100644 --- a/libc/sysdeps/linux/arc/crt1.S +++ b/libc/sysdeps/linux/arc/crt1.S @@ -55,3 +55,18 @@ __start: /* Should never get here.... */ flag 1 .size __start,.-__start + +/* Implement a .note.ABI-tag section that is mandatory for Linux executables + according to LSB. See: + https://refspecs.linuxfoundation.org/LSB_1.2.0/gLSB/noteabitag.html. + Also: libc/sysdeps/linux/avr32/crt1.S. */ +.section ".note.ABI-tag", "a" + .align 4 + .long 1f - 0f /* Name length */ + .long 3f - 2f /* Data length */ + .long 1 /* Note type */ +0: .asciz "GNU" /* Vendor name */ +1: .align 4 +2: .long 0 /* Note data: Linux executable */ + .long 3,9,0 /* Earliest compatible kernel */ +3: .align 4 /* Pad out section */ -- 2.8.1

2 1

[PATCH] inet/resolv: Try search domains first for unqualified names
by Ingo van Lil 26 Jun '16

26 Jun '16

When resolving an unqualified host name, the resolver tries the original name first before appending the domains from the search list. If a TLD with the same name exists, the query will succeed (but yield no A record) and the resolver will return HOST_NOT_FOUND without trying the search domains. This patch changes the lookup order for unqualified host names (without dots) to try the search domains first and the original name last. Signed-off-by: Ingo van Lil <inguin(a)gmx.de> --- libc/inet/resolv.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libc/inet/resolv.c b/libc/inet/resolv.c index e3ad513..d380d44 100644 --- a/libc/inet/resolv.c +++ b/libc/inet/resolv.c @@ -1266,6 +1266,7 @@ int __dns_lookup(const char *name, int local_id = local_id; /* for compiler */ int sdomains = 0; bool ends_with_dot; + bool contains_dot; sockaddr46_t sa; fd = -1; @@ -1277,12 +1278,14 @@ int __dns_lookup(const char *name, if (!packet || !lookup || !name[0]) goto fail; ends_with_dot = (name[name_len - 1] == '.'); + contains_dot = strchr(name, '.') != NULL; /* no strcpy! paranoia, user might change name[] under us */ memcpy(lookup, name, name_len); DPRINTF("Looking up type %d answer for '%s'\n", type, name); retries_left = 0; /* for compiler */ do { + unsigned act_variant; int pos; unsigned reply_timeout; @@ -1306,11 +1309,16 @@ int __dns_lookup(const char *name, sdomains = __searchdomains; } lookup[name_len] = '\0'; - if ((unsigned)variant < sdomains) { + /* For qualified names, act_variant = MAX_UINT, 0, .., sdomains-1 + * => Try original name first, then append search domains + * For names without domain, act_variant = 0, 1, .., sdomains + * => Try search domains first, original name last */ + act_variant = contains_dot ? variant : variant + 1; + if (act_variant < sdomains) { /* lookup is name_len + 1 + MAXLEN_searchdomain + 1 long */ /* __searchdomain[] is not bigger than MAXLEN_searchdomain */ lookup[name_len] = '.'; - strcpy(&lookup[name_len + 1], __searchdomain[variant]); + strcpy(&lookup[name_len + 1], __searchdomain[act_variant]); } /* first time? pick starting server etc */ if (local_ns_num < 0) { -- 2.5.5

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

devel