[uclibc-ng-devel] Re: [PATCH] elf: support ELF binaries in noMMU

Hi Waldemar, On 1/12/23 18:31, Waldemar Brodkorb wrote: > THis breaks static building of target alpha: > > /home/wbx/embedded-test/openadk/toolchain_qemu-alpha_uclibc-ng/usr/bin/alpha-openadk-linux-uclibc-gcc -c libc/misc/auxvt/getauxval.c -o libc/misc/auxvt/getauxval.os -Wall -Wstrict-prototypes -Wstrict-aliasing -Wp > In file included from ./ldso/include/ldso.h:189, > from libc/misc/auxvt/getauxval.c:21: > ./ldso/include/dl-defs.h:76:10: fatal error: dl-sysdep.h: No such file or directory > 76 | #include <dl-sysdep.h> > | ^~~~~~~~~~~~~ > compilation terminated. > gmake[6]: *** [Makerules:372: libc/misc/auxvt/getauxval.os] Error 1 > > I think it is this part of the patch: > diff --git a/ldso/include/dl-defs.h b/ldso/include/dl-defs.h > index daa6685cb..e404f17ec 100644 > --- a/ldso/include/dl-defs.h > +++ b/ldso/include/dl-defs.h > @@ -72,10 +72,8 @@ typedef struct { > #endif > #ifdef _LIBC > -#ifndef __ARCH_HAS_NO_SHARED__ > /* arch specific defines */ > #include <dl-sysdep.h> > -#endif > #ifdef __TARGET_c6x__ > #include <dl-sysdep.h> > #endif > > Any idea? Yes, that is definitely the cause. I mis-understood the implications of removing that "#ifndef __ARCH_HAS_NO_SHARED__" conditional. I am testing a different change here that I think might do ther job better: --- a/ldso/include/dl-defs.h +++ b/ldso/include/dl-defs.h @@ -72,7 +72,7 @@ #endif #ifdef _LIBC -#ifndef __ARCH_HAS_NO_SHARED__ +#ifndef __ARCH_HAS_NO_LDSO__ /* arch specific defines */ #include <dl-sysdep.h> #endif