On 6/22/17 8:37 AM, Thomas Petazzoni wrote:
Hello,
On Thu, 22 Jun 2017 08:33:31 -0400, Anthony G. Basile wrote:
I just did a grep of glibc master/HEAD and it looks like __FAVOR_BSD has been removed. If we remove __FAVOR_BSD from uclibc, will buildroot stuff build fine? You can test by just removing those lines from features.h and forcing undef __FAVOR_BSD. If it works, I can produce a patch.
Well, "Buildroot stuff" is very vague. Are you talking about such this "knock" package of the ~2000 packages that Buildroot has?
If you provide a patch, I can quickly validate if it fixes the knock package. However, if you want to be sure it doesn't cause regressions for other packages, I would have to commit this patch in Buildroot, so that it gets tested by our automated testing infrastructure.
Best regards,
Thomas
Yes, I'm worried about regressions. __FAVOR_BSD is still used in the following:
include/setjmp.h include/unistd.h include/signal.h include/features.h include/netinet/udp.h
and deals with the differences in which signals and long jmps were handled in older BSD. I don't know buildroot that well, but if you grep the tree, will it show where __FAVOR_BSD is used? Or does it (like gentoo's portage) pull in source code as it builds. I assume the latter so grepping is probably insufficient.