On 11/05/2017 02:03 AM, Waldemar Brodkorb wrote:
Hi Alexey,
the attached patch fixes at least 3 test suite errors for me. tst-cancel20/21/4. Tested with latest 2017.09 ARC binutils/gcc.
Okay to apply?
best regards Waldemar
Are you sure it is the list above.
I presume, https://tests.embedded-test.org/uClibc-ng/1.0.26/REPORT.arcv2.libc.uClibc-ng... didn't have this fix and yet the tests mentioned above are PASS there.
The reason I ask is because in my experiments here with ARC GNU 2017.09 + uClibc with and w/o this patch (actually not exactly same, but similar - attached), I don't see any consistent PASS(es) There are some changes to say tst-kill6, tst-oncex3 etc but if you run them 5 times they seem to PASS/FAIL randomly - in either setups
So this patch is not fixing anything IMO. We need to really fix the inherent race in these tests.
BTW I did post a test case fix for tst-cancel2 and that is now consistently PASS.
-Vineet