[uclibc-ng-devel] Re: [RFC 0/2] xtensa: add FDPIC ABI support

Hi Waldemar,

On Sun, May 5, 2024 at 2:51 AM Waldemar Brodkorb wbx@openadk.org wrote:

...

On Sat, May 4, 2024 at 12:14 AM Max Filippov jcmvbkbc@gmail.com wrote:

...

On Fri, May 3, 2024 at 8:15 PM Waldemar Brodkorb wbx@openadk.org wrote:

...

How did you test NPTL/TLS?

I grepped for the tests explicitly using fork and added them to the TESTS_DISABLED in the test/nptl/Makefile.in, and also added there the tests that internally time out, got the following list:

+TESTS_DISABLED := tst-atfork1 \

•             tst-atfork2 \
  

•             tst-atfork2mod \
  

•             tst-barrier2 \
  

•             tst-basic4 \
  

•             tst-cancel16 \
  

•             tst-cancel21 \
  

•             tst-cancel4 \
  

•             tst-cancel5 \
  

•             tst-cancelx16 \
  

•             tst-cancelx21 \
  

•             tst-cancelx4 \
  

•             tst-cond12 \
  

•             tst-cond13 \
  

•             tst-cond4 \
  

•             tst-cond6 \
  

•             tst-cpuclock1 \
  

•             tst-cputimer3 \
  

•             tst-exec2 \
  

•             tst-exec3 \
  

•             tst-exec4 \
  

•             tst-flock2 \
  

•             tst-fork1 \
  

•             tst-fork2 \
  

•             tst-fork3 \
  

•             tst-fork4 \
  

•             tst-getpid3 \
  

•             tst-mqueue1 \
  

•             tst-mqueue3 \
  

•             tst-mqueue5 \
  

•             tst-mutex4 \
  

•             tst-mutex9 \
  

•             tst-rwlock12 \
  

•             tst-rwlock4 \
  

•             tst-sem3 \
  

•             tst-sem4 \
  

•             tst-signal1 \
  

•             tst-signal2 \
  

•             tst-spin2 \
  

•             tst-tsd6
  
  

I added a check for MMU for these tests.

...

also the following tests either hang or cause problems, so I disabled them as well:

mmap/mmap2 \ nptl/tst-basic7 \ nptl/tst-cond3 \ nptl/tst-eintr1 \ nptl/tst-eintr2 \ nptl/tst-eintr3 \ nptl/tst-eintr4 \ nptl/tst-eintr5 \ nptl/tst-exit2 \ nptl/tst-exit3 \ nptl/tst-mqueue6 \ nptl/tst-stdio1

I would like to disable these tests only for Xtensa FDPIC

I doubt that they're FDPIC-specific. The mmap2 is clearly related to noMMU, I haven't looked closely at the rest yet, I'll do it this week.

but wbx@helium:~/openadk$ ./toolchain_qemu-xtensa_uclibc-ng_dc233c_call0_fdpic_nommu/usr/bin/xtensa-openadk-linux-uclibcfdpic-gcc -dM -E -</dev/null|grep -i fdpic wbx@helium:~/openadk$

wbx@helium:~/openadk$ ./toolchain_qemu-arm-versatilepb_uclibc-ng_arm926ej_s_hard_eabihf_fdpic_arm_nommu/usr/bin/arm-openadk-uclinuxfdpiceabi-gcc -dM -E - </dev/null|grep -i fdpic #define __FDPIC__ 1 wbx@helium:~/openadk$

Any reason there is no __FDPIC__ set?

It haven't been implemented in that gcc version, it should be there in the gcc tagged xtensa-fdpic-abi-spec-1.2 Also binutils/gcc tagged xtensa-fdpic-abi-spec-1.2 should be able to build xtensa FDPIC toolchain with both uclibc-ng and musl.

I will check these tests soon on real ARM noMMU hardware.