Hello,
On Tue, Dec 26, 2017 at 7:44 PM, Waldemar Brodkorb wbx@uclibc-ng.org wrote:
Hi Stafford, Stafford Horne wrote,
Traditionally nds32 has had a generic syscall implementation supporting varargs.
During an audit it was found that this implementation seems to duplicate the new common implementation and is no longer needed.
nds32 syscall is special. I get following compile error: libc/sysdeps/linux/common/syscall.c: In function 'syscall': libc/sysdeps/linux/common/syscall.c:27:2: warning: implicit declaration of function 'internal_syscall_ncs6' [-Wimplicit-function-declaration] return INLINE_SYSCALL_NCS(sysnum, 6, arg1, arg2, arg3, arg4, arg5, arg6); ^ In file included from ./include/sys/syscall.h:33:0, from libc/sysdeps/linux/common/syscall.c:8: ./include/bits/syscalls-common.h:49:39: error: '__err' undeclared (first use in this function) __res = INTERNAL_SYSCALL_NCS(num, __err, nr, args); \
Not sure if we should touch nds32.
Looking at : libc/sysdeps/linux/nds32/bits/syscalls.h
It may be easy to add, but maybe we can leave this for the maintainers to reply.
-Stafford