Re: [uclibc-ng-devel] [PATCH 1/2] fanotify: add system call support

Bartosz, Waldemar, On Wed, 14 Oct 2015 17:14:00 +0200, Bartosz Golaszewski wrote: This commit breaks the uClibc-ng when fairly old (2.6.35) kernel headers are used, because the fanotify system call wasn't available at that time, so <linux/fanotify.h> doesn't exist. See http://jenkins.free-electrons.com/job/buildroot/configurations=mx53loco_def…. It started failing since we updated to uClibc-ng 1.0.8. I am not sure what's the policy of uClibc-ng on that respect: 1/ Should the fanotify() implementation in uClibc-ng be made conditional on the availability of the corresponding system calls and header files in the kernel headers. 2/ Or should fanotify be behind some kconfig option? I would personally prefer (1), so that it gets automatically enabled when available, and disabled otherwise. (2) would be less practical for projects like Buildroot. Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com