[PATCH 0/3] ARC uClibc fixes
Hi, Assorted fixes for ARC, please consider applying. Thx, -Vineet Vineet Gupta (3): NPTL/ARCv2: Implement full memory barrier for NPTL NPTL/ARC: fix __lll_lock_wait_private redefinition for static links ARC: With NPTL support, GP is no longer used for PIC ldso/ldso/arc/dl-sysdep.h | 6 ------ libc/sysdeps/linux/arc/bits/atomic.h | 7 +++++-- libpthread/nptl/sysdeps/unix/sysv/linux/arc/lowlevellock.c | 4 +++- 3 files changed, 8 insertions(+), 9 deletions(-) -- 1.9.1
Signed-off-by: Vineet Gupta <vgupta@synopsys.com> --- libc/sysdeps/linux/arc/bits/atomic.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libc/sysdeps/linux/arc/bits/atomic.h b/libc/sysdeps/linux/arc/bits/atomic.h index d4abf4eb7896..1fdc83f70f6b 100644 --- a/libc/sysdeps/linux/arc/bits/atomic.h +++ b/libc/sysdeps/linux/arc/bits/atomic.h @@ -24,8 +24,11 @@ typedef uintmax_t uatomic_max_t; void __arc_link_error (void); -#define atomic_full_barrier() \ - __asm__ __volatile__("": : :"memory") +#ifdef __A7__ +#define atomic_full_barrier() __asm__ __volatile__("": : :"memory") +#else +#define atomic_full_barrier() __asm__ __volatile__("dmb 3": : :"memory") +#endif /* Atomic compare and exchange. */ -- 1.9.1
Commit 2d9740a65a "uclibc: nptl: fix __lll_lock_wait_private multiple definition" did a sweeping change which did for all in tree arches at that time (ARC wasn't) Signed-off-by: Vineet Gupta <vgupta@synopsys.com> --- libpthread/nptl/sysdeps/unix/sysv/linux/arc/lowlevellock.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libpthread/nptl/sysdeps/unix/sysv/linux/arc/lowlevellock.c b/libpthread/nptl/sysdeps/unix/sysv/linux/arc/lowlevellock.c index 1aa79609a713..fd39fe907444 100644 --- a/libpthread/nptl/sysdeps/unix/sysv/linux/arc/lowlevellock.c +++ b/libpthread/nptl/sysdeps/unix/sysv/linux/arc/lowlevellock.c @@ -24,8 +24,10 @@ #include <tls.h> #include <tcb-offsets.h> - void +#ifndef IS_IN_libpthread +weak_function +#endif __lll_lock_wait_private (int *futex) { if (*futex == 2) -- 1.9.1
Signed-off-by: Vineet Gupta <vgupta@synopsys.com> --- ldso/ldso/arc/dl-sysdep.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/ldso/ldso/arc/dl-sysdep.h b/ldso/ldso/arc/dl-sysdep.h index ca62a2c04f35..b6bda9d14691 100644 --- a/ldso/ldso/arc/dl-sysdep.h +++ b/ldso/ldso/arc/dl-sysdep.h @@ -127,12 +127,6 @@ static __always_inline Elf32_Addr elf_machine_dynamic(void) __asm__("ld %0,[pcl,_DYNAMIC@gotpc]\n\t" : "=r" (dyn)); return dyn; - -/* - * Another way would have been to simply return GP, which due to some - * PIC reference would be automatically setup by gcc in caller - * register Elf32_Addr *got __asm__ ("gp"); return *got; - */ } /* Return the run-time load address of the shared object. */ -- 1.9.1
On Wednesday 21 October 2015 12:42 PM, Vineet Gupta wrote:
Hi,
Assorted fixes for ARC, please consider applying.
Thx, -Vineet
Ping ! Or should we assume that uClibc is dead for good ! -Vineet
Vineet Gupta (3): NPTL/ARCv2: Implement full memory barrier for NPTL NPTL/ARC: fix __lll_lock_wait_private redefinition for static links ARC: With NPTL support, GP is no longer used for PIC
ldso/ldso/arc/dl-sysdep.h | 6 ------ libc/sysdeps/linux/arc/bits/atomic.h | 7 +++++-- libpthread/nptl/sysdeps/unix/sysv/linux/arc/lowlevellock.c | 4 +++- 3 files changed, 8 insertions(+), 9 deletions(-)
On December 14, 2015 7:09:40 AM GMT+01:00, Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote:
On Wednesday 21 October 2015 12:42 PM, Vineet Gupta wrote:
Hi,
Assorted fixes for ARC, please consider applying.
Thx, -Vineet
Ping !
Sorry for the long delay, will push these during christmas break. Thanks,
Or should we assume that uClibc is dead for good !
-Vineet
Vineet Gupta (3): NPTL/ARCv2: Implement full memory barrier for NPTL NPTL/ARC: fix __lll_lock_wait_private redefinition for static links ARC: With NPTL support, GP is no longer used for PIC
ldso/ldso/arc/dl-sysdep.h | 6
------
libc/sysdeps/linux/arc/bits/atomic.h | 7 +++++-- libpthread/nptl/sysdeps/unix/sysv/linux/arc/lowlevellock.c | 4 +++- 3 files changed, 8 insertions(+), 9 deletions(-)
_______________________________________________ uClibc mailing list uClibc@uclibc.org http://lists.busybox.net/mailman/listinfo/uclibc
participants (3)
-
Bernhard Reutner-Fischer -
Vineet Gupta -
Waldemar Brodkorb