- devel - example.com

[PATCH] towlower and locales
by Eugene Yudin 02 Aug '17

02 Aug '17

Hi, The function towlower doesn't work with locales diffrent from C. Issue was introduced in this commit: https://cgit.openadk.org/cgi/cgit/uclibc-ng.git/commit/?id= 8cde3a9bf2856dcb9a759dec7ecb04a68e712254 Call to setlocale is needed for correct generation of the table uplow_diff. I received the compile time error "range assumption error" after uncommenting the call. Similar problem described here: http://lists.uclibc.org/pipermail/uclibc/2015-March/048852.html The attached patch fix the problem by using int32_t values. Test program: $ cat test.c #include <locale.h> #include <stdio.h> #include <wchar.h> #include <wctype.h> int main(int argc, char *argv[]) { int i = 0; wchar_t str[] = L"ТЕСТОВАЯ СТРОКА"; wchar_t c; setlocale(LC_ALL, "ru_RU.utf-8"); wprintf(L"Input:\t\"%ls\"\n", str); wprintf(L"Output:\t\""); while (str[i]) { c = str[i]; putwchar(towlower(c)); i++; } wprintf(L"\"\n"); return 0; } Output (without patch): $ ./test Input: "ТЕСТОВАЯ СТРОКА" Output: "ТЕСТОВАЯ СТРОКА" Output (with patch): $ ./test Input: "ТЕСТОВАЯ СТРОКА" Output: "тестовая строка" -- Best regards, Eugene

3 4

[PATCH] valloc declaration in stdlib.h
by Eugene Yudin 29 Jul '17

29 Jul '17

Hi, Current uClibc-ng have issue with several different valloc declarations. malloc.h: #ifdef __UCLIBC_SUSV2_LEGACY__ /* Allocate SIZE bytes on a page boundary. */ extern __malloc_ptr_t valloc __MALLOC_P ((size_t __size)) __attribute_malloc__; #endif stdlib.h: #if defined __USE_BSD || defined __USE_XOPEN_EXTENDED /* Allocate SIZE bytes on a page boundary. The storage cannot be freed. */ extern void *valloc (size_t __size) __THROW __attribute_malloc__ __wur; #endif The second declaration doesn't use the define __UCLIBC_SUSV2_LEGACY__. That leads to compile time problems. The attached patch fixes this diffrence. -- Best regards, Eugene

2 3

syscall cancel simplification patches
by Waldemar Brodkorb 29 Jul '17

29 Jul '17

Hi, I would like to get some feedback for following three patches. The test suite runs over all architectures showed no regressions. The goal is to simplify the addition of new architectures and remove the need to add assembly code to sysdep-cancel.h. Most of the work was done in 2011 in commit 9f68f0cbf8c8eea6a7f9e195e4617bbaa808d7c6, but it was not finished for NPTL and RT components of uClibc. best regards Waldemar

3 3

segfault in dlclose() when lots of shared objects are dlopened - the story continues
by Bernd Kuhls 20 Jul '17

20 Jul '17

Hi, investigating a segfault (gdb) bt full #0 0x00007fffec28dd90 in __deregister_frame_info () from /lib/ libgcc_s.so.1 No symbol table info available. #1 0x00007fffebf8af66 in __do_global_dtors_aux () from /usr/lib/ libgcrypt.so.20 when starting Apache with mod_php activated on a buildroot-built x86_64- system with uclibc-1.0.19 I came across discussions from 2012 & 2014 on the uClibc mailinglist: 2012: http://lists.uclibc.org/pipermail/uclibc/2012-October/047059.html 2014: http://lists.busybox.net/pipermail/uclibc/2014-December/048737.html Building mod_php without libgcrypt.so, which means disabling BR2_PACKAGE_PHP_EXT_XSL, does not fix the problem, the segfault will occur in another shared lib. Quoting the message from 2014: > In my particular case, this meant dlopening and dlclosing some 47 > shared objects as reported by "LD_DEBUG=1 /usr/bin/gdk-pixbuf-query- > loaders ./libpixbufloader-svg.la 2>&1 | grep ^do_dlopen | grep ctors > | wc -l" My system opens even more shared libs when starting Apache & mod_php: # LD_DEBUG=1 /usr/bin/httpd -t 2>&1 | grep ^do_dlopen | grep ctors | wc -l 64 Segmentation fault Please note that using Apache without mod_php works fine, php-cgi itself also works fine. In 2014 Anthony suggested to revert https://git.busybox.net/uClibc/commit/ldso? h=0.9.33&id=9b42da7d0558884e2a3cc9a8674ccfc752369610 which still solves the Apache/mod_php segfault today. Uclibc-1.0.19 includes all commits from 2016-09-26 and older in https://cgit.openadk.org/cgi/cgit/uclibc-ng.git/log/ldso/libdl it therefore includes https://cgit.openadk.org/cgi/cgit/uclibc-ng.git/ commit/ldso/libdl?id=cc04ab27ba6341f46bbe094478c9af3e3706f411 which refers to fix the problem from the 2012 message, but it did not. Regards, Bernd

2 1

Missing git tags at github mirror
by Anton Kolesov 13 Jul '17

13 Jul '17

Hi, It seems that GitHub mirror at https://github.com/wbx-github/uclibc-ng/tree/master is missing git tags for releases starting with v1.0.23. Mirror at http://repo.or.cz/uclibc-ng.git OTOH has those tags. Anton

2 1

[PATCH] netinet/udp: add missing include
by Romain Naour 12 Jul '17

12 Jul '17

Since the refactoring introduced by [1] any check using netinet/udp.h fail with the following error: [...]/usr/include/netinet/udp.h:62:7: error: unknown type name 'uint16_t' See the error in netinet/udp.h check: [efl] http://autobuild.buildroot.net/results/8c6/8c629a1c5c4a1d78c8bf09a091a332a4… [trinity] http://autobuild.buildroot.net/results/c8f/c8f34aaaecf931e0044ef858ef587325… [1] 58a5ba12bffad5916d9897c2870fc483f1db8282 Signed-off-by: Romain Naour <romain.naour(a)gmail.com> --- include/netinet/udp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/netinet/udp.h b/include/netinet/udp.h index ac6f234..f03e2dc 100644 --- a/include/netinet/udp.h +++ b/include/netinet/udp.h @@ -48,6 +48,7 @@ #define __NETINET_UDP_H 1 #include <features.h> +#include <stdint.h> #include <sys/types.h> -- 2.9.4

2 2

ld.so cleanup
by Waldemar Brodkorb 29 Jun '17

29 Jun '17

Hi, I would suggest following patch, which removes the special communication between ld.so and gdb. While debugging a ld.so issue with gdb 8.0 on alpha, I recognized that the debugger stalled when trying to execute this code. It thought this code was added to help debugging ld.so, but it seems nowadays it prevents to do so. May be bitrotted? Does anyone found it useful while debugging ld.so with gdb in the past? best regards Waldemar

3 3

[PATCH] include/features.h: add _DEFAULT_SOURCE macro
by Anthony G. Basile 22 Jun '17

22 Jun '17

From: "Anthony G. Basile" <blueness(a)gentoo.org> man feature_test_macros(7) specifies that _BSD_SOURCE and _SVID_SOURCE have been deprecated in favor of _DEFAULT_SOURCE since libc 2.20. Specifying either of the former is now equivalent to specifying just the latter. We add this macro to conform to this standard, but do not add the compiler warning to maintain full backwards compatibility with earlier version of glibc and uclibc. Signed-off-by: Anthony G. Basile <blueness(a)gentoo.org> --- include/features.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/include/features.h b/include/features.h index f9820791b..362b811fd 100644 --- a/include/features.h +++ b/include/features.h @@ -40,6 +40,7 @@ _SVID_SOURCE ISO C, POSIX, and SVID things. _ATFILE_SOURCE Additional *at interfaces. _GNU_SOURCE All of the above, plus GNU extensions. + _DEFAULT_SOURCE Equivalent to defining _BSD_SOURCE and _SVID_SOURCE. _REENTRANT Select additionally reentrant object. _THREAD_SAFE Same as _REENTRANT, often used by other systems. _FORTIFY_SOURCE If set to numeric value > 0 additional security @@ -140,6 +141,19 @@ # define __GNUC_PREREQ(maj, min) 0 #endif +/* _DEFAULT_SOURCE is equivalent to defining _BSD_SOURCE and _SVID_SOURCE + * and vice versa. */ +#ifdef _DEFAULT_SOURCE +# undef _BSD_SOURCE +# define _BSD_SOURCE 1 +# undef _SVID_SOURCE +# define _SVID_SOURCE 1 +#endif + +#if defined _BSD_SOURCE || defined _SVID_SOURCE +# undef _DEFAULT_SOURCE +# define _DEFAULT_SOURCE 1 +#endif /* If _BSD_SOURCE was defined by the user, favor BSD over POSIX. */ #if defined _BSD_SOURCE && \ -- 2.13.0

4 8

uClibc-ng release 1.0.25
by Waldemar Brodkorb 11 Jun '17

11 Jun '17

Hi, I released a new version of uClibc-ng today. It contains mostly bugfixes and cleanups. It allows to be used for gcc 7.1 toolchains. have fun, Waldemar

1 0

[PATCH] Fix mkostemp64 creation mode.
by Ignacy Gawędzki 11 Jun '17

11 Jun '17

All flavors of mkstemp create files with mode S_IRUSR | S_IWUSR, as per POSIX.1-2008. Make mkostemp64 follow that too instead of creating files with mode S_IRUSR | S_IWUSR | S_IXUSR. Signed-off-by: Ignacy Gawędzki <ignacy.gawedzki(a)green-communications.fr> --- libc/stdlib/mkostemp64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libc/stdlib/mkostemp64.c b/libc/stdlib/mkostemp64.c index 25595ad96..aa9736cd6 100644 --- a/libc/stdlib/mkostemp64.c +++ b/libc/stdlib/mkostemp64.c @@ -28,5 +28,5 @@ int mkostemp64 (char *template, int flags) { return __gen_tempname (template, __GT_BIGFILE, flags | O_LARGEFILE, 0, - S_IRUSR | S_IWUSR | S_IXUSR); + S_IRUSR | S_IWUSR); } -- 2.11.0

2 1