21 Jul
2017
21 Jul
'17
7:31 p.m.
Hi,
I would like to get some feedback for following three patches.
The test suite runs over all architectures showed no regressions.
The goal is to simplify the addition of new architectures and
remove the need to add assembly code to sysdep-cancel.h.
Most of the work was done in 2011 in commit
9f68f0cbf8c8eea6a7f9e195e4617bbaa808d7c6, but it was not finished
for NPTL and RT components of uClibc.
best regards
Waldemar
27 Jul
27 Jul
6:40 a.m.
On 07/22/2017 01:08 AM, Waldemar Brodkorb wrote:
Hi,
I would like to get some feedback for following three patches.
The test suite runs over all architectures showed no regressions.
The goal is to simplify the addition of new architectures and
remove the need to add assembly code to sysdep-cancel.h.
Most of the work was done in 2011 in commit
9f68f0cbf8c8eea6a7f9e195e4617bbaa808d7c6, but it was not finished
for NPTL and RT components of uClibc.
LGTM, I've not tested the patches, but I will trust your regression reports :-)
Thx,
-Vineet
28 Jul
28 Jul
2:16 a.m.
Hi Waldemar,
On Fri, Jul 21, 2017 at 12:31 PM, Waldemar Brodkorb <wbx(a)uclibc-ng.org> wrote:
I would like to get some feedback for following three
patches.
The test suite runs over all architectures showed no regressions.
The goal is to simplify the addition of new architectures and
remove the need to add assembly code to sysdep-cancel.h.
Most of the work was done in 2011 in commit
9f68f0cbf8c8eea6a7f9e195e4617bbaa808d7c6, but it was not finished
for NPTL and RT components of uClibc.
I've taken a look into it and got a couple of questions:
- removal of CLONE_VM and CLONE_THREAD from libc/sysdeps/linux/*/clone.S
probably does not belong to the "nptl: remove asm from sysdep-cancel.h"
patch.
- sysdep-cancel.h files now look very similar across all architectures,
and they no longer seem to be arch-specific. Should they now become a single
generic file?
--
Thanks.
-- Max
29 Jul
29 Jul
9:30 a.m.
Hi Max,
Am 28.07.2017 um 04:16 schrieb Max Filippov
<jcmvbkbc(a)gmail.com>om>:
Hi Waldemar,
I splitted the patch before pushing.
On Fri, Jul 21, 2017 at 12:31 PM, Waldemar
Brodkorb <wbx(a)uclibc-ng.org> wrote:
I would like to get some feedback for following three patches.
The test suite runs over all architectures showed no regressions.
The goal is to simplify the addition of new architectures and
remove the need to add assembly code to sysdep-cancel.h.
Most of the work was done in 2011 in commit
9f68f0cbf8c8eea6a7f9e195e4617bbaa808d7c6, but it was not finished
for NPTL and RT components of uClibc.
I've taken a look into it and got a couple of questions:
- removal of CLONE_VM and CLONE_THREAD from libc/sysdeps/linux/*/clone.S
probably does not belong to the "nptl: remove asm from sysdep-cancel.h" patch.
- sysdep-cancel.h files now look very similar across
all architectures,
and they no longer seem to be arch-specific. Should they now become a single
generic file?
Good idea, i will try this rework for the next release.
Thanks for your feedback,
best regards
Waldemar
2463
days inactive
2471
days old
3 comments
3 participants
participants (3)
-
Max Filippov -
Vineet Gupta -
Waldemar Brodkorb