Hi Max, Max Filippov wrote,
On Mon, Jul 11, 2016 at 9:13 AM, Waldemar Brodkorb wbx@uclibc-ng.org wrote:
Max Filippov wrote,
On Sun, Jul 10, 2016 at 9:25 AM, Waldemar Brodkorb wbx@uclibc-ng.org wrote:
I want to add following cleanup patch. No regressions found.
Okay? Comments?
The following looks either broken or unused in the current code, given there's no matching PTR_MANGLE:
Right. Is SHARED defined via gcc?
I think it comes from the following line in the Makerules:
CFLAGS-.oS+=$(PICFLAG) -DSHARED
So it does not apply to .os and so we found indeed dead code. The referenced function isn't there, I will remove the code inside SHARED.
I think normally #ifdef __PIC__ is used for this?
Does that work for FDPIC or shared FLAT?
For FDPIC, yes: ./toolchain_sim-bfin_uclibc-ng_bf512_fdpic/usr/bin/bfin-openadk-linux-uclibc-gcc -dM -E - < /dev/null|grep -i pic #define __BFIN_FDPIC__ 1 #define __pic__ 1 #define __PIC__ 1 #define __FDPIC__ 1
For shared FLAT, no: ./toolchain_sim-bfin_uclibc-ng_bf512_bflt/usr/bin/bfin-openadk-uclinux-uclibc-gcc -dM -E - </dev/null|grep -i pic
So indeed normally __PIC__ should be fine for architectures without MMU-less support, rigth?
Do you plan for syncing with glibc in the future?
Not really. I will do partially sync architecture specific bits and bytes. But no bigger sync is planned.
Ok. Reviewed-by: Max Filippov jcmvbkbc@gmail.com
Thanks Waldemar