10 Jul
2016
10 Jul
'16
6:25 a.m.
Hi,
I want to add following cleanup patch.
No regressions found.
Okay? Comments?
best regards
Waldemar
11 Jul
11 Jul
4:50 a.m.
Hi Waldemar,
On Sun, Jul 10, 2016 at 9:25 AM, Waldemar Brodkorb <wbx(a)uclibc-ng.org> wrote:
I want to add following cleanup patch.
No regressions found.
Okay? Comments?
The following looks either broken or unused in the current code,
given there's no matching PTR_MANGLE:
diff --git a/libc/sysdeps/linux/x86_64/sched_getcpu.S
b/libc/sysdeps/linux/x86_64/sched_getcpu.S
index f8c09c0..1e0a344 100644
--- a/libc/sysdeps/linux/x86_64/sched_getcpu.S
+++ b/libc/sysdeps/linux/x86_64/sched_getcpu.S
@@ -37,7 +37,6 @@ ENTRY (sched_getcpu)
#ifdef SHARED
movq __vdso_getcpu(%rip), %rax
- PTR_DEMANGLE (%rax)
callq *%rax
#else
# ifdef __NR_getcpu
AFAICS PTR_MANGLE/PTR_DEMANGLE are still present in glibc, but their
use in common code is conditional, though in arch-specific code it is not.
Do you plan for syncing with glibc in the future?
--
Thanks.
-- Max
6:13 a.m.
Hi Max,
Max Filippov wrote,
Hi Waldemar,
On Sun, Jul 10, 2016 at 9:25 AM, Waldemar Brodkorb <wbx(a)uclibc-ng.org> wrote:
Right. Is SHARED defined via gcc? I think normally #ifdef __PIC__
is used for this?
I want to add following cleanup patch.
No regressions found.
Okay? Comments?
The following looks either broken or unused in the current code,
given there's no matching PTR_MANGLE: diff --git a/libc/sysdeps/linux/x86_64/sched_getcpu.S
b/libc/sysdeps/linux/x86_64/sched_getcpu.S
index f8c09c0..1e0a344 100644
--- a/libc/sysdeps/linux/x86_64/sched_getcpu.S
+++ b/libc/sysdeps/linux/x86_64/sched_getcpu.S
@@ -37,7 +37,6 @@ ENTRY (sched_getcpu)
#ifdef SHARED
movq __vdso_getcpu(%rip), %rax
- PTR_DEMANGLE (%rax)
callq *%rax
#else
# ifdef __NR_getcpu
AFAICS PTR_MANGLE/PTR_DEMANGLE are still present in glibc, but their
use in common code is conditional, though in arch-specific code it is not.
Do you plan for syncing with glibc in the future?
Not really. I will do partially sync architecture specific bits and
bytes. But no bigger sync is planned.
best regards
Waldemar
9:03 a.m.
On Mon, Jul 11, 2016 at 9:13 AM, Waldemar Brodkorb <wbx(a)uclibc-ng.org> wrote:
Ok.
Reviewed-by: Max Filippov <jcmvbkbc(a)gmail.com>
--
Thanks.
-- Max
Max Filippov wrote,
I think it comes from the following line in the Makerules:
CFLAGS-.oS+=$(PICFLAG) -DSHARED
On Sun, Jul 10, 2016 at 9:25 AM, Waldemar
Brodkorb <wbx(a)uclibc-ng.org> wrote:
Right. Is SHARED defined via gcc? I want to add following cleanup patch.
No regressions found.
Okay? Comments?
The following looks either broken or unused in the current code,
given there's no matching PTR_MANGLE: I think normally #ifdef __PIC__ is used for this?
Does that work for FDPIC or shared FLAT?
Do you plan
for syncing with glibc in the future?
Not really. I will do partially sync architecture specific bits and
bytes. But no bigger sync is planned.
6:08 p.m.
Hi Max,
Max Filippov wrote,
For FDPIC, yes:
./toolchain_sim-bfin_uclibc-ng_bf512_fdpic/usr/bin/bfin-openadk-linux-uclibc-gcc
-dM -E - < /dev/null|grep -i pic
#define __BFIN_FDPIC__ 1
#define __pic__ 1
#define __PIC__ 1
#define __FDPIC__ 1
For shared FLAT, no:
./toolchain_sim-bfin_uclibc-ng_bf512_bflt/usr/bin/bfin-openadk-uclinux-uclibc-gcc
-dM -E - </dev/null|grep -i pic
So indeed normally __PIC__ should be fine for architectures without
MMU-less support, rigth?
Ok.
Reviewed-by: Max Filippov <jcmvbkbc(a)gmail.com>
Thanks
Waldemar
On Mon, Jul 11, 2016 at 9:13 AM, Waldemar Brodkorb
<wbx(a)uclibc-ng.org> wrote:
So it does not apply to .os and so we found indeed dead code.
The referenced function isn't there, I will remove the code
inside SHARED.
Max Filippov wrote,
I think it comes from the following line in the Makerules:
CFLAGS-.oS+=$(PICFLAG) -DSHARED On Sun, Jul 10, 2016 at 9:25 AM, Waldemar
Brodkorb <wbx(a)uclibc-ng.org> wrote:
Right. Is SHARED defined via gcc? I want to add following cleanup patch.
No regressions found.
Okay? Comments?
The following looks either broken or unused in the current code,
given there's no matching PTR_MANGLE: I think
normally #ifdef __PIC__ is used for this?
Does that work for FDPIC or shared FLAT? Do you plan for syncing with glibc in the future?
Not really. I will do partially sync architecture specific bits and
bytes. But no bigger sync is planned.
2851
days inactive
2852
days old
4 comments
2 participants
participants (2)
-
Max Filippov -
Waldemar Brodkorb