Hi,
I am preparing a release and would like to remove UCLIBC_HAS_LFS before doing it.
I believe UCLIBC_HAS_LFS does make the code more complex and the benefit to disable it to save some bytes is not high enough.
Most users have UCLIBC_HAS_LFS enabled and it is enabled by default.
Attached is a patch.
Any comments?
best regards Waldemar
+CC Thomas for buildroot aspect
On 11/29/2016 09:31 PM, Waldemar Brodkorb wrote:
Hi,
I am preparing a release and would like to remove UCLIBC_HAS_LFS before doing it.
I believe UCLIBC_HAS_LFS does make the code more complex and the benefit to disable it to save some bytes is not high enough.
Most users have UCLIBC_HAS_LFS enabled and it is enabled by default.
Attached is a patch.
Any comments?
best regards Waldemar
I welcome this change - is there going to be impact on downstream projects like busybox. What if it some disables CONFIG_LFS inside busybox ?
-Vineet
Hello,
On Tue, 29 Nov 2016 21:43:20 -0800, Vineet Gupta wrote:
On 11/29/2016 09:31 PM, Waldemar Brodkorb wrote:
Hi,
I am preparing a release and would like to remove UCLIBC_HAS_LFS before doing it.
I believe UCLIBC_HAS_LFS does make the code more complex and the benefit to disable it to save some bytes is not high enough.
Most users have UCLIBC_HAS_LFS enabled and it is enabled by default.
Attached is a patch.
Any comments?
best regards Waldemar
I welcome this change - is there going to be impact on downstream projects like busybox. What if it some disables CONFIG_LFS inside busybox ?
In Buildroot, we have dropped the ability to disable LFS since March 2015. It was really too annoying to maintain the !LFS case, for no real benefit.
So I'm completely fine with uClibc-ng dropping !LFS support upstream, since Buildroot no longer cares about this possibility.
Best regards,
Thomas
Hi Vineet, Vineet Gupta wrote,
+CC Thomas for buildroot aspect
On 11/29/2016 09:31 PM, Waldemar Brodkorb wrote:
Hi,
I am preparing a release and would like to remove UCLIBC_HAS_LFS before doing it.
I believe UCLIBC_HAS_LFS does make the code more complex and the benefit to disable it to save some bytes is not high enough.
Most users have UCLIBC_HAS_LFS enabled and it is enabled by default.
Attached is a patch.
Any comments?
best regards Waldemar
I welcome this change - is there going to be impact on downstream projects like busybox. What if it some disables CONFIG_LFS inside busybox ?
At least it does compile fine and I can bootup a system in Qemu. I think it will just not work with files bigger than 2GB.
Busybox use LFS mostly for Android systems, if I interpret the code in libbb.h correctly.
best regards Waldemar
"Waldemar" == Waldemar Brodkorb wbx@uclibc-ng.org writes:
Hi, I am preparing a release and would like to remove UCLIBC_HAS_LFS before doing it.
I believe UCLIBC_HAS_LFS does make the code more complex and the benefit to disable it to save some bytes is not high enough.
Most users have UCLIBC_HAS_LFS enabled and it is enabled by default.
I agree. The size saving is really quite small. We did the same thing in Buildroot last year.
Hi Waldemar,
On Wed, 2016-11-30 at 06:31 +0100, Waldemar Brodkorb wrote:
Hi,
I am preparing a release and would like to remove UCLIBC_HAS_LFS before doing it.
I believe UCLIBC_HAS_LFS does make the code more complex and the benefit to disable it to save some bytes is not high enough.
Most users have UCLIBC_HAS_LFS enabled and it is enabled by default.
Attached is a patch.
Any comments?
Looks good to me, thought maybe Vineet has another opinion on that.
-Alexey
Opps, didn't notice Vineet has already answered :)
-Alexey
On Wed, 2016-11-30 at 12:25 +0300, Alexey Brodkin wrote:
Hi Waldemar,
On Wed, 2016-11-30 at 06:31 +0100, Waldemar Brodkorb wrote:
Hi,
I am preparing a release and would like to remove UCLIBC_HAS_LFS before doing it.
I believe UCLIBC_HAS_LFS does make the code more complex and the benefit to disable it to save some bytes is not high enough.
Most users have UCLIBC_HAS_LFS enabled and it is enabled by default.
Attached is a patch.
Any comments?
Looks good to me, thought maybe Vineet has another opinion on that.
-Alexey
-
Alexey Brodkin -
Peter Korsgaard -
Thomas Petazzoni -
Vineet Gupta -
Waldemar Brodkorb