While they are not a problem per-se they cause issues with some tooling
(such as clang coverage) and are confusing to the reader.
---
extra/locale/programs/locale.c | 2 +-
ldso/include/dl-string.h | 2 +-
libc/misc/time/time.c | 2 +-
libc/string/strcasestr.c | 2 +-
libc/string/strstr.c | 2 +-
libc/unistd/sysconf.c | 4 ++--
6 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/extra/locale/programs/locale.c b/extra/locale/programs/locale.c
index 5d16d1276..4157c4a8e 100644
--- a/extra/locale/programs/locale.c
+++ b/extra/locale/programs/locale.c
@@ -231,7 +231,7 @@ static void find_locale_string(locale_entry * loc_rec, char *loc)
*loc = '\0';
} else {
dotcs = (uint16_t) loc_rec->dot_cs;
- cs = (uint16_t) loc_rec->cs;;
+ cs = (uint16_t) loc_rec->cs;
loc = strncpy(loc, GET_LOCALE_NAME(idx), 5);
if (loc[2] == '_') {
diff --git a/ldso/include/dl-string.h b/ldso/include/dl-string.h
index 6cc76dbf9..4a66161e0 100644
--- a/ldso/include/dl-string.h
+++ b/ldso/include/dl-string.h
@@ -103,7 +103,7 @@ static __always_inline char * _dl_strstr(const char *s1, const char
*s2)
do {
if (!*p)
- return (char *) s1;;
+ return (char *) s1;
if (*p == *s) {
++p;
++s;
diff --git a/libc/misc/time/time.c b/libc/misc/time/time.c
index cd189169a..0f7c6a33f 100644
--- a/libc/misc/time/time.c
+++ b/libc/misc/time/time.c
@@ -1311,7 +1311,7 @@ ISO_LOOP:
j = (i & 128) ? 100: 12;
if (i & 64) {
- field_val /= j;;
+ field_val /= j;
}
if (i & 32) {
field_val %= j;
diff --git a/libc/string/strcasestr.c b/libc/string/strcasestr.c
index 3334086bf..8f57cc0a3 100644
--- a/libc/string/strcasestr.c
+++ b/libc/string/strcasestr.c
@@ -16,7 +16,7 @@ char *strcasestr(const char *s1, const char *s2)
#if 1
do {
if (!*p) {
- return (char *) s1;;
+ return (char *) s1;
}
if ((*p == *s)
|| (tolower(*((unsigned char *)p)) == tolower(*((unsigned char *)s)))
diff --git a/libc/string/strstr.c b/libc/string/strstr.c
index 7e2a64e7d..bf56b9c12 100644
--- a/libc/string/strstr.c
+++ b/libc/string/strstr.c
@@ -22,7 +22,7 @@ Wchar *Wstrstr(const Wchar *s1, const Wchar *s2)
do {
if (!*p) {
- return (Wchar *) s1;;
+ return (Wchar *) s1;
}
if (*p == *s) {
++p;
diff --git a/libc/unistd/sysconf.c b/libc/unistd/sysconf.c
index 172794e9c..d04705abb 100644
--- a/libc/unistd/sysconf.c
+++ b/libc/unistd/sysconf.c
@@ -46,7 +46,7 @@
long int get_phys_pages(void)
{
struct sysinfo si;
- int ps = getpagesize();;
+ int ps = getpagesize();
sysinfo(&si);
@@ -59,7 +59,7 @@ long int get_phys_pages(void)
long int get_avphys_pages(void)
{
struct sysinfo si;
- int ps = getpagesize();;
+ int ps = getpagesize();
sysinfo(&si);
--
2.43.0
Show replies by date
Hi Marcus,
Marcus Haehnel wrote,
While they are not a problem per-se they cause issues
with some tooling
(such as clang coverage) and are confusing to the reader.
Thanks, applied and pushed,
best regards
Waldemar