devel

devel@uclibc-ng.org

3 participants
1149 discussions

by Yann Sionneau

This patchset only contains harmless warning fixes. That's a first effort for code cleanup. Yann Sionneau (6): Fix unused variable warning in dl-startup.c Fix warning about missing const qualifier Fix warning about macro redefinition Fix warning due to unused variable in strlen Fix warning due to relaxed function declaration prototype Fix warning due to unused label in NPTL ldso/ldso/dl-startup.c | 6 ++++-- libc/misc/fnmatch/fnmatch_loop.c | 4 ++-- libc/misc/internals/tempname.c | 12 ++++++------ libc/string/generic/strlen.c | 21 ++------------------- libintl/libintl.c | 2 +- libpthread/nptl/allocatestack.c | 2 ++ 6 files changed, 17 insertions(+), 30 deletions(-) -- 2.17.1

4 years, 5 months

[PATCH 0/2] Fix compilation errors

by Damien Le Moal

The two patches of this series each fix a compilation error found with buildroot for a RISC-V 64bits NOMMU static-only toolchain. Comments are welcome. Damien Le Moal (2): utils/getconf: Fix compilation error librt: avoid compilation error librt/clock_nanosleep.c | 5 +++-- utils/getconf.c | 20 +++++++++++++++++--- 2 files changed, 20 insertions(+), 5 deletions(-) -- 2.26.2

4 years, 5 months

[PATCH 0/1] Fix missing Feature Test Macro check in common stat.h

by Yann Sionneau

This is a touchy change since it touches a common header. This needs a thorough review in order not to break something. But for the record glibc only tests for __USE_XOPEN2K8 and musl does not test for anything at all and directly uses timespec fields. glibc: https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/ge… musl: https://git.musl-libc.org/cgit/musl/tree/arch/aarch64/bits/stat.h Yann Sionneau (1): Fix memory corruption due to struct stat field libc/sysdeps/linux/common-generic/bits/stat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1

4 years, 5 months

[PATCH] ldso: Fix pointer cast warning

by Yann Sionneau

Fixes the following compilation warning for 64-bit arch with TLS support: CC ldso/libdl/libdl.oS ldso/libdl/libdl.c: In function 'do_dlsym': ldso/libdl/libdl.c:739:59: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ret = _dl_tls_symaddr ((struct link_map *)sym_ref.tpnt, (Elf32_Addr)ret); ^ --- ldso/libdl/libdl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ldso/libdl/libdl.c b/ldso/libdl/libdl.c index ac0acd504..37c4a876e 100644 --- a/ldso/libdl/libdl.c +++ b/ldso/libdl/libdl.c @@ -187,7 +187,7 @@ static const char *const dl_error_names[] = { */ static void * internal_function -_dl_tls_symaddr(struct link_map *map, const Elf32_Addr st_value) +_dl_tls_symaddr(struct link_map *map, const ElfW(Addr) st_value) { # ifndef DONT_USE_TLS_INDEX tls_index tmp = @@ -736,7 +736,7 @@ static void *do_dlsym(void *vhandle, const char *name, void *caller_address) if (sym_ref.sym && (ELF_ST_TYPE(sym_ref.sym->st_info) == STT_TLS) && (sym_ref.tpnt)) { /* The found symbol is a thread-local storage variable. Return its address for the current thread. */ - ret = _dl_tls_symaddr ((struct link_map *)sym_ref.tpnt, (Elf32_Addr)ret); + ret = _dl_tls_symaddr ((struct link_map *)sym_ref.tpnt, (ElfW(Addr))ret); } #endif -- 2.17.1

4 years, 6 months

[PATCH 1/1] Add {name, open}_to_handle_at() implementation

by Petr Vorel

copied from musl 1.2.1. Signed-off-by: Petr Vorel <petr.vorel(a)gmail.com> --- Hi, these are new dependencies for iproute2. Kind regards, Petr include/fcntl.h | 12 +++++++ libc/sysdeps/linux/common/Makefile.in | 2 ++ libc/sysdeps/linux/common/name_to_handle_at.c | 36 +++++++++++++++++++ libc/sysdeps/linux/common/open_by_handle_at.c | 34 ++++++++++++++++++ 4 files changed, 84 insertions(+) create mode 100644 libc/sysdeps/linux/common/name_to_handle_at.c create mode 100644 libc/sysdeps/linux/common/open_by_handle_at.c diff --git a/include/fcntl.h b/include/fcntl.h index e8a781f28..02d4b0110 100644 --- a/include/fcntl.h +++ b/include/fcntl.h @@ -281,6 +281,18 @@ extern int fallocate64 (int __fd, int __mode, __off64_t __offset, __off64_t __le # endif #endif +#if (defined __UCLIBC_LINUX_SPECIFIC__ && defined __USE_GNU) +struct file_handle { + unsigned handle_bytes; + int handle_type; + unsigned char f_handle[]; +}; + +int name_to_handle_at(int dirfd, const char *pathname, + struct file_handle *handle, int *mount_id, int flags); +int open_by_handle_at(int mount_fd, struct file_handle *handle, int flags); +#endif + __END_DECLS #endif /* fcntl.h */ diff --git a/libc/sysdeps/linux/common/Makefile.in b/libc/sysdeps/linux/common/Makefile.in index f114a5bd1..9562de52c 100644 --- a/libc/sysdeps/linux/common/Makefile.in +++ b/libc/sysdeps/linux/common/Makefile.in @@ -32,6 +32,8 @@ CSRC-$(UCLIBC_LINUX_SPECIFIC) += \ iopl.c \ modify_ldt.c \ module.c \ + name_to_handle_at.c \ + open_by_handle_at.c \ personality.c \ pipe2.c \ ppoll.c \ diff --git a/libc/sysdeps/linux/common/name_to_handle_at.c b/libc/sysdeps/linux/common/name_to_handle_at.c new file mode 100644 index 000000000..20c67cbca --- /dev/null +++ b/libc/sysdeps/linux/common/name_to_handle_at.c @@ -0,0 +1,36 @@ +/* + * Copyright © 2005-2020 Rich Felker, et al. + * + * Permission is hereby granted, free of charge, to any person obtaining + * a copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sublicense, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * Imported from musl C library + */ + +#include <sys/syscall.h> + +#ifdef __NR_open_by_handle_at +#include <fcntl.h> +int name_to_handle_at(int dirfd, const char *pathname, + struct file_handle *handle, int *mount_id, int flags) +{ + return INLINE_SYSCALL(name_to_handle_at, 5, dirfd, pathname, handle, + mount_id, flags); +} +#endif diff --git a/libc/sysdeps/linux/common/open_by_handle_at.c b/libc/sysdeps/linux/common/open_by_handle_at.c new file mode 100644 index 000000000..5e65648a6 --- /dev/null +++ b/libc/sysdeps/linux/common/open_by_handle_at.c @@ -0,0 +1,34 @@ +/* + * Copyright © 2005-2020 Rich Felker, et al. + * + * Permission is hereby granted, free of charge, to any person obtaining + * a copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sublicense, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * Imported from musl C library + */ + +#include <sys/syscall.h> + +#ifdef __NR_open_by_handle_at +#include <fcntl.h> +int open_by_handle_at(int mount_fd, struct file_handle *handle, int flags) +{ + return INLINE_SYSCALL(open_by_handle_at, 3, mount_fd, handle, flags); +} +#endif -- 2.28.0

4 years, 6 months

__riscv_flush_icache() implementation missing in RISC-V port

by Thomas Petazzoni

Hello, The __builtin___clear_cache() GCC builtin is used for example by the libffi library RISC-V port to flush the I-Cache after modifying the code. On RISC-V the internal implementation of this GCC builtin assumes the C library provides a __riscv_flush_icache() function. glibc implements this function in sysdeps/unix/sysv/linux/riscv/flush-icache.c. Due to the lack of this function in uClibc-ng, building anything that links against libffi fails, for example, libglib2: FAILED: gobject/gobject-query /home/test/autobuild/run/instance-0/output-1/host/bin/riscv64-buildroot-linux-uclibc-gcc -o gobject/gobject-query gobject/gobject-query.p/gobject-query.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -Wl,--start-group glib/libglib-2.0.so.0.6400.4 gobject/libgobject-2.0.so.0.6400.4 -Wl,--end-group -pthread '-Wl,-rpath,$ORIGIN/../glib:$ORIGIN/' -Wl,-rpath-link,/home/test/autobuild/run/instance-0/output-1/build/libglib2-2.64.4/build/glib -Wl,-rpath-link,/home/test/autobuild/run/instance-0/output-1/build/libglib2-2.64.4/build/gobject /home/test/autobuild/run/instance-0/output-1/host/lib/gcc/riscv64-buildroot-linux-uclibc/9.3.0/../../../../riscv64-buildroot-linux-uclibc/bin/ld: /home/test/autobuild/run/instance-0/output-1/host/riscv64-buildroot-linux-uclibc/sysroot/usr/lib64/libffi.so.7: undefined reference to `__riscv_flush_icache' collect2: error: ld returned 1 exit status Would it be possible to implement this function in uClibc-ng ? Best regards, Thomas Petazzoni -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

4 years, 7 months

An issue with sys/random.h

by akater

Recently, I couldn't build GNU Emacs on a uclibc-ng-1.0.33 system. The issue eventually went to Gnulib; they pushed a workaround but concluded it's a uClibc issue. Their summary, as presented in the patch in the message below: > On uClibc, <sys/random.h> assumes prior inclusion of <stddef.h>. For details, see https://lists.gnu.org/archive/html/bug-gnulib/2020-08/msg00098.html and further down the thread. I was advised to report this to you so here it goes.

4 years, 7 months

Are statically linked binaries supported with NPTL?

by Evan T Mesterhazy

I read in a paper <https://www.kernel.org/doc/ols/2006/ols2006v1-pages-409-420.pdf> from 2006 on kernel.org: > It should also be noted that statically linked binaries using TLS/NPTL are not currently supported by uClibc. Is this still the case for uClibc-ng in 2020? Thank you, Evan -- etm2131(a)columbia.edu

4 years, 7 months

{name, open}_to_handle_at() not implemented on uclibc-ng (iproute2 5.8.0 dependency)

by Petr Vorel

Hi, does anybody plan to implement {name,open}_to_handle_at() in uclibc-ng? These are new dependencies for iproute2. 2 years ago it was just removed from bits/fcntl.h in 42ff2bba8 ("uClibc-ng does not implement name_to_handle_at"). Kind regards, Petr

4 years, 7 months

Fix static linking with GCC-10

by Lance Fredrickson

Starting with GCC-10 multiple definitions of global variables by will be rejected. https://gcc.gnu.org/gcc-10/porting_to.html This fixes multiple definitions of _dl_pagesize and _dl_tls_static_size while attempting static linking. Of course this only occurs when compiling something that requires these symbols. First patch submission so hopefully all done correctly. thanks, Lance Fredrickson

4 years, 7 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

devel