- devel - example.com

{name, open}_to_handle_at() not implemented on uclibc-ng (iproute2 5.8.0 dependency)
by Petr Vorel 13 Aug '20

13 Aug '20

Hi, does anybody plan to implement {name,open}_to_handle_at() in uclibc-ng? These are new dependencies for iproute2. 2 years ago it was just removed from bits/fcntl.h in 42ff2bba8 ("uClibc-ng does not implement name_to_handle_at"). Kind regards, Petr

1 0

Fix static linking with GCC-10
by Lance Fredrickson 11 Aug '20

11 Aug '20

Starting with GCC-10 multiple definitions of global variables by will be rejected. https://gcc.gnu.org/gcc-10/porting_to.html This fixes multiple definitions of _dl_pagesize and _dl_tls_static_size while attempting static linking. Of course this only occurs when compiling something that requires these symbols. First patch submission so hopefully all done correctly. thanks, Lance Fredrickson

2 1

[PATCH] xtensa: add exclusive access support
by Max Filippov 11 Aug '20

11 Aug '20

Add XCHAL definitions for S32C1I and EXCLUSIVE options to xtensa-config.h, include it in places that implement atomic operations and add implementations with exclusive access option opcodes. Signed-off-by: Max Filippov <jcmvbkbc(a)gmail.com> --- libc/sysdeps/linux/xtensa/bits/atomic.h | 128 ++++++++++++++++++ .../sysdeps/linux/xtensa/bits/xtensa-config.h | 6 + .../linuxthreads/sysdeps/xtensa/pt-machine.h | 56 ++++++++ .../nptl/sysdeps/xtensa/pthread_spin_lock.S | 16 +++ .../sysdeps/xtensa/pthread_spin_trylock.S | 17 +++ 5 files changed, 223 insertions(+) diff --git a/libc/sysdeps/linux/xtensa/bits/atomic.h b/libc/sysdeps/linux/xtensa/bits/atomic.h index efc027d1ac25..18b809998054 100644 --- a/libc/sysdeps/linux/xtensa/bits/atomic.h +++ b/libc/sysdeps/linux/xtensa/bits/atomic.h @@ -18,6 +18,7 @@ #ifndef _BITS_ATOMIC_H #define _BITS_ATOMIC_H 1 +#include <bits/xtensa-config.h> #include <inttypes.h> typedef int32_t atomic32_t; @@ -50,6 +51,128 @@ typedef uintmax_t uatomic_max_t; #define __arch_compare_and_exchange_bool_16_rel(mem, newval, oldval) \ (abort (), 0) +#if XCHAL_HAVE_EXCLUSIVE + +/* Atomically store NEWVAL in *MEM if *MEM is equal to OLDVAL. + Return the old *MEM value. */ + +#define __arch_compare_and_exchange_val_32_acq(mem, newval, oldval) \ + ({__typeof__(*(mem)) __tmp, __value; \ + __asm__ __volatile__( \ + " memw \n" \ + "1: l32ex %0, %2 \n" \ + " bne %0, %4, 2f \n" \ + " mov %1, %3 \n" \ + " s32ex %1, %2 \n" \ + " getex %1 \n" \ + " beqz %1, 1b \n" \ + " memw \n" \ + "2: \n" \ + : "=&a" (__value), "=&a" (__tmp) \ + : "a" (mem), "a" (newval), "a" (oldval) \ + : "memory" ); \ + __value; \ + }) + +/* Atomically store NEWVAL in *MEM if *MEM is equal to OLDVAL. + Return zero if *MEM was changed or non-zero if no exchange happened. */ + +#define __arch_compare_and_exchange_bool_32_acq(mem, newval, oldval) \ + ({__typeof__(*(mem)) __tmp, __value; \ + __asm__ __volatile__( \ + " memw \n" \ + "1: l32ex %0, %2 \n" \ + " sub %0, %4, %0 \n" \ + " bnez %0, 2f \n" \ + " mov %1, %3 \n" \ + " s32ex %1, %2 \n" \ + " getex %1 \n" \ + " beqz %1, 1b \n" \ + " movi %0, 0 \n" \ + " memw \n" \ + "2: \n" \ + : "=&a" (__value), "=&a" (__tmp) \ + : "a" (mem), "a" (newval), "a" (oldval) \ + : "memory" ); \ + __value != 0; \ + }) + +/* Store NEWVALUE in *MEM and return the old value. */ + +#define __arch_exchange_32_acq(mem, newval) \ + ({__typeof__(*(mem)) __tmp, __value; \ + __asm__ __volatile__( \ + " memw \n" \ + "1: l32ex %0, %2 \n" \ + " mov %1, %3 \n" \ + " s32ex %1, %2 \n" \ + " getex %1 \n" \ + " beqz %1, 1b \n" \ + " memw \n" \ + : "=&a" (__value), "=&a" (__tmp) \ + : "a" (mem), "a" (newval) \ + : "memory" ); \ + __value; \ + }) + +/* Add VALUE to *MEM and return the old value of *MEM. */ + +#define __arch_atomic_exchange_and_add_32(mem, value) \ + ({__typeof__(*(mem)) __tmp, __value; \ + __asm__ __volatile__( \ + " memw \n" \ + "1: l32ex %0, %2 \n" \ + " add %1, %0, %3 \n" \ + " s32ex %1, %2 \n" \ + " getex %1 \n" \ + " beqz %1, 1b \n" \ + " memw \n" \ + : "=&a" (__value), "=&a" (__tmp) \ + : "a" (mem), "a" (value) \ + : "memory" ); \ + __value; \ + }) + +/* Subtract VALUE from *MEM and return the old value of *MEM. */ + +#define __arch_atomic_exchange_and_sub_32(mem, value) \ + ({__typeof__(*(mem)) __tmp, __value; \ + __asm__ __volatile__( \ + " memw \n" \ + "1: l32ex %0, %2 \n" \ + " sub %1, %0, %3 \n" \ + " s32ex %1, %2 \n" \ + " getex %1 \n" \ + " beqz %1, 1b \n" \ + " memw \n" \ + : "=&a" (__value), "=&a" (__tmp) \ + : "a" (mem), "a" (value) \ + : "memory" ); \ + __tmp; \ + }) + +/* Decrement *MEM if it is > 0, and return the old value. */ + +#define __arch_atomic_decrement_if_positive_32(mem) \ + ({__typeof__(*(mem)) __tmp, __value; \ + __asm__ __volatile__( \ + " memw \n" \ + "1: l32ex %0, %2 \n" \ + " blti %0, 1, 2f \n" \ + " addi %1, %0, -1 \n" \ + " s32ex %1, %2 \n" \ + " getex %1 \n" \ + " beqz %1, 1b \n" \ + " memw \n" \ + "2: \n" \ + : "=&a" (__value), "=&a" (__tmp) \ + : "a" (mem) \ + : "memory" ); \ + __value; \ + }) + +#elif XCHAL_HAVE_S32C1I + /* Atomically store NEWVAL in *MEM if *MEM is equal to OLDVAL. Return the old *MEM value. */ @@ -156,6 +279,11 @@ typedef uintmax_t uatomic_max_t; __value; \ }) +#else + +#error No hardware atomic operations + +#endif /* These are the preferred public interfaces: */ diff --git a/libc/sysdeps/linux/xtensa/bits/xtensa-config.h b/libc/sysdeps/linux/xtensa/bits/xtensa-config.h index 2e60af936e6e..b99928b1e058 100644 --- a/libc/sysdeps/linux/xtensa/bits/xtensa-config.h +++ b/libc/sysdeps/linux/xtensa/bits/xtensa-config.h @@ -43,4 +43,10 @@ #undef XCHAL_NUM_AREGS #define XCHAL_NUM_AREGS 64 +#undef XCHAL_HAVE_S32C1I +#define XCHAL_HAVE_S32C1I 1 + +#undef XCHAL_HAVE_EXCLUSIVE +#define XCHAL_HAVE_EXCLUSIVE 0 + #endif /* !XTENSA_CONFIG_H */ diff --git a/libpthread/linuxthreads/sysdeps/xtensa/pt-machine.h b/libpthread/linuxthreads/sysdeps/xtensa/pt-machine.h index 82d9b540c611..0b7f58b635f3 100644 --- a/libpthread/linuxthreads/sysdeps/xtensa/pt-machine.h +++ b/libpthread/linuxthreads/sysdeps/xtensa/pt-machine.h @@ -21,6 +21,7 @@ #ifndef _PT_MACHINE_H #define _PT_MACHINE_H 1 +#include <bits/xtensa-config.h> #include <sys/syscall.h> #include <asm/unistd.h> @@ -34,6 +35,55 @@ extern long int testandset (int *spinlock); extern int __compare_and_swap (long int *p, long int oldval, long int newval); +#if XCHAL_HAVE_EXCLUSIVE + +/* Spinlock implementation; required. */ +PT_EI long int +testandset (int *spinlock) +{ + unsigned long tmp; + __asm__ volatile ( +" memw \n" +"1: l32ex %0, %1 \n" +" bnez %0, 2f \n" +" movi %0, 1 \n" +" s32ex %0, %1 \n" +" getex %0 \n" +" beqz %0, 1b \n" +" movi %0, 0 \n" +" memw \n" +"2: \n" + : "=&a" (tmp) + : "a" (spinlock) + : "memory" + ); + return tmp; +} + +PT_EI int +__compare_and_swap (long int *p, long int oldval, long int newval) +{ + unsigned long tmp; + unsigned long value; + __asm__ volatile ( +" memw \n" +"1: l32ex %0, %2 \n" +" bne %0, %4, 2f \n" +" mov %1, %3 \n" +" s32ex %1, %2 \n" +" getex %1 \n" +" beqz %1, 1b \n" +" memw \n" +"2: \n" + : "=&a" (tmp), "=&a" (value) + : "a" (p), "a" (newval), "a" (oldval) + : "memory" ); + + return tmp == oldval; +} + +#elif XCHAL_HAVE_S32C1I + /* Spinlock implementation; required. */ PT_EI long int testandset (int *spinlock) @@ -71,6 +121,12 @@ __compare_and_swap (long int *p, long int oldval, long int newval) return tmp == oldval; } +#else + +#error No hardware atomic operations + +#endif + /* Get some notion of the current stack. Need not be exactly the top of the stack, just something somewhere in the current frame. */ #define CURRENT_STACK_FRAME __builtin_frame_address (0) diff --git a/libpthread/nptl/sysdeps/xtensa/pthread_spin_lock.S b/libpthread/nptl/sysdeps/xtensa/pthread_spin_lock.S index 3386afae9e58..3faac36da12b 100644 --- a/libpthread/nptl/sysdeps/xtensa/pthread_spin_lock.S +++ b/libpthread/nptl/sysdeps/xtensa/pthread_spin_lock.S @@ -15,16 +15,32 @@ License along with the GNU C Library; see the file COPYING.LIB. If not, see <http://www.gnu.org/licenses/>. */ +#include <bits/xtensa-config.h> #include <sysdep.h> .text ENTRY (pthread_spin_lock) +#if XCHAL_HAVE_EXCLUSIVE + memw +1: l32ex a3, a2 + bnez a3, 1b + movi a3, 1 + s32ex a3, a2 + getex a3 + beqz a3, 1b + memw +#elif XCHAL_HAVE_S32C1I movi a3, 0 wsr a3, scompare1 movi a3, 1 1: s32c1i a3, a2, 0 bnez a3, 1b +#else + +#error No hardware atomic operations + +#endif movi a2, 0 abi_ret diff --git a/libpthread/nptl/sysdeps/xtensa/pthread_spin_trylock.S b/libpthread/nptl/sysdeps/xtensa/pthread_spin_trylock.S index 72b2dda92310..0669682ec9bd 100644 --- a/libpthread/nptl/sysdeps/xtensa/pthread_spin_trylock.S +++ b/libpthread/nptl/sysdeps/xtensa/pthread_spin_trylock.S @@ -17,15 +17,32 @@ #define _ERRNO_H 1 #include <bits/errno.h> +#include <bits/xtensa-config.h> #include <sysdep.h> .text ENTRY (pthread_spin_trylock) +#if XCHAL_HAVE_EXCLUSIVE + memw + l32ex a3, a2 + bnez a3, 1f + movi a3, 1 + s32ex a3, a2 + getex a3 + addi a3, a3, -1 + memw +1: +#elif XCHAL_HAVE_S32C1I movi a3, 0 wsr a3, scompare1 movi a3, 1 s32c1i a3, a2, 0 +#else + +#error No hardware atomic operations + +#endif movi a2, EBUSY moveqz a2, a3, a3 -- 2.20.1

2 1

[PATCH] xtensa: relax memory constraint in atomic assembly
by Max Filippov 11 Aug '20

11 Aug '20

Replace "a" constraints with "+m" to avoid forcing atomic variable address into a register and let the compiler use non-zero offset in load/store opcodes. Signed-off-by: Max Filippov <jcmvbkbc(a)gmail.com> --- libc/sysdeps/linux/xtensa/bits/atomic.h | 49 +++++++++---------- .../linuxthreads/sysdeps/xtensa/pt-machine.h | 15 +++--- 2 files changed, 31 insertions(+), 33 deletions(-) diff --git a/libc/sysdeps/linux/xtensa/bits/atomic.h b/libc/sysdeps/linux/xtensa/bits/atomic.h index b2be547f03e9..efc027d1ac25 100644 --- a/libc/sysdeps/linux/xtensa/bits/atomic.h +++ b/libc/sysdeps/linux/xtensa/bits/atomic.h @@ -56,16 +56,16 @@ typedef uintmax_t uatomic_max_t; #define __arch_compare_and_exchange_val_32_acq(mem, newval, oldval) \ ({__typeof__(*(mem)) __tmp, __value; \ __asm__ __volatile__( \ - "1: l32i %1, %2, 0 \n" \ + "1: l32i %1, %2 \n" \ " bne %1, %4, 2f \n" \ " wsr %1, SCOMPARE1 \n" \ " mov %0, %1 \n" \ " mov %1, %3 \n" \ - " s32c1i %1, %2, 0 \n" \ + " s32c1i %1, %2 \n" \ " bne %0, %1, 1b \n" \ "2: \n" \ - : "=&a" (__value), "=&a" (__tmp) \ - : "a" (mem), "a" (newval), "a" (oldval) \ + : "=&a" (__value), "=&a" (__tmp), "+m" (*(mem)) \ + : "a" (newval), "a" (oldval) \ : "memory" ); \ __tmp; \ }) @@ -76,17 +76,17 @@ typedef uintmax_t uatomic_max_t; #define __arch_compare_and_exchange_bool_32_acq(mem, newval, oldval) \ ({__typeof__(*(mem)) __tmp, __value; \ __asm__ __volatile__( \ - "1: l32i %0, %2, 0 \n" \ + "1: l32i %0, %2 \n" \ " sub %1, %4, %0 \n" \ " bnez %1, 2f \n" \ " wsr %0, SCOMPARE1 \n" \ " mov %1, %3 \n" \ - " s32c1i %1, %2, 0 \n" \ + " s32c1i %1, %2 \n" \ " bne %0, %1, 1b \n" \ " movi %1, 0 \n" \ "2: \n" \ - : "=&a" (__value), "=&a" (__tmp) \ - : "a" (mem), "a" (newval), "a" (oldval) \ + : "=&a" (__value), "=&a" (__tmp), "+m" (*(mem)) \ + : "a" (newval), "a" (oldval) \ : "memory" ); \ __tmp != 0; \ }) @@ -96,13 +96,13 @@ typedef uintmax_t uatomic_max_t; #define __arch_exchange_32_acq(mem, newval) \ ({__typeof__(*(mem)) __tmp, __value; \ __asm__ __volatile__( \ - "1: l32i %0, %2, 0 \n" \ + "1: l32i %0, %2 \n" \ " wsr %0, SCOMPARE1 \n" \ " mov %1, %3 \n" \ - " s32c1i %1, %2, 0 \n" \ + " s32c1i %1, %2 \n" \ " bne %0, %1, 1b \n" \ - : "=&a" (__value), "=&a" (__tmp) \ - : "a" (mem), "a" (newval) \ + : "=&a" (__value), "=&a" (__tmp), "+m" (*(mem)) \ + : "a" (newval) \ : "memory" ); \ __tmp; \ }) @@ -112,13 +112,13 @@ typedef uintmax_t uatomic_max_t; #define __arch_atomic_exchange_and_add_32(mem, value) \ ({__typeof__(*(mem)) __tmp, __value; \ __asm__ __volatile__( \ - "1: l32i %0, %2, 0 \n" \ + "1: l32i %0, %2 \n" \ " wsr %0, SCOMPARE1 \n" \ " add %1, %0, %3 \n" \ - " s32c1i %1, %2, 0 \n" \ + " s32c1i %1, %2 \n" \ " bne %0, %1, 1b \n" \ - : "=&a" (__value), "=&a" (__tmp) \ - : "a" (mem), "a" (value) \ + : "=&a" (__value), "=&a" (__tmp), "+m" (*(mem)) \ + : "a" (value) \ : "memory" ); \ __tmp; \ }) @@ -128,13 +128,13 @@ typedef uintmax_t uatomic_max_t; #define __arch_atomic_exchange_and_sub_32(mem, value) \ ({__typeof__(*(mem)) __tmp, __value; \ __asm__ __volatile__( \ - "1: l32i %0, %2, 0 \n" \ + "1: l32i %0, %2 \n" \ " wsr %0, SCOMPARE1 \n" \ " sub %1, %0, %3 \n" \ - " s32c1i %1, %2, 0 \n" \ + " s32c1i %1, %2 \n" \ " bne %0, %1, 1b \n" \ - : "=&a" (__value), "=&a" (__tmp) \ - : "a" (mem), "a" (value) \ + : "=&a" (__value), "=&a" (__tmp), "+m" (*(mem)) \ + : "a" (value) \ : "memory" ); \ __tmp; \ }) @@ -144,16 +144,15 @@ typedef uintmax_t uatomic_max_t; #define __arch_atomic_decrement_if_positive_32(mem) \ ({__typeof__(*(mem)) __tmp, __value; \ __asm__ __volatile__( \ - "1: l32i %0, %2, 0 \n" \ + "1: l32i %0, %2 \n" \ " blti %0, 1, 2f \n" \ " wsr %0, SCOMPARE1 \n" \ " addi %1, %0, -1 \n" \ - " s32c1i %1, %2, 0 \n" \ + " s32c1i %1, %2 \n" \ " bne %0, %1, 1b \n" \ "2: \n" \ - : "=&a" (__value), "=&a" (__tmp) \ - : "a" (mem) \ - : "memory" ); \ + : "=&a" (__value), "=&a" (__tmp), "+m" (*(mem)) \ + :: "memory" ); \ __value; \ }) diff --git a/libpthread/linuxthreads/sysdeps/xtensa/pt-machine.h b/libpthread/linuxthreads/sysdeps/xtensa/pt-machine.h index 2c68ddfb5fe1..82d9b540c611 100644 --- a/libpthread/linuxthreads/sysdeps/xtensa/pt-machine.h +++ b/libpthread/linuxthreads/sysdeps/xtensa/pt-machine.h @@ -43,10 +43,9 @@ testandset (int *spinlock) " movi %0, 0 \n" " wsr %0, SCOMPARE1 \n" " movi %0, 1 \n" -" s32c1i %0, %1, 0 \n" - : "=&a" (tmp) - : "a" (spinlock) - : "memory" +" s32c1i %0, %1 \n" + : "=&a" (tmp), "+m" (*spinlock) + :: "memory" ); return tmp; } @@ -57,16 +56,16 @@ __compare_and_swap (long int *p, long int oldval, long int newval) unsigned long tmp; unsigned long value; __asm__ volatile ( -"1: l32i %0, %2, 0 \n" +"1: l32i %0, %2 \n" " bne %0, %4, 2f \n" " wsr %0, SCOMPARE1 \n" " mov %1, %0 \n" " mov %0, %3 \n" -" s32c1i %0, %2, 0 \n" +" s32c1i %0, %2 \n" " bne %1, %0, 1b \n" "2: \n" - : "=&a" (tmp), "=&a" (value) - : "a" (p), "a" (newval), "a" (oldval) + : "=&a" (tmp), "=&a" (value), "+m" (*p) + : "a" (newval), "a" (oldval) : "memory" ); return tmp == oldval; -- 2.20.1

2 1

uClibc-ng broken on hsdk
by Waldemar Brodkorb 04 Aug '20

04 Aug '20

Hi Alexey, Hi Vineet, is uClibc-ng 1.0.34 broken on Linux kernel 4.19.136? I am using gcc 9.3.0 and binutils 2.35. I get following stacktrace: [ 9.667903] Starting Linux (built with OpenADK). [ 9.673796] Freeing unused kernel memory: 592K [ 9.678323] This architecture does not have kernel memory protection. [ 9.684992] Run /sbin/init as init process [ 9.693619] potentially unexpected fatal signal 11. [ 9.698600] Path: /bin/busybox [ 9.701967] CPU: 2 PID: 1 Comm: init Not tainted 4.19.136-1 #2 [ 9.707882] [ 9.707882] [ECR ]: 0x00050200 => Invalid Write @ 0x00000000 by insn @ 0x2000181a [ 9.717373] [EFA ]: 0x00000000 [ 9.717373] [BLINK ]: 0x20001792 [ 9.717373] [ERET ]: 0x2000181a [ 9.727392] @off 0x181a in [/lib/ld-uClibc-1.0.34.so] [ 9.727392] VMA: 0x20000000 to 0x20008000 [ 9.737355] [STAT32]: 0x80081082 : IE U [ 9.741969] BTA: 0x20001792 SP: 0x5f8bdb9c FP: 0x5f8bdd2c [ 9.747648] LPS: 0x00000010 LPE: 0x00000080 LPC: 0x00000000 [ 9.753784] r00: 0x20005b64 r01: 0x00000025 r02: 0xffffffff [ 9.753784] r03: 0x00000022 r04: 0x00000000 r05: 0x00000000 [ 9.753784] r06: 0x00000000 r07: 0x00000000 r08: 0x000000de [ 9.753784] r09: 0x0000000c r10: 0x00000001 r11: 0x00000000 [ 9.753784] r12: 0x20001792 r13: 0x00000000 r14: 0x20005b64 [ 9.753784] r15: 0x2000a070 r16: 0x5f8bddf8 r17: 0x5f8bdf2c [ 9.753784] r18: 0x2000a070 r19: 0x00000000 r20: 0x5f8bddf8 [ 9.753784] r21: 0x00000000 r22: 0x00000000 r23: 0x00000000 [ 9.753784] r24: 0x5f8bdc18 r25: 0x00000000 [ 9.753784] [ 9.753784] [ 9.807098] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b [ 9.807098] With kernel 5.4.53 it just hangs on this line here: [ 2.579235] NET: Registered protocol family 1 I am using initramfs with piggyback loaded from mmc card. best regards Waldemar

2 1

pthread support for aarch64
by Robert Hentsch-Jesse 24 Jul '20

24 Jul '20

Hello all, with current version 1.0.34, uclibc-ng has support for aarch64. Are there any plans or activities to provide support for POSIX threads for aarch64 also? Best regards, Robert Hentsch-Jesse ....................................................................................... PHOENIX CONTACT Cyber Security GmbH Richard-Willstätter-Straße 6 D-12489 Berlin Register Court: AG Charlottenburg, HR B 202908 Geschäftsführer/General Manager: Kilian Golm

3 2

How to link a prebuilt object file in uclibc-ng?
by Ilias Stamatis 15 Jul '20

15 Jul '20

Hello, I'm re-sending this e-mail because I think it wasn't sent the first time since I wasn't subscribed to the list. If you got it twice sorry for the inconvenience. I want to modify uclibc-ng and make it do some calls to my library when system calls are invoked. My small library consists of a single prebuilt object file and a header file which I don't know how to statically link in uclibc-ng when I am building it. My makefile-hacking related skills are not exactly great. All I need is to call a couple of my library functions from inside the INLINE_SYSCALL_NCS macro: https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/tree/libc/sysdeps/linux/a… Could you give me some hints regarding which Makefiles I need to modify and how? Thanks a lot! Best Regards, Ilias Stamatis

2 1

doubts over defines of __USE_MISC and __DEFAULT_SOURCE
by Ed W 06 Jul '20

06 Jul '20

Hi, I'm having some troubles compiling zstd and the issue appears to revolve around the lack of "__USE_MISC" being declared. In glibc they declare __USE_MISC if there is defined __DEFAULT_SOURCE, see features.h:369 (ish): #if defined _DEFAULT_SOURCE # define __USE_MISC 1 #endif However, we don't declare this in uclibc_ng and seem to have some quite different handling around __DEFAULT_SOURCE I have zero idea what is supposed to be happening with these macros, so I don't feel qualified to suggest a solution, but it appears to cause problems for at least openrc and zstd now. Could someone please review these macros and if appropriate for uclibc_ng, please also define __USE_MISC for the case of __DEFAULT_SOURCE in features.h Thanks Ed W

1 2

[PATCH] Rename __unused struct members to include a namespace
by Ed W 06 Jul '20

06 Jul '20

Rename various spare fields in structs to include a namespace This should avoid accidental clashes with uses of the __unused symbol in upstream projects. eg currently it causes a compile error in dhcpcd 8.x and onwards due to their re-use of the __unused symbol as a macro Recommend that in general continue to convert generic names to include the __uclibc_ prefix to namespace them. This follows the style of glibc which does something equivalent signed-off-by: Ed Wildgoose <lists(a)wildgooses.com> diff -ur libc/sysdeps/linux/alpha/bits/kernel_stat.h libc/sysdeps/linux/alpha/bits/kernel_stat.h --- a/libc/sysdeps/linux/alpha/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/alpha/bits/kernel_stat.h 2020-06-11 16:34:02.009197215 +0000 @@ -39,7 +39,7 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - long __unused[3]; + long __uclibc_unused[3]; }; #endif /* _BITS_STAT_STRUCT_H */ diff -ur libc/sysdeps/linux/alpha/bits/stat.h libc/sysdeps/linux/alpha/bits/stat.h --- a/libc/sysdeps/linux/alpha/bits/stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/alpha/bits/stat.h 2020-06-11 16:34:02.009197215 +0000 @@ -89,7 +89,7 @@ __ST_TIME(a); /* Time of last access. */ __ST_TIME(m); /* Time of last modification. */ __ST_TIME(c); /* Time of last status change. */ - long __unused[3]; + long __uclibc_unused[3]; }; #ifdef __USE_LARGEFILE64 @@ -110,7 +110,7 @@ __ST_TIME(a); /* Time of last access. */ __ST_TIME(m); /* Time of last modification. */ __ST_TIME(c); /* Time of last status change. */ - long __unused[3]; + long __uclibc_unused[3]; }; #endif diff -ur libc/sysdeps/linux/arm/bits/kernel_stat.h libc/sysdeps/linux/arm/bits/kernel_stat.h --- a/libc/sysdeps/linux/arm/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/arm/bits/kernel_stat.h 2020-06-11 16:34:02.009197215 +0000 @@ -29,8 +29,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned long __unused4; - unsigned long __unused5; + unsigned long __uclibc_unused4; + unsigned long __uclibc_unused5; }; struct kernel_stat64 { diff -ur libc/sysdeps/linux/avr32/bits/kernel_stat.h libc/sysdeps/linux/avr32/bits/kernel_stat.h --- a/libc/sysdeps/linux/avr32/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/avr32/bits/kernel_stat.h 2020-06-11 16:34:02.009197215 +0000 @@ -20,8 +20,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned long __unused4; - unsigned long __unused5; + unsigned long __uclibc_unused4; + unsigned long __uclibc_unused5; }; struct kernel_stat64 { @@ -46,8 +46,8 @@ struct timespec st_mtim; struct timespec st_ctim; - unsigned long __unused1; - unsigned long __unused2; + unsigned long __uclibc_unused1; + unsigned long __uclibc_unused2; }; #endif /* _BITS_STAT_STRUCT_H */ diff -ur libc/sysdeps/linux/bfin/bits/kernel_stat.h libc/sysdeps/linux/bfin/bits/kernel_stat.h --- a/libc/sysdeps/linux/bfin/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/bfin/bits/kernel_stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -21,8 +21,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned long __unused4; - unsigned long __unused5; + unsigned long __uclibc_unused4; + unsigned long __uclibc_unused5; }; struct kernel_stat64 { diff -ur libc/sysdeps/linux/c6x/bits/kernel_stat.h libc/sysdeps/linux/c6x/bits/kernel_stat.h --- a/libc/sysdeps/linux/c6x/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/c6x/bits/kernel_stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -21,8 +21,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned int __unused4; - unsigned int __unused5; + unsigned int __uclibc_unused4; + unsigned int __uclibc_unused5; }; struct kernel_stat64 { @@ -41,8 +41,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned int __unused4; - unsigned int __unused5; + unsigned int __uclibc_unused4; + unsigned int __uclibc_unused5; }; #endif /* _BITS_STAT_STRUCT_H */ diff -ur libc/sysdeps/linux/common/bits/stat.h libc/sysdeps/linux/common/bits/stat.h --- a/libc/sysdeps/linux/common/bits/stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/common/bits/stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -83,8 +83,8 @@ unsigned long int st_ctimensec; /* Nsecs of last status change. */ #endif #ifndef __USE_FILE_OFFSET64 - unsigned long int __unused4; - unsigned long int __unused5; + unsigned long int __uclibc_unused4; + unsigned long int __uclibc_unused5; #else __ino64_t st_ino; /* File serial number. */ #endif diff -ur libc/sysdeps/linux/common-generic/bits/stat.h libc/sysdeps/linux/common-generic/bits/stat.h --- a/libc/sysdeps/linux/common-generic/bits/stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/common-generic/bits/stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -68,8 +68,8 @@ int st_ctime; /* Time of last status change. */ unsigned int st_ctime_nsec; #endif - unsigned int __unused4; - unsigned int __unused5; + unsigned int __uclibc_unused4; + unsigned int __uclibc_unused5; } __ARCH_64BIT_ALIGNMENT__; @@ -106,8 +106,8 @@ int st_ctime; /* Time of last status change. */ unsigned int st_ctime_nsec; # endif - unsigned int __unused4; - unsigned int __unused5; + unsigned int __uclibc_unused4; + unsigned int __uclibc_unused5; }; #endif diff -ur libc/sysdeps/linux/cris/bits/kernel_stat.h libc/sysdeps/linux/cris/bits/kernel_stat.h --- a/libc/sysdeps/linux/cris/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/cris/bits/kernel_stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -19,8 +19,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned long __unused4; - unsigned long __unused5; + unsigned long __uclibc_unused4; + unsigned long __uclibc_unused5; }; /* This matches struct kernel_stat64 in glibc2.1, hence the absolutely diff -ur libc/sysdeps/linux/csky/bits/kernel_stat.h libc/sysdeps/linux/csky/bits/kernel_stat.h --- a/libc/sysdeps/linux/csky/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/csky/bits/kernel_stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -34,8 +34,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned long __unused4; - unsigned long __unused5; + unsigned long __uclibc_unused4; + unsigned long __uclibc_unused5; }; struct kernel_stat64 { diff -ur libc/sysdeps/linux/frv/bits/kernel_stat.h libc/sysdeps/linux/frv/bits/kernel_stat.h --- a/libc/sysdeps/linux/frv/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/frv/bits/kernel_stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -38,7 +38,7 @@ struct timespec st_mtim; struct timespec st_ctim; - unsigned long long __unused4; + unsigned long long __uclibc_unused4; }; struct kernel_stat64 { @@ -68,7 +68,7 @@ struct timespec st_mtim; struct timespec st_ctim; - unsigned long long __unused4; + unsigned long long __uclibc_unused4; }; #endif /* _BITS_STAT_STRUCT_H */ diff -ur libc/sysdeps/linux/frv/bits/stat.h libc/sysdeps/linux/frv/bits/stat.h --- a/libc/sysdeps/linux/frv/bits/stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/frv/bits/stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -84,16 +84,16 @@ # define st_mtime st_mtim.tv_sec # define st_ctime st_ctim.tv_sec #else - unsigned long int __unused1; + unsigned long int __uclibc_unused1; __time_t st_atime; /* Time of last access. */ - unsigned long int __unused2; + unsigned long int __uclibc_unused2; __time_t st_mtime; /* Time of last modification. */ - unsigned long int __unused3; + unsigned long int __uclibc_unused3; __time_t st_ctime; /* Time of last status change. */ #endif - unsigned long long __unused4; + unsigned long long __uclibc_unused4; }; #ifdef __USE_LARGEFILE64 @@ -131,16 +131,16 @@ # define st_mtime st_mtim.tv_sec # define st_ctime st_ctim.tv_sec #else - unsigned long int __unused1; + unsigned long int __uclibc_unused1; __time_t st_atime; /* Time of last access. */ - unsigned long int __unused2; + unsigned long int __uclibc_unused2; __time_t st_mtime; /* Time of last modification. */ - unsigned long int __unused3; + unsigned long int __uclibc_unused3; __time_t st_ctime; /* Time of last status change. */ #endif - unsigned long long __unused4; + unsigned long long __uclibc_unused4; }; #endif diff -ur libc/sysdeps/linux/hppa/bits/kernel_stat.h libc/sysdeps/linux/hppa/bits/kernel_stat.h --- a/libc/sysdeps/linux/hppa/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/hppa/bits/kernel_stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -18,11 +18,11 @@ struct timespec st_ctim; int st_blksize; int st_blocks; - unsigned int __unused1; /* ACL stuff */ - unsigned int __unused2; /* network */ - ino_t __unused3; /* network */ - unsigned int __unused4; /* cnodes */ - unsigned short __unused5; /* netsite */ + unsigned int __uclibc_unused1; /* ACL stuff */ + unsigned int __uclibc_unused2; /* network */ + ino_t __uclibc_unused3; /* network */ + unsigned int __uclibc_unused4; /* cnodes */ + unsigned short __uclibc_unused5; /* netsite */ short st_fstype; unsigned int st_realdev; unsigned short st_basemode; diff -ur libc/sysdeps/linux/i386/bits/kernel_stat.h libc/sysdeps/linux/i386/bits/kernel_stat.h --- a/libc/sysdeps/linux/i386/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/i386/bits/kernel_stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -20,8 +20,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned long __unused4; - unsigned long __unused5; + unsigned long __uclibc_unused4; + unsigned long __uclibc_unused5; }; struct kernel_stat64 { diff -ur libc/sysdeps/linux/ia64/bits/kernel_stat.h libc/sysdeps/linux/ia64/bits/kernel_stat.h --- a/libc/sysdeps/linux/ia64/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/ia64/bits/kernel_stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -24,7 +24,7 @@ struct timespec st_ctim; unsigned long st_blksize; long st_blocks; - unsigned long __unused[3]; + unsigned long __uclibc_unused[3]; }; /* ia64 stat64 is same as stat */ diff -ur libc/sysdeps/linux/ia64/bits/stat.h libc/sysdeps/linux/ia64/bits/stat.h --- a/libc/sysdeps/linux/ia64/bits/stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/ia64/bits/stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -61,7 +61,7 @@ #endif __blksize_t st_blksize; /* Optimal block size for I/O. */ __blkcnt_t st_blocks; /* Nr. 512-byte blocks allocated. */ - long int __unused[3]; + long int __uclibc_unused[3]; }; #ifdef __USE_LARGEFILE64 @@ -100,7 +100,7 @@ #endif __blksize_t st_blksize; /* Optimal block size for I/O. */ __blkcnt64_t st_blocks; /* Nr. 512-byte blocks allocated. */ - long int __unused[3]; + long int __uclibc_unused[3]; }; #endif diff -ur libc/sysdeps/linux/lm32/bits/kernel_stat.h libc/sysdeps/linux/lm32/bits/kernel_stat.h --- a/libc/sysdeps/linux/lm32/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/lm32/bits/kernel_stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -22,8 +22,8 @@ struct timespec st_atim; /* Time of last access. */ struct timespec st_mtim; /* Time of last modification. */ struct timespec st_ctim; /* Time of last status change. */ - unsigned int __unused4; - unsigned int __unused5; + unsigned int __uclibc_unused4; + unsigned int __uclibc_unused5; }; struct kernel_stat64 @@ -43,8 +43,8 @@ struct timespec st_atim; /* Time of last access. */ struct timespec st_mtim; /* Time of last modification. */ struct timespec st_ctim; /* Time of last status change. */ - unsigned int __unused4; - unsigned int __unused5; + unsigned int __uclibc_unused4; + unsigned int __uclibc_unused5; }; #endif /* _BITS_STAT_STRUCT_H */ diff -ur libc/sysdeps/linux/m68k/bits/kernel_stat.h libc/sysdeps/linux/m68k/bits/kernel_stat.h --- a/libc/sysdeps/linux/m68k/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/m68k/bits/kernel_stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -21,8 +21,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned long __unused4; - unsigned long __unused5; + unsigned long __uclibc_unused4; + unsigned long __uclibc_unused5; }; struct kernel_stat64 { diff -ur libc/sysdeps/linux/m68k/bits/stat.h libc/sysdeps/linux/m68k/bits/stat.h --- a/libc/sysdeps/linux/m68k/bits/stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/m68k/bits/stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -82,8 +82,8 @@ unsigned long int st_ctimensec; /* Nsecs of last status change. */ #endif #ifndef __USE_FILE_OFFSET64 - unsigned long int __unused4; - unsigned long int __unused5; + unsigned long int __uclibc_unused4; + unsigned long int __uclibc_unused5; #else __ino64_t st_ino; /* File serial number. */ #endif diff -ur libc/sysdeps/linux/microblaze/bits/kernel_stat.h libc/sysdeps/linux/microblaze/bits/kernel_stat.h --- a/libc/sysdeps/linux/microblaze/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/microblaze/bits/kernel_stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -20,8 +20,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned int __unused4; - unsigned int __unused5; + unsigned int __uclibc_unused4; + unsigned int __uclibc_unused5; }; struct kernel_stat64 @@ -41,8 +41,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned int __unused4; - unsigned int __unused5; + unsigned int __uclibc_unused4; + unsigned int __uclibc_unused5; }; #endif /* _BITS_STAT_STRUCT_H */ diff -ur libc/sysdeps/linux/nds32/bits/kernel_stat.h libc/sysdeps/linux/nds32/bits/kernel_stat.h --- a/libc/sysdeps/linux/nds32/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/nds32/bits/kernel_stat.h 2020-06-11 16:34:02.010197216 +0000 @@ -30,8 +30,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned long __unused4; - unsigned long __unused5; + unsigned long __uclibc_unused4; + unsigned long __uclibc_unused5; }; struct kernel_stat64 { diff -ur libc/sysdeps/linux/nds32/bits/stat.h libc/sysdeps/linux/nds32/bits/stat.h --- a/libc/sysdeps/linux/nds32/bits/stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/nds32/bits/stat.h 2020-06-11 16:34:02.011197218 +0000 @@ -86,8 +86,8 @@ unsigned long int st_ctimensec; /* Nsecs of last status change. */ #endif #ifndef __USE_FILE_OFFSET64 - unsigned long int __unused4; - unsigned long int __unused5; + unsigned long int __uclibc_unused4; + unsigned long int __uclibc_unused5; #else __ino64_t st_ino; /* File serial number. */ #endif diff -ur libc/sysdeps/linux/powerpc/bits/kernel_stat.h libc/sysdeps/linux/powerpc/bits/kernel_stat.h --- a/libc/sysdeps/linux/powerpc/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/powerpc/bits/kernel_stat.h 2020-06-11 16:34:02.011197218 +0000 @@ -22,8 +22,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned long __unused4; - unsigned long __unused5; + unsigned long __uclibc_unused4; + unsigned long __uclibc_unused5; }; #endif @@ -42,8 +42,8 @@ struct timespec st_atim; /* Time of last access. */ struct timespec st_mtim; /* Time of last modification. */ struct timespec st_ctim; /* Time of last status change. */ - unsigned long int __unused4; - unsigned long int __unused5; + unsigned long int __uclibc_unused4; + unsigned long int __uclibc_unused5; }; #endif /* _BITS_STAT_STRUCT_H */ diff -ur libc/sysdeps/linux/powerpc/bits/stat.h libc/sysdeps/linux/powerpc/bits/stat.h --- a/libc/sysdeps/linux/powerpc/bits/stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/powerpc/bits/stat.h 2020-06-11 16:34:02.011197218 +0000 @@ -80,8 +80,8 @@ __time_t st_ctime; /* Time of last status change. */ unsigned long int st_ctimensec; /* Nsecs of last status change. */ #endif - unsigned long int __unused4; - unsigned long int __unused5; + unsigned long int __uclibc_unused4; + unsigned long int __uclibc_unused5; }; @@ -120,8 +120,8 @@ __time_t st_ctime; /* Time of last status change. */ unsigned long int st_ctimensec; /* Nsecs of last status change. */ #endif - unsigned long int __unused4; - unsigned long int __unused5; + unsigned long int __uclibc_unused4; + unsigned long int __uclibc_unused5; }; # endif /* __USE_LARGEFILE64 */ diff -ur libc/sysdeps/linux/sh/bits/kernel_stat.h libc/sysdeps/linux/sh/bits/kernel_stat.h --- a/libc/sysdeps/linux/sh/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/sh/bits/kernel_stat.h 2020-06-11 16:34:02.011197218 +0000 @@ -22,8 +22,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned long __unused4; - unsigned long __unused5; + unsigned long __uclibc_unused4; + unsigned long __uclibc_unused5; }; struct kernel_stat64 { @@ -69,8 +69,8 @@ struct timespec st_mtim; struct timespec st_ctim; - unsigned long __unused1; - unsigned long __unused2; + unsigned long __uclibc_unused1; + unsigned long __uclibc_unused2; }; #endif /* _BITS_STAT_STRUCT_H */ diff -ur libc/sysdeps/linux/sparc/bits/kernel_stat.h libc/sysdeps/linux/sparc/bits/kernel_stat.h --- a/libc/sysdeps/linux/sparc/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/sparc/bits/kernel_stat.h 2020-06-11 16:34:02.011197218 +0000 @@ -19,7 +19,7 @@ struct timespec st_ctim; long st_blksize; long st_blocks; - unsigned long __unused4[2]; + unsigned long __uclibc_unused4[2]; }; struct kernel_stat64 { @@ -38,8 +38,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned int __unused4; - unsigned int __unused5; + unsigned int __uclibc_unused4; + unsigned int __uclibc_unused5; }; #endif /* _BITS_STAT_STRUCT_H */ diff -ur libc/sysdeps/linux/sparc/bits/stat.h libc/sysdeps/linux/sparc/bits/stat.h --- a/libc/sysdeps/linux/sparc/bits/stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/sparc/bits/stat.h 2020-06-11 16:34:02.011197218 +0000 @@ -74,8 +74,8 @@ __time_t st_ctime; /* Time of last status change. */ unsigned long int st_ctimensec; /* Nsecs of last status change. */ #endif - unsigned long int __unused4; - unsigned long int __unused5; + unsigned long int __uclibc_unused4; + unsigned long int __uclibc_unused5; }; #ifdef __USE_LARGEFILE64 @@ -114,8 +114,8 @@ __time_t st_ctime; /* Time of last status change. */ unsigned long int st_ctimensec; /* Nsecs of last status change. */ #endif - unsigned long int __unused4; - unsigned long int __unused5; + unsigned long int __uclibc_unused4; + unsigned long int __uclibc_unused5; }; #endif diff -ur libc/sysdeps/linux/sparc64/bits/kernel_stat.h libc/sysdeps/linux/sparc64/bits/kernel_stat.h --- a/libc/sysdeps/linux/sparc64/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/sparc64/bits/kernel_stat.h 2020-06-11 16:34:02.011197218 +0000 @@ -19,8 +19,8 @@ struct timespec st_ctim; long st_blksize; long st_blocks; - unsigned long __unused4; - unsigned long __unused5; + unsigned long __uclibc_unused4; + unsigned long __uclibc_unused5; }; struct kernel_stat64 { @@ -38,9 +38,9 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - long __unused4; - long __unused5; - long __unused6; + long __uclibc_unused4; + long __uclibc_unused5; + long __uclibc_unused6; }; #endif /* _BITS_STAT_STRUCT_H */ diff -ur libc/sysdeps/linux/sparc64/bits/stat.h libc/sysdeps/linux/sparc64/bits/stat.h --- a/libc/sysdeps/linux/sparc64/bits/stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/sparc64/bits/stat.h 2020-06-11 16:34:02.011197218 +0000 @@ -79,8 +79,8 @@ __time_t st_ctime; /* Time of last status change. */ unsigned long int st_ctimensec; /* Nsecs of last status change. */ #endif - unsigned long int __unused4; - unsigned long int __unused5; + unsigned long int __uclibc_unused4; + unsigned long int __uclibc_unused5; }; #ifdef __USE_LARGEFILE64 @@ -122,8 +122,8 @@ __time_t st_ctime; /* Time of last status change. */ unsigned long int st_ctimensec; /* Nsecs of last status change. */ #endif - unsigned long int __unused4; - unsigned long int __unused5; + unsigned long int __uclibc_unused4; + unsigned long int __uclibc_unused5; }; #endif diff -ur libc/sysdeps/linux/x86_64/bits/kernel_stat.h libc/sysdeps/linux/x86_64/bits/kernel_stat.h --- a/libc/sysdeps/linux/x86_64/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/x86_64/bits/kernel_stat.h 2020-06-11 16:34:02.011197218 +0000 @@ -21,7 +21,7 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - long __unused[3]; + long __uclibc_unused[3]; }; /* x86-64 stat64 is same as stat */ diff -ur libc/sysdeps/linux/x86_64/bits/stat.h libc/sysdeps/linux/x86_64/bits/stat.h --- a/libc/sysdeps/linux/x86_64/bits/stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/x86_64/bits/stat.h 2020-06-11 16:34:02.011197218 +0000 @@ -99,11 +99,11 @@ unsigned long int st_ctimensec; /* Nsecs of last status change. */ #endif #if __WORDSIZE == 64 - long int __unused[3]; + long int __uclibc_unused[3]; #else # ifndef __USE_FILE_OFFSET64 - unsigned long int __unused4; - unsigned long int __unused5; + unsigned long int __uclibc_unused4; + unsigned long int __uclibc_unused5; # else __ino64_t st_ino; /* File serial number. */ # endif @@ -160,7 +160,7 @@ unsigned long int st_ctimensec; /* Nsecs of last status change. */ #endif #if __WORDSIZE == 64 - long int __unused[3]; + long int __uclibc_unused[3]; #else __ino64_t st_ino; /* File serial number. */ #endif diff -ur libc/sysdeps/linux/xtensa/bits/kernel_stat.h libc/sysdeps/linux/xtensa/bits/kernel_stat.h --- a/libc/sysdeps/linux/xtensa/bits/kernel_stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/xtensa/bits/kernel_stat.h 2020-06-11 16:34:02.011197218 +0000 @@ -19,8 +19,8 @@ struct timespec st_atim; struct timespec st_mtim; struct timespec st_ctim; - unsigned long __unused4; - unsigned long __unused5; + unsigned long __uclibc_unused4; + unsigned long __uclibc_unused5; }; struct kernel_stat64 { @@ -33,13 +33,13 @@ unsigned long long st_rdev; /* Device number, if device. */ long long st_size; /* Size of file, in bytes. */ unsigned long st_blksize; /* Optimal block size for I/O. */ - unsigned long __unused2; + unsigned long __uclibc_unused2; unsigned long long st_blocks; /* Number 512-byte blocks allocated. */ struct timespec st_atim; /* Time of last access. */ struct timespec st_mtim; /* Time of last modification. */ struct timespec st_ctim; /* Time of last status change. */ - unsigned long __unused4; - unsigned long __unused5; + unsigned long __uclibc_unused4; + unsigned long __uclibc_unused5; }; #endif /* _BITS_STAT_STRUCT_H */ diff -ur libc/sysdeps/linux/xtensa/bits/stat.h libc/sysdeps/linux/xtensa/bits/stat.h --- a/libc/sysdeps/linux/xtensa/bits/stat.h 2020-03-09 07:43:31.000000000 +0000 +++ b/libc/sysdeps/linux/xtensa/bits/stat.h 2020-06-11 16:34:02.011197218 +0000 @@ -75,8 +75,8 @@ __time_t st_ctime; /* Time of last status change. */ unsigned long int st_ctimensec; /* Nsecs of last status change. */ #endif - unsigned long int __unused4; - unsigned long int __unused5; + unsigned long int __uclibc_unused4; + unsigned long int __uclibc_unused5; }; #ifdef __USE_LARGEFILE64 @@ -112,8 +112,8 @@ __time_t st_ctime; /* Time of last status change. */ unsigned long int st_ctimensec; /* Nsecs of last status change. */ #endif - unsigned long __unused4; - unsigned long __unused5; + unsigned long __uclibc_unused4; + unsigned long __uclibc_unused5; }; #endif

3 5

uclibc-ng and GCC 10 static linking.
by Lance Fredrickson 30 Jun '20

30 Jun '20

I use buildroot to compile toolchains for a project of mine. Jumping to GCC 10 I've run into this issue when static linking. I know I can throw in '-zmuldefs' to force linkage, but it feels dirty. /mmc/lib/gcc/arm-buildroot-linux-uclibcgnueabi/10.1.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: /mmc/usr/lib/libc.a(libdl.os):(.data+0x1c): multiple definition of `_dl_pagesize'; /mmc/usr/lib/libc.a(dl-support.os):(.bss+0x0): first defined here /mmc/lib/gcc/arm-buildroot-linux-uclibcgnueabi/10.1.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: /mmc/usr/lib/libc.a(libdl.os):(.data+0x18): multiple definition of `_dl_tls_static_size'; /mmc/usr/lib/libc.a(libc-tls.os):(.bss+0x34c): first defined here collect2: error: ld returned 1 exit status I wonder if it may be related to GCC 10 now defaulting to -fno-common. https://gcc.gnu.org/gcc-10/porting_to.html thanks, Lance

1 0