devel

devel@uclibc-ng.org

1 participants
1164 discussions

Release announcements
by Ata, John (US) 03 Dec '20

03 Dec '20

Hi, I seem to recall in the past that new uclibc-ng releases would be announced in this group. The last two release announcements (1.0.35 and 1.0.36) do not appear in my feed. Perhaps my mail server discarded them but I wonder if we are still announcing them to the group or are we counting on people manually checking the website? Take care, ---- John Ata, CISSP Senior Principal Software Engineer Electronics Systems STOP Operating System<http://www.baesystems.com/en-us/product/stop> Software Development T 703-563-8115 | F 703-668-4359 | john.ata(a)baesystems.com<mailto:john.ata@baesystems.com> http://www.baesystems.com/csp [cid:image001.png@01D138BC.8E54E330][cid:image003.png@01D138BC.8E54E330]<http://www.twitter.com/baesystemsinc>[cid:image004.png@01D138BC.8E54E330]<http://www.youtube.com/baesystemsinc>[cid:image006.png@01D138BC.8E54E330]<http://www.flickr.com/photos/baesystemsinc/>

1 0

[PATCH] libcrypt: add missing errno.h header
by Yann Sionneau 23 Nov '20

23 Nov '20

Fixes: libcrypt/crypt.c:29:15: error: 'EINVAL' undeclared (first use in this function) __set_errno(EINVAL); ^~~~~~ Signed-off-by: Yann Sionneau <ysionneau(a)kalray.eu> --- libcrypt/crypt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libcrypt/crypt.c b/libcrypt/crypt.c index 9819029f2..cfcd11f91 100644 --- a/libcrypt/crypt.c +++ b/libcrypt/crypt.c @@ -6,6 +6,7 @@ #include <unistd.h> #include <crypt.h> +#include <errno.h> #include "libcrypt.h" char *crypt(const char *key, const char *salt) -- 2.17.1

1 0

[PATCH] misc: add test for hasmntopt() option matching
by yann＠sionneau.net 19 Oct '20

19 Oct '20

From: Yann Sionneau <yann(a)sionneau.net> Signed-off-by: Yann Sionneau <yann(a)sionneau.net> --- test/misc/tst-hasmntopt.c | 47 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 test/misc/tst-hasmntopt.c diff --git a/test/misc/tst-hasmntopt.c b/test/misc/tst-hasmntopt.c new file mode 100644 index 0000000..17655bd --- /dev/null +++ b/test/misc/tst-hasmntopt.c @@ -0,0 +1,47 @@ +/* Copyright (C) 2020 by Yann Sionneau <yann(a)sionneau.net> */ + +#include <stdio.h> +#include <mntent.h> +#include <stdlib.h> +#include <string.h> + +static int +do_test (void) +{ + char *res; + struct mntent m; + + /* check that "ro" does not match "erROr" */ + m.mnt_opts = "error"; + res = hasmntopt (&m, MNTOPT_RO); + if (res != NULL) { + puts ("error: hasmntopt() picked up non existing option"); + exit (1); + } + + /* check that "ro" does not match "remount-ro" */ + m.mnt_opts = "rw,relatime,errors=remount-ro"; + res = hasmntopt (&m, MNTOPT_RO); + if (res != NULL) { + puts ("error: hasmntopt() picked up non existing option"); + exit (1); + } + + /* check that "ro" does match "ro" */ + m.mnt_opts = "noatime,ro"; + res = hasmntopt (&m, MNTOPT_RO); + if (res == NULL) { + puts ("error: hasmntopt() did not pick up an existing option"); + exit (1); + } + + if (strncmp(res, "ro", 2) != 0) { + puts ("error: hasmntopt() did not return a pointer to corresponding option"); + exit (1); + } + + return 0; +} + +#define TEST_FUNCTION do_test () +#include "../test-skeleton.c" -- 2.25.1

2 1

[PATCH] hasmntopt: better option matching
by yann＠sionneau.net 19 Oct '20

19 Oct '20

From: Yann Sionneau <yann(a)sionneau.net> Previous implementation was respecting the man page description of what the function should do. Also the function does not seem to be defined by POSIX. But... to be really useful the function needs to handle option matching and not just substring matching. This is copy pasted from glibc. This fixes issue reported by https://github.com/wbx-github/uclibc-ng/issues/8 that can happen for instance there: https://github.com/frida/glib/blob/master/gio/gunixmounts.c#L622 Signed-off-by: Yann Sionneau <yann(a)sionneau.net> --- libc/misc/mntent/mntent.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/libc/misc/mntent/mntent.c b/libc/misc/mntent/mntent.c index 608f84c1a..610e35af6 100644 --- a/libc/misc/mntent/mntent.c +++ b/libc/misc/mntent/mntent.c @@ -1,5 +1,6 @@ /* * Copyright (C) 2000-2006 Erik Andersen <andersen(a)uclibc.org> + * Copyright (C) 1995-2020 Free Software Foundation, Inc. * * Licensed under the LGPL v2.1, see the file COPYING.LIB in this tarball. */ @@ -92,9 +93,25 @@ int addmntent(FILE * filep, const struct mntent *mnt) mnt->mnt_type, mnt->mnt_opts, mnt->mnt_freq, mnt->mnt_passno) < 0 ? 1 : 0); } -char *hasmntopt(const struct mntent *mnt, const char *opt) +/* Search MNT->mnt_opts for an option matching OPT. + Returns the address of the substring, or null if none found. */ +char *hasmntopt (const struct mntent *mnt, const char *opt) { - return strstr(mnt->mnt_opts, opt); + const size_t optlen = strlen(opt); + char *rest = mnt->mnt_opts, *p; + + while ((p = strstr(rest, opt)) != NULL) { + if ((p == rest || p[-1] == ',') + && (p[optlen] == '\0' || p[optlen] == '=' || p[optlen] == ',')) + return p; + + rest = strchr(p, ','); + if (rest == NULL) + break; + ++rest; + } + + return NULL; } FILE *setmntent(const char *name, const char *mode) -- 2.25.1

2 1

New release
by Petr Vorel 02 Oct '20

02 Oct '20

Hi Waldemar, sorry to be impatient, but would you mind to create release to help distros not backporting all the fixes? Kind regards, Petr

4 8

[PATCH 0/6] Warning fixes
by Yann Sionneau 26 Sep '20

26 Sep '20

This patchset only contains harmless warning fixes. That's a first effort for code cleanup. Yann Sionneau (6): Fix unused variable warning in dl-startup.c Fix warning about missing const qualifier Fix warning about macro redefinition Fix warning due to unused variable in strlen Fix warning due to relaxed function declaration prototype Fix warning due to unused label in NPTL ldso/ldso/dl-startup.c | 6 ++++-- libc/misc/fnmatch/fnmatch_loop.c | 4 ++-- libc/misc/internals/tempname.c | 12 ++++++------ libc/string/generic/strlen.c | 21 ++------------------- libintl/libintl.c | 2 +- libpthread/nptl/allocatestack.c | 2 ++ 6 files changed, 17 insertions(+), 30 deletions(-) -- 2.17.1

2 7

[PATCH 0/2] Fix compilation errors
by Damien Le Moal 18 Sep '20

18 Sep '20

The two patches of this series each fix a compilation error found with buildroot for a RISC-V 64bits NOMMU static-only toolchain. Comments are welcome. Damien Le Moal (2): utils/getconf: Fix compilation error librt: avoid compilation error librt/clock_nanosleep.c | 5 +++-- utils/getconf.c | 20 +++++++++++++++++--- 2 files changed, 20 insertions(+), 5 deletions(-) -- 2.26.2

2 3

[PATCH 0/1] Fix missing Feature Test Macro check in common stat.h
by Yann Sionneau 18 Sep '20

18 Sep '20

This is a touchy change since it touches a common header. This needs a thorough review in order not to break something. But for the record glibc only tests for __USE_XOPEN2K8 and musl does not test for anything at all and directly uses timespec fields. glibc: https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/ge… musl: https://git.musl-libc.org/cgit/musl/tree/arch/aarch64/bits/stat.h Yann Sionneau (1): Fix memory corruption due to struct stat field libc/sysdeps/linux/common-generic/bits/stat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1

2 2

[PATCH] ldso: Fix pointer cast warning
by Yann Sionneau 24 Aug '20

24 Aug '20

Fixes the following compilation warning for 64-bit arch with TLS support: CC ldso/libdl/libdl.oS ldso/libdl/libdl.c: In function 'do_dlsym': ldso/libdl/libdl.c:739:59: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ret = _dl_tls_symaddr ((struct link_map *)sym_ref.tpnt, (Elf32_Addr)ret); ^ --- ldso/libdl/libdl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ldso/libdl/libdl.c b/ldso/libdl/libdl.c index ac0acd504..37c4a876e 100644 --- a/ldso/libdl/libdl.c +++ b/ldso/libdl/libdl.c @@ -187,7 +187,7 @@ static const char *const dl_error_names[] = { */ static void * internal_function -_dl_tls_symaddr(struct link_map *map, const Elf32_Addr st_value) +_dl_tls_symaddr(struct link_map *map, const ElfW(Addr) st_value) { # ifndef DONT_USE_TLS_INDEX tls_index tmp = @@ -736,7 +736,7 @@ static void *do_dlsym(void *vhandle, const char *name, void *caller_address) if (sym_ref.sym && (ELF_ST_TYPE(sym_ref.sym->st_info) == STT_TLS) && (sym_ref.tpnt)) { /* The found symbol is a thread-local storage variable. Return its address for the current thread. */ - ret = _dl_tls_symaddr ((struct link_map *)sym_ref.tpnt, (Elf32_Addr)ret); + ret = _dl_tls_symaddr ((struct link_map *)sym_ref.tpnt, (ElfW(Addr))ret); } #endif -- 2.17.1

1 0

[PATCH 1/1] Add {name, open}_to_handle_at() implementation
by Petr Vorel 18 Aug '20

18 Aug '20

copied from musl 1.2.1. Signed-off-by: Petr Vorel <petr.vorel(a)gmail.com> --- Hi, these are new dependencies for iproute2. Kind regards, Petr include/fcntl.h | 12 +++++++ libc/sysdeps/linux/common/Makefile.in | 2 ++ libc/sysdeps/linux/common/name_to_handle_at.c | 36 +++++++++++++++++++ libc/sysdeps/linux/common/open_by_handle_at.c | 34 ++++++++++++++++++ 4 files changed, 84 insertions(+) create mode 100644 libc/sysdeps/linux/common/name_to_handle_at.c create mode 100644 libc/sysdeps/linux/common/open_by_handle_at.c diff --git a/include/fcntl.h b/include/fcntl.h index e8a781f28..02d4b0110 100644 --- a/include/fcntl.h +++ b/include/fcntl.h @@ -281,6 +281,18 @@ extern int fallocate64 (int __fd, int __mode, __off64_t __offset, __off64_t __le # endif #endif +#if (defined __UCLIBC_LINUX_SPECIFIC__ && defined __USE_GNU) +struct file_handle { + unsigned handle_bytes; + int handle_type; + unsigned char f_handle[]; +}; + +int name_to_handle_at(int dirfd, const char *pathname, + struct file_handle *handle, int *mount_id, int flags); +int open_by_handle_at(int mount_fd, struct file_handle *handle, int flags); +#endif + __END_DECLS #endif /* fcntl.h */ diff --git a/libc/sysdeps/linux/common/Makefile.in b/libc/sysdeps/linux/common/Makefile.in index f114a5bd1..9562de52c 100644 --- a/libc/sysdeps/linux/common/Makefile.in +++ b/libc/sysdeps/linux/common/Makefile.in @@ -32,6 +32,8 @@ CSRC-$(UCLIBC_LINUX_SPECIFIC) += \ iopl.c \ modify_ldt.c \ module.c \ + name_to_handle_at.c \ + open_by_handle_at.c \ personality.c \ pipe2.c \ ppoll.c \ diff --git a/libc/sysdeps/linux/common/name_to_handle_at.c b/libc/sysdeps/linux/common/name_to_handle_at.c new file mode 100644 index 000000000..20c67cbca --- /dev/null +++ b/libc/sysdeps/linux/common/name_to_handle_at.c @@ -0,0 +1,36 @@ +/* + * Copyright © 2005-2020 Rich Felker, et al. + * + * Permission is hereby granted, free of charge, to any person obtaining + * a copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sublicense, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * Imported from musl C library + */ + +#include <sys/syscall.h> + +#ifdef __NR_open_by_handle_at +#include <fcntl.h> +int name_to_handle_at(int dirfd, const char *pathname, + struct file_handle *handle, int *mount_id, int flags) +{ + return INLINE_SYSCALL(name_to_handle_at, 5, dirfd, pathname, handle, + mount_id, flags); +} +#endif diff --git a/libc/sysdeps/linux/common/open_by_handle_at.c b/libc/sysdeps/linux/common/open_by_handle_at.c new file mode 100644 index 000000000..5e65648a6 --- /dev/null +++ b/libc/sysdeps/linux/common/open_by_handle_at.c @@ -0,0 +1,34 @@ +/* + * Copyright © 2005-2020 Rich Felker, et al. + * + * Permission is hereby granted, free of charge, to any person obtaining + * a copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sublicense, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * Imported from musl C library + */ + +#include <sys/syscall.h> + +#ifdef __NR_open_by_handle_at +#include <fcntl.h> +int open_by_handle_at(int mount_fd, struct file_handle *handle, int flags) +{ + return INLINE_SYSCALL(open_by_handle_at, 3, mount_fd, handle, flags); +} +#endif -- 2.28.0

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

devel